status-im
/
nim-eth
mirror of https://github.com/status-im/nim-eth.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
665 Commits 24 Branches 0 Tags 6.6 MiB
Commit Graph

20 Commits

Author SHA1 Message Date
Jamie Lokier 5234e30f8b Remove `{.rlpInline.}` which was never really implemented 
For a long time this caused invalid RLP parsing of `NewBlock` messages in the
`eth` protocol.

The `rlpInline` pragma was accepted but had no effect.  We could implemented
it, but it doesn't seem worth doing, with tests etc, as there's only one user
which has been fixed another way.

With `NewBlock`, whenever a peer sent us `NewBlock`, we'd get an RLP decoding
error, and disconnected the peer thinking it was the peer's error.

These messages are sent often by good peers, so whenever we connected to a
really good peer, we'd end up disconnecting within a minute due to this.  This
went unnoticed for years, as we stayed connected to old peers which have no new
blocks, and we weren't looking at peer quality, disconnect reasons or real-time
blockchain updates anyway.

Signed-off-by: Jamie Lokier <jamie@shareable.org>
 2021-08-10 14:08:35 +03:00
Kim De Mey c5dace27ca
Use chronos http server for dcli metrics and remove insecure compile flag (#343) 
And add cfg file to default have runtime log filtering on
 2021-04-02 17:29:38 +02:00
Kim De Mey 207b783253
Nimble file cleanup and group discv5 tests to compile once (#340) 2021-03-29 15:26:34 +02:00
Kim De Mey be92a68d4c
Update discv5.md 
Update some documentation in the discv5 docs.
 2021-02-16 11:44:03 +01:00
Kim De Mey ab969f72c1
Update discv5.md 2021-01-14 09:26:19 +01:00
Kim De Mey 603fee9699
Update discv5.md 2020-10-05 15:47:40 +02:00
Kim De Mey f3de959261
Discv5 readme (#278) 
* Add discovery v5 readme + test_discv5 task

* Move hkdf tests to test file and add to nimble task
 2020-07-12 23:53:27 +02:00
Jacek Sieka fd6caa0fdc
Rlp experimental (#227) 
* rlp: remove experimental features

* avoid range library

* trie: avoid reference-unsafe bitrange type
 2020-04-20 20:14:39 +02:00
Kim De Mey 8028966005
Rlp readme corrections [skip ci] 2020-03-25 21:23:50 +01:00
Dean Eigenmann 2352616273 Update p2p.md 2020-03-12 18:44:22 +02:00
Zahary Karadjov 9364a2640a Get rid of some remaining references to rlp.PrematureFinalizationError 2020-02-06 16:32:00 +01:00
Zahary Karadjov a54fdc8073 Cosmetic renames to match the protocol naming conventions 2019-11-25 19:55:41 +02:00
kdeme 843f9c3916
Update p2p.md 
Add explanation on async proc
 2019-08-20 17:33:43 +02:00
kdeme ece0d7fdbb
Update p2p.md 
some fixes and updating the handshake mechanism.
 2019-08-20 17:00:25 +02:00
Bruno Škvorc c9f1b30c9d
Update p2p.md 2019-08-14 13:48:18 +02:00
Bruno Škvorc 2bb01a787f
Update rlp.md 2019-08-14 13:47:40 +02:00
kdeme 46255c31d1 Make use of peer.connectionState in whisper and blockchain sync + add note in docs 2019-06-12 16:30:01 +03:00
Ștefan Talpalaru 9146e8e2f0
assert() -> doAssert() 2019-03-13 23:15:26 +01:00
Yuriy Glukhov 0bc80d73cd Minor doc fixes 2019-02-06 11:15:03 +01:00
Yuriy Glukhov db6d7888c7 Added docs 2019-02-06 10:57:08 +01:00