Commit Graph

6 Commits

Author SHA1 Message Date
Jamie Lokier 5234e30f8b Remove `{.rlpInline.}` which was never really implemented
For a long time this caused invalid RLP parsing of `NewBlock` messages in the
`eth` protocol.

The `rlpInline` pragma was accepted but had no effect.  We could implemented
it, but it doesn't seem worth doing, with tests etc, as there's only one user
which has been fixed another way.

With `NewBlock`, whenever a peer sent us `NewBlock`, we'd get an RLP decoding
error, and disconnected the peer thinking it was the peer's error.

These messages are sent often by good peers, so whenever we connected to a
really good peer, we'd end up disconnecting within a minute due to this.  This
went unnoticed for years, as we stayed connected to old peers which have no new
blocks, and we weren't looking at peer quality, disconnect reasons or real-time
blockchain updates anyway.

Signed-off-by: Jamie Lokier <jamie@shareable.org>
2021-08-10 14:08:35 +03:00
Jacek Sieka fd6caa0fdc
Rlp experimental (#227)
* rlp: remove experimental features

* avoid range library

* trie: avoid reference-unsafe bitrange type
2020-04-20 20:14:39 +02:00
Kim De Mey 8028966005
Rlp readme corrections [skip ci] 2020-03-25 21:23:50 +01:00
Zahary Karadjov 9364a2640a Get rid of some remaining references to rlp.PrematureFinalizationError 2020-02-06 16:32:00 +01:00
Bruno Škvorc 2bb01a787f
Update rlp.md 2019-08-14 13:47:40 +02:00
Yuriy Glukhov db6d7888c7 Added docs 2019-02-06 10:57:08 +01:00