b874e12516
Differentiate log for invalid packet seqnr without reorder buffer and not ( #723 )
2024-08-29 18:15:26 +02:00
26212c881b
Use results.Opt instead of option in discv5, utp and nat ( #705 )
...
+ some other minor cleanups
2024-06-18 18:09:27 +02:00
f169068df6
Fix missing CancelledError on discv5 waitMessage + results imports ( #704 )
...
Fixes a missing CancelledError async raising on discv5 waitMessage
which would cause "Error set on a non-raising future".
Also moves some more results import away from stew.
2024-06-13 12:11:25 +02:00
207244c2db
Add more missing async raises in uTP ( #702 )
2024-06-12 18:01:23 +02:00
c3f9160fd2
Add async raises annotations for uTP code ( #692 )
...
* Add async raises annotations for uTP code
* Avoid compiler error + further clean-up
2024-06-11 13:56:37 +02:00
19965bab95
Fix chronos related deprecated warnings in uTP code part II ( #669 )
...
This also makes the uTP SendCallBack not returning a Future any
more as it is not used in sendData anyhow. And in case of uTP
over discv5, discv5 send call is already not async.
This gives quite a noticable throughput benchmark improvement over
with uTP over UDP, and a slightly noticable with uTP over discv5
2024-01-23 18:41:38 +01:00
496bcdab74
Fix chronos related deprecated warnings in discv5 and uTP ( #667 )
...
* Fix chronos related deprecated warnings in discv5
* Fix chronos related deprecated warnings in uTP code
* Improve discv5 closeWait order of events and add noCancel
2024-01-22 17:08:08 +01:00
974a995b21
Add uTP over discv5 test and small uTP performance improvements ( #663 )
...
- Add a multiple sockets use test for uTP over discv5
- Use assign2 for the biggest consumer of genericAssignAux in uTP
- Avoid calling exists on the growable buffer when there is no
place in the socket window.
2024-01-18 12:07:03 +01:00
cbcd1fd307
Fix for uTP issues with latest chronos ( #655 )
...
* Fix for uTP issues with latest chronos
* Fix for discv5 issue with latest chronos
* Increase amount of data send in uTP and uTP over discv5 tests
2024-01-12 17:35:44 +01:00
11049fb87d
Fix a bunch of compiler hints and warnings in uTP and discv5 ( #652 )
...
* Fix a bunch of compiler hints and warnings in uTP and discv5
* Leave in the cancel() for now
2024-01-12 09:49:06 +01:00
c5dd5e4115
Enable tests with also json sink and fix failures ( #624 )
...
And a few minor cleanups
2023-06-22 16:13:16 +00:00
d74dc40bee
Style fixes and comment improvements on uTP code ( #623 )
2023-06-22 11:31:30 +00:00
c3860244b1
Fix potentential uTP socket leak for socket in SynSent state ( #620 )
...
Socket leak could because ST_DATA (and ST_FIN) packets for sockets
not in connected stated were only dropped after appling acks.
2023-06-21 12:44:52 +02:00
cea23299be
Avoid double socket destroy on timed-out uTP SYN-ACK ( #619 )
2023-06-15 12:26:22 +02:00
d57a1094b1
Remove all Defect raises to avoid unnecessary warnings ( #607 )
...
As this module dropped support for Nim versions < 1.6, all Defect
raises can be removed to avoid unnecessary warnings
2023-05-10 15:50:04 +02:00
ea3c164a00
uTP clarification on SYN-ACK seqnr and some cleanup ( #596 )
...
- Clarify why on SYN-ACK seqNr gets -1
- Cleanup comments
- Style fixes
- Reuse WriteResult
2023-04-04 17:11:36 +02:00
5c46220e72
add eth topic to all the logs scope ( #568 )
2022-12-06 14:54:03 +01:00
22d0ac81e1
Fix defect when writing over send buffer ( #564 )
...
* Fix defect when writing over send buffer
2022-11-30 09:34:08 +01:00
e7d3de6ebf
Fix some typos ( #557 )
2022-11-16 17:44:00 +01:00
a5ea6a9a90
Add connection limits to utp ( #522 )
2022-08-04 15:55:39 +02:00
1b516682bd
bearssl: use split api ( #510 )
2022-06-17 22:45:37 +02:00
01684a2130
Adjust uTP log levels to be more user focused ( #502 )
...
Also cleanup several whitespace and line char limits
2022-04-12 21:11:01 +02:00
eb785207ae
Make packet size configurable ( #497 )
...
* Make packet size configurable
2022-04-04 13:44:32 +02:00
c28597fee5
Change closing proc ( #492 )
2022-03-28 12:35:08 +02:00
e794c149f5
Fix compilation error ( #490 )
2022-03-18 15:53:51 +01:00
0e20fd6565
Utp improvements ( #489 )
...
* Move connection finalization to separate function
* Do not process data unless in correct state
2022-03-18 08:13:17 +01:00
dff9040cc1
Fix bug when reading till eof ( #483 )
2022-03-03 22:38:13 +01:00
8ef6b13b1b
Add event loop to socket ( #475 )
...
- add eventLoop to control all incoming events
- change semantic of write to asynchronously block only when send buffer is full, and not when bytes do not fit into send window
- change handling of receive buffer, to start dropping packets if the reorder buffer and receive buffer are full. Old behaviour was to async block unless there is space which could lead to resource exhaustion attacks
2022-02-24 18:22:44 +01:00
779d767b02
Add more tests stressing conccurent reading and writing on utp socket ( #474 )
...
* Add more tests stressing concurrent reading and writing
* Fix bug when remote window dropped below packet size
2022-02-10 08:05:44 +01:00
5791afccc3
Implement fast resend logic for selective acks ( #468 )
...
* Implement fast resend logic for selective acks
2022-01-27 11:07:40 +01:00
7afd44d33e
Implement fast resend logic ( #466 )
2022-01-26 09:49:34 +01:00
4e2b340af6
Fix sudden window drop bug ( #465 )
...
Fixes problem which caused drop of maxWindow to the size of
only one packet in case of only one packet hitting timeout.
2022-01-21 14:48:01 +01:00
45348e7664
Add more logs to utp ( #463 )
...
* Add more logs to utp
* Change initial timeout for inc socket to positive value
2022-01-20 13:20:30 +01:00
b2dab4be08
Re-send acks for old duplicated packets ( #462 )
...
* Re-send acks for old duplicated packets
2022-01-20 09:22:53 +01:00
26ab9b078e
Minor adjustments in utp_discv5_protocol ( #459 )
...
- Move SocketConfig parameter location
- Reuse rng from disc5 protocol
- add exports
- Some whitespace clean-up
2022-01-10 13:49:36 +01:00
fcb0ff521c
Improve logging in uTP ( #457 )
...
* Improve logging
2022-01-07 10:38:19 +01:00
9c8e9d9f64
Handle selective acks ( #456 )
...
* Handle selective acks
2022-01-04 09:52:38 +01:00
2c236f6495
Style fixes according to --styleCheck:usages ( #452 )
...
Currently only setting `--styleCheck:hint` as there are some
dependency fixes required and the compiler seems to trip over the
findnode MessageKind, findnode Message field and the findNode
proc. Also over protocol.Protocol usage.
2021-12-20 13:14:50 +01:00
b56e19a590
Improve handling of timestamps ( #446 )
...
* Improve handling of timestamps
2021-12-10 16:28:00 +01:00
41d2d3c991
Utp top level raises & some clean-up ( #445 )
...
* Add few missing top level raises Defect in uTP
- Add top level {.push raises: [Defect].}
- remove some local raises, including some unneeded
CatchableErrors.
- Don't export messageHandler (avoiding annoying naming collisions)
- export utp_router as those connection callbacks are in the API
* Add some missing copyright clauses
* Some ident and max line length cleanup
* Rename utp_discv5_protocol.nim to be more consistent
2021-12-10 11:12:24 +01:00
09959d2a3f
Update timestamp and ackNr on packet resend ( #444 )
...
* Update timestamp and ackNr on packet resend
2021-12-10 10:18:00 +01:00
b4066a5688
Ledbat congestion control ( #443 )
...
* Return delay to remote peer
* Initial ledbat window calculation
* Add tests for window grow and decay
* Add delay histograms
* Add calculation of clock drift
2021-12-09 10:52:21 +01:00
e7bc10ab00
Add config for max snd buffer size ( #440 )
...
* Add config for max snd buffer size
2021-12-02 16:51:44 +01:00
3c8915cae1
Track send buffer and properly handle back pressoure when window is to small to process data ( #437 )
...
* Add separate datastructure to keep track of window
* Asynchronously block write until until new space in snd buffer
* Introduce write loop
* Properly handle write cancellation
* Proper handling of sending fin packet
* Reset remote window after configured amount of time
2021-12-02 15:46:18 +01:00
139c6fa2a8
Track current bytes in flight ( #434 )
2021-11-24 17:49:13 +01:00
ce296ff76e
Make initial state of socket configurable ( #428 )
...
* Make initial state of socket configurable
2021-11-19 11:36:46 +01:00
d5e5ec9f90
Add possibility to connect with requested conneciton id ( #425 )
...
* Improve error handling when initiating connection
* Add api to connect with requested id
* Add callback to allow only specific incoming peers
2021-11-18 10:05:56 +01:00
73d9bf4c80
Add ackNr validation ( #424 )
2021-11-15 11:32:00 +01:00
8139aae346
Advertise correct rcv buffer size ( #423 )
...
* Advertise correct rcv buffer size
2021-11-12 10:58:49 +01:00
b671f6c901
Handling of fin packet ( #421 )
...
* Handling of connection finalization by sending and receiving FIN packets
2021-11-09 15:29:59 +01:00
Kim De Mey
Lorenzo Delgado
KonradStaniec
Justin Traglia
Jacek Sieka