status-im
/
nim-eth
mirror of https://github.com/status-im/nim-eth.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove unused lastUpdated from buckets (#382)

This commit is contained in:
Kim De Mey 2021-07-29 21:58:10 +02:00 committed by GitHub
parent 04ff8e460f
commit dd02d1be23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
eth/p2p/discoveryv5/routing_table.nim
View File

@ -46,7 +46,6 @@ type
replacementCache: seq[Node] ## Nodes that could not be added to the `nodes` replacementCache: seq[Node] ## Nodes that could not be added to the `nodes`
## seq as it is full and without stale nodes. This is practically a small ## seq as it is full and without stale nodes. This is practically a small
## LRU cache. ## LRU cache.
lastUpdated: float ## epochTime of last update to `nodes` in the KBucket.
ipLimits: IpLimits ## IP limits for bucket: node entries and replacement ipLimits: IpLimits ## IP limits for bucket: node entries and replacement
## cache entries combined. ## cache entries combined.
@ -470,7 +469,6 @@ proc setJustSeen*(r: RoutingTable, n: Node) =
if idx >= 0: if idx >= 0:
if idx != 0: if idx != 0:
b.nodes.moveRight(0, idx - 1) b.nodes.moveRight(0, idx - 1)
b.lastUpdated = epochTime()
if not n.seen: if not n.seen:
b.nodes[0].seen = true b.nodes[0].seen = true
@ -481,9 +479,8 @@ proc nodeToRevalidate*(r: RoutingTable): Node =
## bucket is selected. ## bucket is selected.
var buckets = r.buckets var buckets = r.buckets
r.rng[].shuffle(buckets) r.rng[].shuffle(buckets)
# TODO: Should we prioritize less-recently-updated buckets instead? Could use # TODO: Should we prioritize less-recently-updated buckets instead? Could
# `lastUpdated` for this, but it would probably make more sense to only update # store a `now` Moment at setJustSeen or at revalidate per bucket.
# that value on revalidation then and rename it to `lastValidated`.
for b in buckets: for b in buckets:
if b.len > 0: if b.len > 0:
return b.nodes[^1] return b.nodes[^1]