status-im
/
nim-eth
mirror of https://github.com/status-im/nim-eth.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Log the IP-address + Port when a discv5 send fails (#542) 

This is specifically useful for when the failure is caused by an
"Operation not permitted", as then we can see for which specific
port(s) a firewall might be blocking outgoing traffic.
This commit is contained in:
Kim De Mey 2022-10-10 10:33:40 +02:00 committed by GitHub
parent 3e44299b49
commit ceac50c62f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
eth/p2p/discoveryv5/protocol.nim
View File

@ -258,13 +258,15 @@ proc send*(d: Protocol, a: Address, data: seq[byte]) =
# closed, or could be `TransportOsError` in case of a socket error. # closed, or could be `TransportOsError` in case of a socket error.
# In the latter case this would probably mostly occur if the network # In the latter case this would probably mostly occur if the network
# interface underneath gets disconnected or similar. # interface underneath gets disconnected or similar.
# It could also be an "Operation not permitted" error, which would
# indicate a firewall restriction kicking in.
# TODO: Should this kind of error be propagated upwards? Probably, but # TODO: Should this kind of error be propagated upwards? Probably, but
# it should not stop the process as that would reset the discovery # it should not stop the process as that would reset the discovery
# progress in case there is even a small window of no connection. # progress in case there is even a small window of no connection.
# One case that needs this error available upwards is when revalidating # One case that needs this error available upwards is when revalidating
# nodes. Else the revalidation might end up clearing the routing tabl # nodes. Else the revalidation might end up clearing the routing tabl
# because of ping failures due to own network connection failure. # because of ping failures due to own network connection failure.
warn "Discovery send failed", msg = f.readError.msg warn "Discovery send failed", msg = f.readError.msg, address = a
proc send(d: Protocol, n: Node, data: seq[byte]) = proc send(d: Protocol, n: Node, data: seq[byte]) =
doAssert(n.address.isSome()) doAssert(n.address.isSome())