status-im
/
nim-eth
mirror of https://github.com/status-im/nim-eth.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix `excessDataGas` type (`GasInt` --> `UInt256`) (#571) 

Used incorrect type in original PR. Fixing.
This commit is contained in:
Etan Kissling 2022-12-14 00:25:27 +01:00 committed by GitHub
parent c9fcab8052
commit 2b5f2a27e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
eth/common/eth_types.nim
View File

@ -121,7 +121,7 @@ type
# `baseFee` is the get/set of `fee` # `baseFee` is the get/set of `fee`
fee*: Option[UInt256] # EIP-1559 fee*: Option[UInt256] # EIP-1559
withdrawalsRoot*: Option[Hash256] # EIP-4895 withdrawalsRoot*: Option[Hash256] # EIP-4895
excessDataGas*: Option[GasInt] # EIP-4844 excessDataGas*: Option[UInt256] # EIP-4844
BlockBody* = object BlockBody* = object
transactions*: seq[Transaction] transactions*: seq[Transaction]

2
eth/common/eth_types_rlp.nim
View File

@ -350,7 +350,7 @@ proc read*(rlp: var Rlp, T: type BlockHeader): T =
result.withdrawalsRoot = some rlp.read(Hash256) result.withdrawalsRoot = some rlp.read(Hash256)
if len >= 18: if len >= 18:
# EIP-4844 # EIP-4844
result.excessDataGas = some rlp.read(GasInt) result.excessDataGas = some rlp.read(UInt256)
proc rlpHash*[T](v: T): Hash256 = proc rlpHash*[T](v: T): Hash256 =
keccakHash(rlp.encode(v)) keccakHash(rlp.encode(v))

2
tests/rlp/test_common.nim
View File

@ -116,7 +116,7 @@ proc suite2() =
doTest h doTest h
# EIP-4844 # EIP-4844
h.excessDataGas = some GasInt(1337) h.excessDataGas = some 1234.u256
doTest h doTest h
suite1() suite1()