From 224048a1d5bbd2c76097d497a33fb2eff91741a4 Mon Sep 17 00:00:00 2001 From: andri lim Date: Wed, 12 Jun 2024 13:29:57 +0700 Subject: [PATCH] Revert perPeerMsgIdVar type until it properly fixed (#701) * Revert perPeerMsgIdVar type until it properly fixed * Add reminder --- eth/p2p/rlpx.nim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eth/p2p/rlpx.nim b/eth/p2p/rlpx.nim index 7a4cefa..7afb215 100644 --- a/eth/p2p/rlpx.nim +++ b/eth/p2p/rlpx.nim @@ -1000,7 +1000,8 @@ proc p2pProtocolBackendImpl*(protocol: P2PProtocol): Backend = var `rlpWriter` = `initRlpWriter`() const `perProtocolMsgIdVar` {.used.} = `msgId` let `perPeerMsgIdVar` = `perPeerMsgIdValue` - `append`(`rlpWriter`, `perPeerMsgIdVar`.uint) + # TODO: rlpx should error if perPeerMsgIdVar is signed + `append`(`rlpWriter`, `perPeerMsgIdVar`) when tracingEnabled: appendParams.add logSentMsgFields(peerVar, protocol, msgId, paramsToWrite)