status-im
/
nim-eth
mirror of https://github.com/status-im/nim-eth.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
nim-eth/tests/p2p/test_rlpx_thunk.json

86 lines
3.3 KiB
JSON
Raw Normal View History

Add unittest for rlpx thunk payload tests
2019-10-22 12:08:25 +00:00
{
"Invalid list when decoding for object": {
"payload": "03",
rlp: refresh code (#683) A first step in cleaning up RLP, which has lots of interesting issues - the next step would be to clean up the exception handling as well (Resultify?) * remove `RlpNode` (unused) * single-pass parsing for most functionality via RlpItem * stricter conformance to spec * remove float support * warn about signed integers * raise on invalid RLP earlier * avoid several pointless allocations, in particular in `listLen`, `listElem` etc * include spec docs
2024-05-26 07:58:24 +00:00
"error": "MalformedRlpError",
Add unittest for rlpx thunk payload tests
2019-10-22 12:08:25 +00:00
"description": "Object parameters are expected to be encoded in an RLP list"
},
"Message id that is not supported": {
"payload": "08",
"error": "UnsupportedMessageError",
Delete Whisper remains (moved to nim-waku) (#386) Types, protocols, tests, hardcoded nodes, references. Now part of nim-waku: - https://github.com/status-im/nim-waku/pull/663 - https://github.com/status-im/nim-waku/pull/678
2022-06-20 16:10:50 +00:00
"description": "This is a message id not used by devp2p or eth"
Add unittest for rlpx thunk payload tests
2019-10-22 12:08:25 +00:00
},
Using unsigned types for message type and requst IDs (#722) * Using unsigned types for message type and requst IDs why: Negative values are neither defined for RLP nor in the protocol specs which refer to the RLPs (see yellow paper app B clause (199). * Fix `int` argument (must be `uint`) in fuzzing tests why: Not part of all tests so it slipped through.
2024-08-30 17:27:09 +00:00
"Message id that is bigger than uint32": {
Add unittest for rlpx thunk payload tests
2019-10-22 12:08:25 +00:00
"payload": "888888888888888888",
rlp: refresh code (#683) A first step in cleaning up RLP, which has lots of interesting issues - the next step would be to clean up the exception handling as well (Resultify?) * remove `RlpNode` (unused) * single-pass parsing for most functionality via RlpItem * stricter conformance to spec * remove float support * warn about signed integers * raise on invalid RLP earlier * avoid several pointless allocations, in particular in `listLen`, `listElem` etc * include spec docs
2024-05-26 07:58:24 +00:00
"error": "UnsupportedRlpError",
Make msgId fixed int32
2019-10-22 15:00:19 +00:00
"description": "This payload will result in too large int for a message id"
},
Using unsigned types for message type and requst IDs (#722) * Using unsigned types for message type and requst IDs why: Negative values are neither defined for RLP nor in the protocol specs which refer to the RLPs (see yellow paper app B clause (199). * Fix `int` argument (must be `uint`) in fuzzing tests why: Not part of all tests so it slipped through.
2024-08-30 17:27:09 +00:00
"Unsupported big message id": {
"payload": "848888888888",
"error": "UnsupportedMessageError",
Add unittest for rlpx thunk payload tests
2019-10-22 12:08:25 +00:00
"description": "This payload will result in a negative number as message id"
},
"No Hash nor Status, but empty list": {
"payload": "20c1c0",
"error": "RlpTypeMismatch",
"description": "Decoding to HashOrStatus expects blob of size 1 or 32"
},
"No Hash nor Status, list instead of blob": {
"payload": "20c2c1c0",
"error": "RlpTypeMismatch",
"description": "Decoding to HashOrStatus expects blob of size 1 or 32"
},
"No Hash nor Status, blob of 2 bytes": {
"payload": "20c4c3820011",
"error": "RlpTypeMismatch",
"description": "Decoding to HashOrStatus expects blob of size 1 or 32"
},
"No Hash nor Status, blob of 33 bytes": {
"payload": "20e3e2a100112233445566778899aabbccddeeff00112233445566778899aabbcceeddff33",
"error": "RlpTypeMismatch",
"description": "Decoding to HashOrStatus expects blob of size 1 or 32"
},
"Listing elements when no data": {
"payload": "01e1",
"error": "MalformedRlpError",
"description": "listElem to error on empty list"
},
"Listing elements when invalid length": {
"payload": "01ffdada",
"error": "MalformedRlpError",
"description": "listElem to error on invalid size encoding"
},
Mitigating RLP annoyances why: Rlp errors throw exceptions which cause the dispatcher loop to terminate the current session immediately. details: The DisconnectionReasonList message requires a single entry list. Observed and now accepted deviations are: Geth: single byte number bor(a Geth fork): blobbed single entry list containing a number
2022-02-21 12:50:20 +00:00
"Listing single element list when having more entries": {
"payload": "01c20420",
Add unittest for rlpx thunk payload tests
2019-10-22 12:08:25 +00:00
"error": "RlpTypeMismatch",
Mitigating RLP annoyances why: Rlp errors throw exceptions which cause the dispatcher loop to terminate the current session immediately. details: The DisconnectionReasonList message requires a single entry list. Observed and now accepted deviations are: Geth: single byte number bor(a Geth fork): blobbed single entry list containing a number
2022-02-21 12:50:20 +00:00
"description": "listElem to assert on not a single entry list"
},
"Listing single element list when having empty list": {
"payload": "01c0",
"error": "RlpTypeMismatch",
"description": "listElem to assert on not a single entry list"
Add EIP-8 test + activate rlpx thunk test
2019-10-22 13:14:14 +00:00
},
Fix RLP deserialzation for Enum with holes (#554) RLP Enum deserialization would currently not check if "hole values" were attempted to be converted to the enum type. Now use checkedEnumAssign and fail with RlpTypeMismatch on invalid values. There is at least one occurance of an enum with holes in rlpx p2p: DisconnectionReason. For this enum the issue could occur. Also: - Added enum RLP tests and rlpx p2p disconnect message tests to test the DisconnectionReason with enum hole value. - Fixed worse custom DisconnectionReason decoding occurance in rlpx in waitSingleMsg proc where this issue could occur.
2022-11-14 14:49:37 +00:00
"DisconnectReason: single element list with entry out off enum range": {
"payload": "01c111",
Dedicated RLP reader for `DisconnectionReason` (#507) * Provide dedicated `DisconnectionReason` enum type RLP reader why: Without this reader, the program communicating via RLPX will crash when receiving out of bound reason codes disconnect message. Out of bound value assignments to an enum causes a `RangeError`defect and consequently the program to terminate. This `RangeError` is avoided here and a `MalformedRlpError` catchable error raised. * Using default exception type in bespoke `read(DisconnectionReason)` why: This should not differ from the default enum parser. The particular message is different and more targeted, here. Note: The default RLP parser was not used because ` `array[1,DisconnectionReason]` is currently not properly handled and should give a siliar error message as a `DisconnectionReason` error. * De-clutter, custom read() was not needed Co-authored-by: jordan <jordan@curd.mjh-it.com>
2022-05-26 09:23:40 +00:00
"error": "RlpTypeMismatch",
Fix RLP deserialzation for Enum with holes (#554) RLP Enum deserialization would currently not check if "hole values" were attempted to be converted to the enum type. Now use checkedEnumAssign and fail with RlpTypeMismatch on invalid values. There is at least one occurance of an enum with holes in rlpx p2p: DisconnectionReason. For this enum the issue could occur. Also: - Added enum RLP tests and rlpx p2p disconnect message tests to test the DisconnectionReason with enum hole value. - Fixed worse custom DisconnectionReason decoding occurance in rlpx in waitSingleMsg proc where this issue could occur.
2022-11-14 14:49:37 +00:00
"description": "Disconnect reason code out of bounds 0..16 (got: 17)"
Dedicated RLP reader for `DisconnectionReason` (#507) * Provide dedicated `DisconnectionReason` enum type RLP reader why: Without this reader, the program communicating via RLPX will crash when receiving out of bound reason codes disconnect message. Out of bound value assignments to an enum causes a `RangeError`defect and consequently the program to terminate. This `RangeError` is avoided here and a `MalformedRlpError` catchable error raised. * Using default exception type in bespoke `read(DisconnectionReason)` why: This should not differ from the default enum parser. The particular message is different and more targeted, here. Note: The default RLP parser was not used because ` `array[1,DisconnectionReason]` is currently not properly handled and should give a siliar error message as a `DisconnectionReason` error. * De-clutter, custom read() was not needed Co-authored-by: jordan <jordan@curd.mjh-it.com>
2022-05-26 09:23:40 +00:00
},
Fix RLP deserialzation for Enum with holes (#554) RLP Enum deserialization would currently not check if "hole values" were attempted to be converted to the enum type. Now use checkedEnumAssign and fail with RlpTypeMismatch on invalid values. There is at least one occurance of an enum with holes in rlpx p2p: DisconnectionReason. For this enum the issue could occur. Also: - Added enum RLP tests and rlpx p2p disconnect message tests to test the DisconnectionReason with enum hole value. - Fixed worse custom DisconnectionReason decoding occurance in rlpx in waitSingleMsg proc where this issue could occur.
2022-11-14 14:49:37 +00:00
"DisconnectReason: single element out off enum range": {
"payload": "0111",
Dedicated RLP reader for `DisconnectionReason` (#507) * Provide dedicated `DisconnectionReason` enum type RLP reader why: Without this reader, the program communicating via RLPX will crash when receiving out of bound reason codes disconnect message. Out of bound value assignments to an enum causes a `RangeError`defect and consequently the program to terminate. This `RangeError` is avoided here and a `MalformedRlpError` catchable error raised. * Using default exception type in bespoke `read(DisconnectionReason)` why: This should not differ from the default enum parser. The particular message is different and more targeted, here. Note: The default RLP parser was not used because ` `array[1,DisconnectionReason]` is currently not properly handled and should give a siliar error message as a `DisconnectionReason` error. * De-clutter, custom read() was not needed Co-authored-by: jordan <jordan@curd.mjh-it.com>
2022-05-26 09:23:40 +00:00
"error": "RlpTypeMismatch",
Fix RLP deserialzation for Enum with holes (#554) RLP Enum deserialization would currently not check if "hole values" were attempted to be converted to the enum type. Now use checkedEnumAssign and fail with RlpTypeMismatch on invalid values. There is at least one occurance of an enum with holes in rlpx p2p: DisconnectionReason. For this enum the issue could occur. Also: - Added enum RLP tests and rlpx p2p disconnect message tests to test the DisconnectionReason with enum hole value. - Fixed worse custom DisconnectionReason decoding occurance in rlpx in waitSingleMsg proc where this issue could occur.
2022-11-14 14:49:37 +00:00
"description": "Disconnect reason code out of bounds 0..16 (got: 17)"
},
"DisconnectReason: single element list with enum hole value": {
"payload": "01c10C",
"error": "RlpTypeMismatch",
"description": "Error on Disconnect reason with enum hole value"
},
"DisconnectReason: single element with enum hole value": {
"payload": "010C",
"error": "RlpTypeMismatch",
"description": "Error on Disconnect reason with enum hole value"
Dedicated RLP reader for `DisconnectionReason` (#507) * Provide dedicated `DisconnectionReason` enum type RLP reader why: Without this reader, the program communicating via RLPX will crash when receiving out of bound reason codes disconnect message. Out of bound value assignments to an enum causes a `RangeError`defect and consequently the program to terminate. This `RangeError` is avoided here and a `MalformedRlpError` catchable error raised. * Using default exception type in bespoke `read(DisconnectionReason)` why: This should not differ from the default enum parser. The particular message is different and more targeted, here. Note: The default RLP parser was not used because ` `array[1,DisconnectionReason]` is currently not properly handled and should give a siliar error message as a `DisconnectionReason` error. * De-clutter, custom read() was not needed Co-authored-by: jordan <jordan@curd.mjh-it.com>
2022-05-26 09:23:40 +00:00
},
Add EIP-8 test + activate rlpx thunk test
2019-10-22 13:14:14 +00:00
"devp2p hello packet version 22 + additional list elements for EIP-8": {
"payload": "00f87137916b6e6574682f76302e39312f706c616e39cdc5836574683dc6846d6f726b1682270fb840fda1cff674c90c9a197539fe3dfb53086ace64f83ed7c6eabec741f7f381cc803e52ab2cd55d5569bce4347107a310dfd5f88a010cd2ffd1005ca406f1842877c883666f6f836261720304"
Add unittest for rlpx thunk payload tests
2019-10-22 12:08:25 +00:00
}
}