status-im/nim-eth-keys
2
0
Fork 0
mirror of https://github.com/status-im/nim-eth-keys.git synced 2025-02-20 04:58:25 +00:00
Code Issues Projects Releases Wiki Activity

Fix message size checks.

Browse Source
This commit is contained in:
cheatfate 2018-04-11 13:15:24 +03:00
parent bb1fa6346e
commit ddc80f8bff
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
eth_keys/libsecp256k1.nim
View File

@ -18,7 +18,6 @@ const
InvalidPublicKey = "Invalid public key!" InvalidPublicKey = "Invalid public key!"
InvalidSignature = "Invalid signature!" InvalidSignature = "Invalid signature!"
VerificationFailed = "Signature verification has been failed!" VerificationFailed = "Signature verification has been failed!"
EmptyMessageError = "Data/Message could not be empty!"
MessageSizeError = "Size of message to sign must be KeyLength bytes!" MessageSizeError = "Size of message to sign must be KeyLength bytes!"
type type
@ -266,8 +265,8 @@ proc recoverSignatureKey*(data: openarray[byte],
## recover public key to `pubkey` on success. ## recover public key to `pubkey` on success.
let ctx = getSecpContext() let ctx = getSecpContext()
let length = len(data) let length = len(data)
if len(msg) == 0 or length == 0: if len(msg) < KeyLength:
setErrorMsg(EmptyMessageError) setErrorMsg(MessageSizeError)
return(EthKeysStatus.Error) return(EthKeysStatus.Error)
if length < RawSignatureSize: if length < RawSignatureSize:
setErrorMsg(InvalidSignature) setErrorMsg(InvalidSignature)
@ -290,8 +289,8 @@ proc recoverSignatureKey*(signature: Signature,
## Perform check of `signature` using original message `msg` and ## Perform check of `signature` using original message `msg` and
## recover public key to `pubkey` on success. ## recover public key to `pubkey` on success.
let ctx = getSecpContext() let ctx = getSecpContext()
if len(msg) == 0: if len(msg) < KeyLength:
setErrorMsg(EmptyMessageError) setErrorMsg(MessageSizeError)
return(EthKeysStatus.Error) return(EthKeysStatus.Error)
if secp256k1_ecdsa_recover(ctx, addr pubkey, unsafeAddr signature, if secp256k1_ecdsa_recover(ctx, addr pubkey, unsafeAddr signature,
cast[ptr cuchar](msg)) != 1: cast[ptr cuchar](msg)) != 1: