From 3810889fcb16f58f7f232f5d06ebc3c259f9e04b Mon Sep 17 00:00:00 2001
From: Mark Spanbroek <mark@spanbroek.net>
Date: Thu, 31 Mar 2022 11:20:18 +0200
Subject: [PATCH] [sales] Do not call onSale() when someone else's offer is
 selected

---
 dagger/sales.nim           |  3 ++-
 tests/dagger/testsales.nim | 15 +++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/dagger/sales.nim b/dagger/sales.nim
index b06b7421..5051cbf4 100644
--- a/dagger/sales.nim
+++ b/dagger/sales.nim
@@ -70,7 +70,8 @@ proc handleRequest(sales: Sales, request: StorageRequest) {.async.} =
   proc onSelect(offerId: array[32, byte]) {.gcsafe, upraises:[].} =
     if subscription =? subscription:
       asyncSpawn subscription.unsubscribe()
-    sales.onSale(offer)
+    if offer.id == offerId:
+      sales.onSale(offer)
   subscription = some await sales.market.subscribeSelection(request.id, onSelect)
 
 proc start*(sales: Sales) =
diff --git a/tests/dagger/testsales.nim b/tests/dagger/testsales.nim
index a9530e2c..ef757b18 100644
--- a/tests/dagger/testsales.nim
+++ b/tests/dagger/testsales.nim
@@ -88,3 +88,18 @@ suite "Sales":
     await market.selectOffer(offer.id)
     check selectedOffer == offer
     sales.stop()
+
+  test "does not call onSale when a different offer is selected":
+    let availability = Availability.init(size=100, duration=60, minPrice=42.u256)
+    sales.add(availability)
+    var onSaleWasCalled: bool
+    sales.onSale = proc(offer: StorageOffer) =
+      onSaleWasCalled = true
+    sales.start()
+    var request = StorageRequest(duration:60.u256, size:100.u256, maxPrice:42.u256)
+    request = await market.requestStorage(request)
+    var otherOffer = StorageOffer(requestId: request.id, price: 1.u256)
+    otherOffer = await market.offerStorage(otherOffer)
+    await market.selectOffer(otherOffer.id)
+    check not onSaleWasCalled
+    sales.stop()