From 17d3f99f45bbbcadfb3d9c3de846ecd3f885f933 Mon Sep 17 00:00:00 2001 From: Dmitriy Ryajov Date: Thu, 6 Feb 2025 15:36:35 -0600 Subject: [PATCH] use a case-of instead of if for better readability (#1063) --- codex/blockexchange/engine/engine.nim | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/codex/blockexchange/engine/engine.nim b/codex/blockexchange/engine/engine.nim index e1624e99..87335b0a 100644 --- a/codex/blockexchange/engine/engine.nim +++ b/codex/blockexchange/engine/engine.nim @@ -398,7 +398,8 @@ proc wantListHandler*(b: BlockExcEngine, peer: PeerId, wantList: WantList) {.asy have = await e.address in b.localStore price = @(b.pricing.get(Pricing(price: 0.u256)).price.toBytesBE) - if e.wantType == WantType.WantHave: + case e.wantType: + of WantType.WantHave: if have: presence.add( BlockPresence( @@ -415,17 +416,19 @@ proc wantListHandler*(b: BlockExcEngine, peer: PeerId, wantList: WantList) {.asy peerCtx.peerWants.add(e) codex_block_exchange_want_have_lists_received.inc() - elif e.wantType == WantType.WantBlock: + of WantType.WantBlock: peerCtx.peerWants.add(e) schedulePeer = true codex_block_exchange_want_block_lists_received.inc() else: # Updating existing entry in peer wants # peer doesn't want this block anymore if e.cancel: + trace "Canceling want for block", address = e.address peerCtx.peerWants.del(idx) else: # peer might want to ask for the same cid with # different want params + trace "Updating want for block", address = e.address peerCtx.peerWants[idx] = e # update entry if presence.len > 0: