mirror of
https://github.com/status-im/nim-codex.git
synced 2025-01-09 18:36:29 +00:00
29433bad9a
* Use http subscriptions instead of websocket for tests To work around this issue when subscriptions are inactive for more than 5 minutes: https://github.com/NomicFoundation/hardhat/issues/2053 Use 100 millisecond polling; default polling interval of 4 seconds is too close to the 5 second timeout for `check eventually`. * use .confirm(1) instead of confirm(0) confirm(0) doesn't wait at all, confirm(1) waits for the transaction to be mined * speed up partial payout integration test * update nim-ethers to version 0.10.0 includes fixes for http polling and .confirm() * fix timing of marketplace tests allow for a bit more time to withdraw funds * use .confirm(1) in marketplace tests to ensure that the transaction has been processed before continuing with the test * fix timing issue in validation unit test * fix proof integration test there were two logic errors in this test: - a slot is freed anyway at the end of the contract - when starting the request takes a long time, the first slot can already be freed because there were too many missing proofs * fix intermittent error in contract tests currentTime() doesn't always correctly reflect the time of the next transaction * reduce number of slots in integration test otherwise the windows runner in the CI won't be able to start the request before it expires * fix timing in purchasing test allow for a bit more time for a request to be submitted * fix timing of request submission in test windows ci is so slow, it can take up to 40 seconds just to submit a storage request to hardhat * increase proof period to 90 seconds * adjust timing of integration tests reason: with the increased period length of 90 seconds, it can take longer to wait for a stable challenge at the beginning of a period. * increase CI timeout to 2 hours * Fix slow builds on windows apparently it takes windows 2-3 seconds to resolve "localhost" to 127.0.0.1 for every json-rpc connection that we make 🤦
152 lines
6.1 KiB
Nim
152 lines
6.1 KiB
Nim
import pkg/chronos
|
|
import std/strformat
|
|
import std/random
|
|
|
|
import codex/validation
|
|
import codex/periods
|
|
|
|
import ../asynctest
|
|
import ./helpers/mockmarket
|
|
import ./helpers/mockclock
|
|
import ./examples
|
|
import ./helpers
|
|
|
|
asyncchecksuite "validation":
|
|
let period = 10
|
|
let timeout = 5
|
|
let maxSlots = MaxSlots(100)
|
|
let validationGroups = ValidationGroups(8).some
|
|
let slot = Slot.example
|
|
let proof = Groth16Proof.example
|
|
let collateral = slot.request.ask.collateral
|
|
|
|
var validation: Validation
|
|
var market: MockMarket
|
|
var clock: MockClock
|
|
var groupIndex: uint16
|
|
|
|
proc initValidationConfig(maxSlots: MaxSlots,
|
|
validationGroups: ?ValidationGroups,
|
|
groupIndex: uint16 = 0): ValidationConfig =
|
|
without validationConfig =? ValidationConfig.init(
|
|
maxSlots, groups=validationGroups, groupIndex), error:
|
|
raiseAssert fmt"Creating ValidationConfig failed! Error msg: {error.msg}"
|
|
validationConfig
|
|
|
|
setup:
|
|
groupIndex = groupIndexForSlotId(slot.id, !validationGroups)
|
|
market = MockMarket.new()
|
|
clock = MockClock.new()
|
|
let validationConfig = initValidationConfig(
|
|
maxSlots, validationGroups, groupIndex)
|
|
validation = Validation.new(clock, market, validationConfig)
|
|
market.config.proofs.period = period.u256
|
|
market.config.proofs.timeout = timeout.u256
|
|
await validation.start()
|
|
|
|
teardown:
|
|
await validation.stop()
|
|
|
|
proc advanceToNextPeriod =
|
|
let periodicity = Periodicity(seconds: period.u256)
|
|
let period = periodicity.periodOf(clock.now().u256)
|
|
let periodEnd = periodicity.periodEnd(period)
|
|
clock.set((periodEnd + 1).truncate(int))
|
|
|
|
test "the list of slots that it's monitoring is empty initially":
|
|
check validation.slots.len == 0
|
|
|
|
for (validationGroups, groupIndex) in [(100, 100'u16), (100, 101'u16)]:
|
|
test "initializing ValidationConfig fails when groupIndex is " &
|
|
"greater than or equal to validationGroups " &
|
|
fmt"(testing for {groupIndex = }, {validationGroups = })":
|
|
let groups = ValidationGroups(validationGroups).some
|
|
let validationConfig = ValidationConfig.init(
|
|
maxSlots, groups = groups, groupIndex = groupIndex)
|
|
check validationConfig.isFailure == true
|
|
check validationConfig.error.msg == "The value of the group index " &
|
|
"must be less than validation groups! " &
|
|
fmt"(got: {groupIndex = }, groups = {!groups})"
|
|
|
|
test "initializing ValidationConfig fails when maxSlots is negative":
|
|
let maxSlots = -1
|
|
let validationConfig = ValidationConfig.init(
|
|
maxSlots = maxSlots, groups = ValidationGroups.none)
|
|
check validationConfig.isFailure == true
|
|
check validationConfig.error.msg == "The value of maxSlots must " &
|
|
fmt"be greater than or equal to 0! (got: {maxSlots})"
|
|
|
|
test "initializing ValidationConfig fails when maxSlots is negative " &
|
|
"(validationGroups set)":
|
|
let maxSlots = -1
|
|
let validationConfig = ValidationConfig.init(
|
|
maxSlots = maxSlots, groups = validationGroups, groupIndex)
|
|
check validationConfig.isFailure == true
|
|
check validationConfig.error.msg == "The value of maxSlots must " &
|
|
fmt"be greater than or equal to 0! (got: {maxSlots})"
|
|
|
|
test "slot is not observed if it is not in the validation group":
|
|
let validationConfig = initValidationConfig(maxSlots, validationGroups,
|
|
(groupIndex + 1) mod uint16(!validationGroups))
|
|
let validation = Validation.new(clock, market, validationConfig)
|
|
await validation.start()
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
await validation.stop()
|
|
check validation.slots.len == 0
|
|
|
|
test "when a slot is filled on chain, it is added to the list":
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
check validation.slots == @[slot.id]
|
|
|
|
test "slot should be observed if maxSlots is set to 0":
|
|
let validationConfig = initValidationConfig(
|
|
maxSlots = 0, ValidationGroups.none)
|
|
let validation = Validation.new(clock, market, validationConfig)
|
|
await validation.start()
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
await validation.stop()
|
|
check validation.slots == @[slot.id]
|
|
|
|
test "slot should be observed if validation group is not set (and " &
|
|
"maxSlots is not 0)":
|
|
let validationConfig = initValidationConfig(
|
|
maxSlots, ValidationGroups.none)
|
|
let validation = Validation.new(clock, market, validationConfig)
|
|
await validation.start()
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
await validation.stop()
|
|
check validation.slots == @[slot.id]
|
|
|
|
for state in [SlotState.Finished, SlotState.Failed]:
|
|
test fmt"when slot state changes to {state}, it is removed from the list":
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
market.slotState[slot.id] = state
|
|
advanceToNextPeriod()
|
|
check eventually validation.slots.len == 0
|
|
|
|
test "when a proof is missed, it is marked as missing":
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
market.setCanProofBeMarkedAsMissing(slot.id, true)
|
|
advanceToNextPeriod()
|
|
await sleepAsync(100.millis) # allow validation loop to run
|
|
check market.markedAsMissingProofs.contains(slot.id)
|
|
|
|
test "when a proof can not be marked as missing, it will not be marked":
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
market.setCanProofBeMarkedAsMissing(slot.id, false)
|
|
advanceToNextPeriod()
|
|
await sleepAsync(100.millis) # allow validation loop to run
|
|
check market.markedAsMissingProofs.len == 0
|
|
|
|
test "it does not monitor more than the maximum number of slots":
|
|
let validationGroups = ValidationGroups.none
|
|
let validationConfig = initValidationConfig(
|
|
maxSlots, validationGroups)
|
|
let validation = Validation.new(clock, market, validationConfig)
|
|
await validation.start()
|
|
for _ in 0..<maxSlots + 1:
|
|
let slot = Slot.example
|
|
await market.fillSlot(slot.request.id, slot.slotIndex, proof, collateral)
|
|
await validation.stop()
|
|
check validation.slots.len == maxSlots
|