From e1bb35c86db842c29c3a81889052a47ab8d6d95a Mon Sep 17 00:00:00 2001 From: Eric <5089238+emizzle@users.noreply.github.com> Date: Thu, 6 Feb 2025 18:07:33 +1100 Subject: [PATCH] clean up --- .github/workflows/ci-reusable.yml | 2 +- tests/integration/testmanager.nim | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-reusable.yml b/.github/workflows/ci-reusable.yml index dcb32107..89fd1703 100644 --- a/.github/workflows/ci-reusable.yml +++ b/.github/workflows/ci-reusable.yml @@ -77,7 +77,7 @@ jobs: ## Part 3 Tests ## - name: Integration tests if: matrix.tests == 'integration' || matrix.tests == 'all' - run: make -j${ncpu} ENABLE_PARALLEL_TESTS=0 testIntegration + run: make -j${ncpu} PARALLEL=0 testIntegration - name: Parallel integration tests if: matrix.tests == 'integration-parallel' diff --git a/tests/integration/testmanager.nim b/tests/integration/testmanager.nim index 928445e6..0a75dafb 100644 --- a/tests/integration/testmanager.nim +++ b/tests/integration/testmanager.nim @@ -320,11 +320,12 @@ proc buildCommand( raiseTestManagerError "bad file name, testFile: " & test.config.testFile, parent withLock(test.manager.codexPortLock): - # Increase the port by 100 to allow each test to run 100 codex nodes + # Increase the port by 1000 to allow each test to run 1000 codex nodes # (clients, SPs, validators) giving a good chance the port will be free. We # cannot rely on `nextFreePort` in multinodes entirely as there could be a # concurrency issue where the port is determined free in mulitiple tests and - # then there is a clash during the run. + # then there is a clash during the run. Windows, in particular, does not + # like giving up ports. let apiPort = await nextFreePort(test.manager.lastCodexApiPort + 1000) test.manager.lastCodexApiPort = apiPort let discPort = await nextFreePort(test.manager.lastCodexDiscPort + 1000)