From 4d00814f9e6d0d0be2e0aa8844952934db4e18ce Mon Sep 17 00:00:00 2001
From: Mark Spanbroek <mark@spanbroek.net>
Date: Tue, 10 May 2022 13:50:22 +0200
Subject: [PATCH] [erasure] Handle edge case of 0 parity blocks

---
 dagger/erasure/backends/leopard.nim |  3 +++
 tests/dagger/testerasure.nim        | 41 +++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)

diff --git a/dagger/erasure/backends/leopard.nim b/dagger/erasure/backends/leopard.nim
index 302af0e9..afeb13e7 100644
--- a/dagger/erasure/backends/leopard.nim
+++ b/dagger/erasure/backends/leopard.nim
@@ -26,6 +26,9 @@ method encode*(
   data,
   parity: var openArray[seq[byte]]): Result[void, cstring] =
 
+  if parity.len == 0:
+    return ok()
+
   var encoder = if self.encoder.isNone:
       self.encoder = (? LeoEncoder.init(
         self.blockSize,
diff --git a/tests/dagger/testerasure.nim b/tests/dagger/testerasure.nim
index d1b1808f..181806dd 100644
--- a/tests/dagger/testerasure.nim
+++ b/tests/dagger/testerasure.nim
@@ -310,3 +310,44 @@ suite "Erasure encode/decode":
 
     for d in manifest:
       check d in store
+
+  test "handles edge case of 0 parity blocks":
+    const
+      buffers = 20
+      parity = 0
+      dataSetSize = BlockSize * 123 # weird geometry
+
+    var
+      chunker = RandomChunker.new(Rng.instance(), size = dataSetSize, chunkSize = BlockSize)
+      manifest = Manifest.new(blockSize = BlockSize).tryGet()
+      store = CacheStore.new(cacheSize = (dataSetSize * 5), chunkSize = BlockSize)
+      erasure = Erasure.new(store, leoEncoderProvider, leoDecoderProvider)
+      rng = Rng.instance
+
+    while (
+      let chunk = await chunker.getBytes();
+      chunk.len > 0):
+
+      let blk = Block.new(chunk).tryGet()
+      manifest.add(blk.cid)
+      check (await store.putBlock(blk))
+
+    let
+      encoded = (await erasure.encode(
+        manifest,
+        buffers,
+        parity)).tryGet()
+
+    check:
+      encoded.len mod (buffers + parity) == 0
+      encoded.rounded == (manifest.len + (buffers - (manifest.len mod buffers)))
+      encoded.steps == encoded.rounded div buffers
+
+    for b in encoded.blocks[^(encoded.steps * encoded.M)..^1]:
+      check (await store.delBlock(b))
+
+    var
+      decoded = (await erasure.decode(encoded)).tryGet()
+
+    for d in manifest:
+      check d in store