status-im/nim-chronos
2
0
Fork 0
mirror of https://github.com/status-im/nim-chronos.git synced 2025-02-12 11:16:52 +00:00
Code Issues Projects Releases Wiki Activity

Add raises annotation to withTimeout callbacks (#168)

Browse Source
This commit is contained in:
Kim De Mey 2021-03-25 14:20:26 +01:00 committed by GitHub
parent 4abd7a5645
commit c206d2bc19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
chronos/asyncloop.nim
View File

@ -951,7 +951,9 @@ proc withTimeout*[T](fut: Future[T], timeout: Duration): Future[bool] =
var timer: TimerCallback var timer: TimerCallback
var cancelling = false var cancelling = false
proc continuation(udata: pointer) {.gcsafe.} = # TODO: raises annotation shouldn't be needed, but likely similar issue as
# https://github.com/nim-lang/Nim/issues/17369
proc continuation(udata: pointer) {.gcsafe, raises: [Defect].} =
if not(retFuture.finished()): if not(retFuture.finished()):
if not(cancelling): if not(cancelling):
if not(fut.finished()): if not(fut.finished()):
@ -967,7 +969,9 @@ proc withTimeout*[T](fut: Future[T], timeout: Duration): Future[bool] =
else: else:
retFuture.complete(false) retFuture.complete(false)
proc cancellation(udata: pointer) {.gcsafe.} = # TODO: raises annotation shouldn't be needed, but likely similar issue as
# https://github.com/nim-lang/Nim/issues/17369
proc cancellation(udata: pointer) {.gcsafe, raises: [Defect].} =
if not isNil(timer): if not isNil(timer):
clearTimer(timer) clearTimer(timer)
if not(fut.finished()): if not(fut.finished()):