status-im
/
nim-chronos
mirror of https://github.com/status-im/nim-chronos.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

print warning when calling failed (#521) 

`failed` cannot return true for futures that don't forward exceptions
This commit is contained in:
Jacek Sieka 2024-03-08 14:43:42 +01:00 committed by GitHub
parent 17b7a76c7e
commit 47cc17719f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
chronos/internal/raisesfutures.nim
View File

@ -2,6 +2,8 @@ import
std/[macros, sequtils], std/[macros, sequtils],
../futures ../futures
{.push raises: [].}
type type
InternalRaisesFuture*[T, E] = ref object of Future[T] InternalRaisesFuture*[T, E] = ref object of Future[T]
## Future with a tuple of possible exception types ## Future with a tuple of possible exception types
@ -205,13 +207,20 @@ macro checkRaises*[T: CatchableError](
`warning` `warning`
assert(`runtimeChecker`, `errorMsg`) assert(`runtimeChecker`, `errorMsg`)
proc error*[T](future: InternalRaisesFuture[T, void]): ref CatchableError {. func failed*[T](future: InternalRaisesFuture[T, void]): bool {.inline.} =
## Determines whether ``future`` finished with an error.
static:
warning("No exceptions possible with this operation, `failed` always returns false")
false
func error*[T](future: InternalRaisesFuture[T, void]): ref CatchableError {.
raises: [].} = raises: [].} =
static: static:
warning("No exceptions possible with this operation, `error` always returns nil") warning("No exceptions possible with this operation, `error` always returns nil")
nil nil
proc readError*[T](future: InternalRaisesFuture[T, void]): ref CatchableError {. func readError*[T](future: InternalRaisesFuture[T, void]): ref CatchableError {.
raises: [ValueError].} = raises: [ValueError].} =
static: static:
warning("No exceptions possible with this operation, `readError` always raises") warning("No exceptions possible with this operation, `readError` always raises")