6d0d39b2ca
bind_test.go compares the generated Go files against golden files checked in the repository. The bind package formats some of the generated Go files, so any changes in the go formatter can break the tests. This change makes the test more robust by applying formatting based on the currently used go version. Since a golden file often includes multiple go files generated by the bind, the `gofmt` function splits the golden file using the gobindPreamble marker and then run format.Source for each chunk. In order to ease the golden file splitting, this CL also moves the gobindPreamble to the beginning of each generated file consistently. It turned out bind omits formatting for some go files (generated for reverse binding). That needs to be fixed but it is a much bigger fix. Thus, in this CL, we apply the formatting on the bind's output as well. This CL also updates the gobindPreamble to follow the style guide for generated code. https://golang.org/s/generatedcode Fixes golang/go#34619 Change-Id: Ia2957693154face2848e051ebbb2373e95d79593 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/198322 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
60 lines
1.3 KiB
Go
60 lines
1.3 KiB
Go
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Package bind implements a code generator for gobind.
|
|
//
|
|
// See the documentation on the gobind command for usage details
|
|
// and the list of currently supported types.
|
|
// (http://godoc.org/golang.org/x/mobile/cmd/gobind)
|
|
package bind // import "golang.org/x/mobile/bind"
|
|
|
|
// TODO(crawshaw): slice support
|
|
// TODO(crawshaw): channel support
|
|
|
|
import (
|
|
"bytes"
|
|
"go/format"
|
|
"go/token"
|
|
"go/types"
|
|
"io"
|
|
)
|
|
|
|
const gobindPreamble = "// Code generated by gobind. DO NOT EDIT.\n\n"
|
|
|
|
type (
|
|
GeneratorConfig struct {
|
|
Writer io.Writer
|
|
Fset *token.FileSet
|
|
Pkg *types.Package
|
|
AllPkg []*types.Package
|
|
}
|
|
|
|
fileType int
|
|
)
|
|
|
|
// GenGo generates a Go stub to support foreign language APIs.
|
|
func GenGo(conf *GeneratorConfig) error {
|
|
buf := new(bytes.Buffer)
|
|
g := &goGen{
|
|
Generator: &Generator{
|
|
Printer: &Printer{Buf: buf, IndentEach: []byte("\t")},
|
|
Fset: conf.Fset,
|
|
AllPkg: conf.AllPkg,
|
|
Pkg: conf.Pkg,
|
|
},
|
|
}
|
|
g.Init()
|
|
if err := g.gen(); err != nil {
|
|
return err
|
|
}
|
|
src := buf.Bytes()
|
|
srcf, err := format.Source(src)
|
|
if err != nil {
|
|
conf.Writer.Write(src) // for debugging
|
|
return err
|
|
}
|
|
_, err = conf.Writer.Write(srcf)
|
|
return err
|
|
}
|