ba0a725146
Converting a Go string to a string suitable use a specialized function, UTF16Encode, that can encode the string directly to a malloc'ed buffer. That way, only two copies are made when strings are passed from Go to Java; once for UTF-8 to UTF-16 encoding and once for the creation of the Java String. This CL implements the same optimization in the other direction, with a UTF-16 to UTF-8 decoder implemented in C. Unfortunately, while calling into a Go decoder also saves the extra copy, the Cgo overhead makes the calls much slower for short strings. To alleviate the risk of introducing decoding bugs, I've added the tests from the encoding/utf16 package to SeqTest. As a sideeffect, both Java and ObjC now always copy strings, regardless of the argument mode. The cpy argument can therefore be removed from the string conversion functions. Furthermore, the modeRetained and modeReturned modes can be collapsed into just one. While we're here, delete a leftover function from seq/strings.go that wasn't removed when the old seq buffers went away. Benchmarks, as compared with benchstat over 5 runs: name old time/op new time/op delta JavaStringShort 11.4µs ±13% 11.6µs ± 4% ~ (p=0.859 n=10+5) JavaStringShortDirect 19.5µs ± 9% 20.3µs ± 2% +3.68% (p=0.019 n=9+5) JavaStringLong 103µs ± 8% 24µs ± 4% -77.13% (p=0.001 n=9+5) JavaStringLongDirect 113µs ± 9% 32µs ± 7% -71.63% (p=0.001 n=9+5) JavaStringShortUnicode 11.1µs ±16% 10.7µs ± 5% ~ (p=0.190 n=9+5) JavaStringShortUnicodeDirect 19.6µs ± 7% 20.2µs ± 1% +2.78% (p=0.029 n=9+5) JavaStringLongUnicode 97.1µs ± 9% 28.0µs ± 5% -71.17% (p=0.001 n=9+5) JavaStringLongUnicodeDirect 105µs ±10% 34µs ± 5% -67.23% (p=0.002 n=8+5) JavaStringRetShort 14.2µs ± 2% 13.9µs ± 1% -2.15% (p=0.006 n=8+5) JavaStringRetShortDirect 20.8µs ± 2% 20.4µs ± 2% ~ (p=0.065 n=8+5) JavaStringRetLong 42.2µs ± 9% 42.4µs ± 3% ~ (p=0.190 n=9+5) JavaStringRetLongDirect 51.2µs ±21% 50.8µs ± 8% ~ (p=0.518 n=9+5) GoStringShort 23.4µs ± 7% 22.5µs ± 3% -3.55% (p=0.019 n=9+5) GoStringLong 51.9µs ± 9% 53.1µs ± 3% ~ (p=0.240 n=9+5) GoStringShortUnicode 24.2µs ± 6% 22.8µs ± 1% -5.54% (p=0.002 n=9+5) GoStringLongUnicode 58.6µs ± 8% 57.6µs ± 3% ~ (p=0.518 n=9+5) GoStringRetShort 27.6µs ± 1% 23.2µs ± 2% -15.87% (p=0.003 n=7+5) GoStringRetLong 129µs ±12% 33µs ± 2% -74.03% (p=0.001 n=10+5) Change-Id: Icb9481981493ffca8defed9fb80a9433d6048937 Reviewed-on: https://go-review.googlesource.com/20250 Reviewed-by: David Crawshaw <crawshaw@golang.org>
138 lines
3.1 KiB
Plaintext
138 lines
3.1 KiB
Plaintext
// Package gomobile_bind is an autogenerated binder stub for package structs.
|
|
// gobind -lang=go structs
|
|
//
|
|
// File is generated by gobind. Do not edit.
|
|
package gomobile_bind
|
|
|
|
/*
|
|
#include <stdlib.h>
|
|
#include <stdint.h>
|
|
#include "seq.h"
|
|
#include "structs.h"
|
|
|
|
*/
|
|
import "C"
|
|
|
|
import (
|
|
_seq "golang.org/x/mobile/bind/seq"
|
|
"structs"
|
|
)
|
|
|
|
// suppress the error if seq ends up unused
|
|
var _ = _seq.FromRefNum
|
|
|
|
type proxyS _seq.Ref
|
|
|
|
//export proxystructs_S_X_Set
|
|
func proxystructs_S_X_Set(refnum C.int32_t, v C.double) {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
_v := float64(v)
|
|
ref.Get().(*structs.S).X = _v
|
|
}
|
|
|
|
//export proxystructs_S_X_Get
|
|
func proxystructs_S_X_Get(refnum C.int32_t) C.double {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
v := ref.Get().(*structs.S).X
|
|
_v := C.double(v)
|
|
return _v
|
|
}
|
|
|
|
//export proxystructs_S_Y_Set
|
|
func proxystructs_S_Y_Set(refnum C.int32_t, v C.double) {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
_v := float64(v)
|
|
ref.Get().(*structs.S).Y = _v
|
|
}
|
|
|
|
//export proxystructs_S_Y_Get
|
|
func proxystructs_S_Y_Get(refnum C.int32_t) C.double {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
v := ref.Get().(*structs.S).Y
|
|
_v := C.double(v)
|
|
return _v
|
|
}
|
|
|
|
//export proxystructs_S_Identity
|
|
func proxystructs_S_Identity(refnum C.int32_t) (C.int32_t, C.nstring) {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
v := ref.Get().(*structs.S)
|
|
res_0, res_1 := v.Identity()
|
|
var _res_0 C.int32_t = _seq.NullRefNum
|
|
if res_0 != nil {
|
|
_res_0 = C.int32_t(_seq.ToRefNum(res_0))
|
|
}
|
|
var _res_1_str string
|
|
if res_1 == nil {
|
|
_res_1_str = ""
|
|
} else {
|
|
_res_1_str = res_1.Error()
|
|
}
|
|
_res_1 := encodeString(_res_1_str)
|
|
return _res_0, _res_1
|
|
}
|
|
|
|
//export proxystructs_S_Sum
|
|
func proxystructs_S_Sum(refnum C.int32_t) C.double {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
v := ref.Get().(*structs.S)
|
|
res_0 := v.Sum()
|
|
_res_0 := C.double(res_0)
|
|
return _res_0
|
|
}
|
|
|
|
type proxyS2 _seq.Ref
|
|
|
|
//export proxystructs_S2_M
|
|
func proxystructs_S2_M(refnum C.int32_t) {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
v := ref.Get().(*structs.S2)
|
|
v.M()
|
|
}
|
|
|
|
//export proxystructs_I_M
|
|
func proxystructs_I_M(refnum C.int32_t) {
|
|
ref := _seq.FromRefNum(int32(refnum))
|
|
v := ref.Get().(structs.I)
|
|
v.M()
|
|
}
|
|
|
|
type proxystructs_I _seq.Ref
|
|
|
|
func (p *proxystructs_I) M() {
|
|
C.cproxystructs_I_M(C.int32_t(p.Num))
|
|
}
|
|
|
|
//export proxystructs__Identity
|
|
func proxystructs__Identity(param_s C.int32_t) C.int32_t {
|
|
// Must be a Go object
|
|
_param_s_ref := _seq.FromRefNum(int32(param_s))
|
|
_param_s := _param_s_ref.Get().(*structs.S)
|
|
res_0 := structs.Identity(_param_s)
|
|
var _res_0 C.int32_t = _seq.NullRefNum
|
|
if res_0 != nil {
|
|
_res_0 = C.int32_t(_seq.ToRefNum(res_0))
|
|
}
|
|
return _res_0
|
|
}
|
|
|
|
//export proxystructs__IdentityWithError
|
|
func proxystructs__IdentityWithError(param_s C.int32_t) (C.int32_t, C.nstring) {
|
|
// Must be a Go object
|
|
_param_s_ref := _seq.FromRefNum(int32(param_s))
|
|
_param_s := _param_s_ref.Get().(*structs.S)
|
|
res_0, res_1 := structs.IdentityWithError(_param_s)
|
|
var _res_0 C.int32_t = _seq.NullRefNum
|
|
if res_0 != nil {
|
|
_res_0 = C.int32_t(_seq.ToRefNum(res_0))
|
|
}
|
|
var _res_1_str string
|
|
if res_1 == nil {
|
|
_res_1_str = ""
|
|
} else {
|
|
_res_1_str = res_1.Error()
|
|
}
|
|
_res_1 := encodeString(_res_1_str)
|
|
return _res_0, _res_1
|
|
}
|