89b8360218
CL 24800 changed the error representation from strings to objects.
However, since native errors types are not immediately compatible
across languages, wrapper types were introduced to bridge the gap.
This CL remove those wrappers and instead special case the error
proxy types to conform to their language error protocol.
Specifically:
- The ObjC proxy for Go errors now extends NSError and calls
initWithDomain to store the error message.
- The Go proxy for ObjC NSError return the localizedDescription
property for calls to Error.
- The Java proxy for Go errors ow extends Exception and
overrides getMessage() to return the error message.
- The Go proxy for Java Exceptions returns getMessage whenever
Error is called.
The end result is that error values behave more like normal objects
across the language boundary. In particular, instance identity is
now preserved: an error passed across the boundary and back will
result in the same instance.
There are two semantic changes that followed this change:
- The domain for wrapped Go errors is now always "go".
The domain wasn't useful before this CL: the domains were set to
the package name of function or method where the error happened
to cross the language boundary.
- If a Go method that returns an error is implemented in ObjC, the
implementation must now both return NO _and_ set the error result
for the calling Go code to receive a non-nil error.
Before this CL, because errors were always wrapped, a nil ObjC
could be represented with a non-nil wrapper.
Change-Id: Idb415b6b13ecf79ccceb60f675059942bfc48fec
Reviewed-on: https://go-review.googlesource.com/29298
Reviewed-by: David Crawshaw <crawshaw@golang.org>
106 lines
2.8 KiB
Plaintext
106 lines
2.8 KiB
Plaintext
// Java class go.issue10788.TestStruct is a proxy for talking to a Go program.
|
|
// gobind -lang=java issue10788
|
|
//
|
|
// File is generated by gobind. Do not edit.
|
|
package go.issue10788;
|
|
|
|
import go.Seq;
|
|
|
|
public final class TestStruct implements Seq.Proxy {
|
|
static { Issue10788.touch(); }
|
|
|
|
private final Seq.Ref ref;
|
|
|
|
@Override public final int incRefnum() {
|
|
int refnum = ref.refnum;
|
|
Seq.incGoRef(refnum);
|
|
return refnum;
|
|
}
|
|
|
|
TestStruct(Seq.Ref ref) { this.ref = ref; }
|
|
|
|
public final native String getValue();
|
|
public final native void setValue(String v);
|
|
|
|
@Override public boolean equals(Object o) {
|
|
if (o == null || !(o instanceof TestStruct)) {
|
|
return false;
|
|
}
|
|
TestStruct that = (TestStruct)o;
|
|
String thisValue = getValue();
|
|
String thatValue = that.getValue();
|
|
if (thisValue == null) {
|
|
if (thatValue != null) {
|
|
return false;
|
|
}
|
|
} else if (!thisValue.equals(thatValue)) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
@Override public int hashCode() {
|
|
return java.util.Arrays.hashCode(new Object[] {getValue()});
|
|
}
|
|
|
|
@Override public String toString() {
|
|
StringBuilder b = new StringBuilder();
|
|
b.append("TestStruct").append("{");
|
|
b.append("Value:").append(getValue()).append(",");
|
|
return b.append("}").toString();
|
|
}
|
|
}
|
|
|
|
// Java class go.issue10788.TestInterface is a proxy for talking to a Go program.
|
|
// gobind -lang=java issue10788
|
|
//
|
|
// File is generated by gobind. Do not edit.
|
|
package go.issue10788;
|
|
|
|
import go.Seq;
|
|
|
|
public interface TestInterface {
|
|
public void doSomeWork(TestStruct s);
|
|
public void multipleUnnamedParams(long p0, String p1, long p2);
|
|
|
|
}
|
|
|
|
// Java class go.issue10788.Issue10788 is a proxy for talking to a Go program.
|
|
// gobind -lang=java issue10788
|
|
//
|
|
// File is generated by gobind. Do not edit.
|
|
package go.issue10788;
|
|
|
|
import go.Seq;
|
|
|
|
public abstract class Issue10788 {
|
|
static {
|
|
Seq.touch(); // for loading the native library
|
|
_init();
|
|
}
|
|
|
|
private Issue10788() {} // uninstantiable
|
|
|
|
// touch is called from other bound packages to initialize this package
|
|
public static void touch() {}
|
|
|
|
private static native void _init();
|
|
|
|
private static final class proxyTestInterface implements Seq.Proxy, TestInterface {
|
|
private final Seq.Ref ref;
|
|
|
|
@Override public final int incRefnum() {
|
|
int refnum = ref.refnum;
|
|
Seq.incGoRef(refnum);
|
|
return refnum;
|
|
}
|
|
|
|
proxyTestInterface(Seq.Ref ref) { this.ref = ref; }
|
|
|
|
public native void doSomeWork(TestStruct s);
|
|
public native void multipleUnnamedParams(long p0, String p1, long p2);
|
|
}
|
|
|
|
|
|
}
|