The seq serialization machinery is a historic artifact from when Go mobile code had to run in a separate process. Now that Go code is running in-process, replace the explicit serialization with direct calls and pass arguments on the stack. The benefits are a much smaller bind runtime, much less garbage (and, in Java, fewer objects with finalizers), less argument copying, and faster cross-language calls. The cost is a more complex generator, because some of the work from the bind runtime is moved to generated code. Generated code now handles conversion between Go and Java/ObjC types, multiple return values and memory management of byte slice and string arguments. To overcome the lack of calling C code between Go packages, all bound packages now end up in the same (fake) package, "gomobile_bind", instead of separate packages (go_<pkgname>). To avoid name clashes, the package name is added as a prefix to generated functions and types. Also, don't copy byte arrays passed to Go, saving call time and allowing read([]byte)-style interfaces to foreign callers (#12113). Finally, add support for nil interfaces and struct pointers to objc. This is a large CL, but most of the changes stem from changing testdata. The full benchcmp output on the CL/20095 benchmarks on my Nexus 5 is reproduced below. Note that the savings for the JavaSlice* benchmarks are skewed because byte slices are no longer copied before passing them to Go. benchmark old ns/op new ns/op delta BenchmarkJavaEmpty 26.0 19.0 -26.92% BenchmarkJavaEmptyDirect 23.0 22.0 -4.35% BenchmarkJavaNoargs 7685 2339 -69.56% BenchmarkJavaNoargsDirect 17405 8041 -53.80% BenchmarkJavaOnearg 26887 2366 -91.20% BenchmarkJavaOneargDirect 34266 7910 -76.92% BenchmarkJavaOneret 38325 2245 -94.14% BenchmarkJavaOneretDirect 46265 7708 -83.34% BenchmarkJavaManyargs 41720 2535 -93.92% BenchmarkJavaManyargsDirect 51026 8373 -83.59% BenchmarkJavaRefjava 38139 21260 -44.26% BenchmarkJavaRefjavaDirect 42706 28150 -34.08% BenchmarkJavaRefgo 34403 6843 -80.11% BenchmarkJavaRefgoDirect 40193 16582 -58.74% BenchmarkJavaStringShort 32366 9323 -71.20% BenchmarkJavaStringShortDirect 41973 19118 -54.45% BenchmarkJavaStringLong 127879 94420 -26.16% BenchmarkJavaStringLongDirect 133776 114760 -14.21% BenchmarkJavaStringShortUnicode 32562 9221 -71.68% BenchmarkJavaStringShortUnicodeDirect 41464 19094 -53.95% BenchmarkJavaStringLongUnicode 131015 89401 -31.76% BenchmarkJavaStringLongUnicodeDirect 134130 90786 -32.31% BenchmarkJavaSliceShort 42462 7538 -82.25% BenchmarkJavaSliceShortDirect 52940 17017 -67.86% BenchmarkJavaSliceLong 138391 8466 -93.88% BenchmarkJavaSliceLongDirect 205804 15666 -92.39% BenchmarkGoEmpty 3.00 3.00 +0.00% BenchmarkGoEmptyDirect 3.00 3.00 +0.00% BenchmarkGoNoarg 40342 13716 -66.00% BenchmarkGoNoargDirect 46691 13569 -70.94% BenchmarkGoOnearg 43529 13757 -68.40% BenchmarkGoOneargDirect 44867 14078 -68.62% BenchmarkGoOneret 45456 13559 -70.17% BenchmarkGoOneretDirect 44694 13442 -69.92% BenchmarkGoRefjava 55111 28071 -49.06% BenchmarkGoRefjavaDirect 60883 26872 -55.86% BenchmarkGoRefgo 57038 29223 -48.77% BenchmarkGoRefgoDirect 56153 27812 -50.47% BenchmarkGoManyargs 67967 17398 -74.40% BenchmarkGoManyargsDirect 60617 16998 -71.96% BenchmarkGoStringShort 57538 22600 -60.72% BenchmarkGoStringShortDirect 52627 22704 -56.86% BenchmarkGoStringLong 128485 52530 -59.12% BenchmarkGoStringLongDirect 138377 52079 -62.36% BenchmarkGoStringShortUnicode 57062 22994 -59.70% BenchmarkGoStringShortUnicodeDirect 62563 22938 -63.34% BenchmarkGoStringLongUnicode 139913 55553 -60.29% BenchmarkGoStringLongUnicodeDirect 150863 57791 -61.69% BenchmarkGoSliceShort 59279 20215 -65.90% BenchmarkGoSliceShortDirect 60160 21136 -64.87% BenchmarkGoSliceLong 411225 301870 -26.59% BenchmarkGoSliceLongDirect 399029 298915 -25.09% Fixes golang/go#12619 Fixes golang/go#12113 Fixes golang/go#13033 Change-Id: I2b45e9e98a1248e3c23a5137f775f7364908bec7 Reviewed-on: https://go-review.googlesource.com/19821 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
341 lines
8.8 KiB
Plaintext
341 lines
8.8 KiB
Plaintext
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
#include <stdio.h>
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
#include <Foundation/Foundation.h>
|
|
#include "seq.h"
|
|
#include "_cgo_export.h"
|
|
|
|
// * Objective-C implementation of a Go interface type
|
|
//
|
|
// For an interface testpkg.I, gobind defines a protocol GoSeqTestpkgI.
|
|
// Reference tracker (tracker) maintains two maps:
|
|
// 1) _refs: objective-C object pointer -> a refnum (starting from 42).
|
|
// 2) _objs: refnum -> RefCounter.
|
|
//
|
|
// Whenever a user's object conforming the protocol is sent to Go (through
|
|
// a function or method that takes I), _refs is consulted to find the refnum
|
|
// of the object. If not found, the refnum is assigned and stored.
|
|
//
|
|
// _objs is also updated so that the RefCounter is incremented and the
|
|
// user's object is pinned.
|
|
//
|
|
// When a Go side needs to call a method of the interface, the Go side
|
|
// notifies the Objective-C side of the object's refnum. Upon receiving the
|
|
// request, Objective-C side looks up the object from _objs map, and sends
|
|
// the method to the object.
|
|
//
|
|
// The RefCount counts the references on objective-C objects from Go side,
|
|
// and pins the objective-C objects until there is no more references from
|
|
// Go side.
|
|
//
|
|
// * Objective-C proxy of a Go object (struct or interface type)
|
|
//
|
|
// For Go type object, a objective-C proxy instance is created whenever
|
|
// the object reference is passed into objective-C.
|
|
|
|
// Note that this file is copied into and compiled with the generated
|
|
// bindings.
|
|
|
|
// A simple thread-safe mutable dictionary.
|
|
@interface goSeqDictionary : NSObject {
|
|
}
|
|
@property NSMutableDictionary *dict;
|
|
@end
|
|
|
|
@implementation goSeqDictionary
|
|
|
|
- (id)init {
|
|
if (self = [super init]) {
|
|
_dict = [[NSMutableDictionary alloc] init];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (id)get:(id)key {
|
|
@synchronized(self) {
|
|
return [_dict objectForKey:key];
|
|
}
|
|
}
|
|
|
|
- (void)put:(id)obj withKey:(id)key {
|
|
@synchronized(self) {
|
|
[_dict setObject:obj forKey:key];
|
|
}
|
|
}
|
|
@end
|
|
|
|
// NULL_REFNUM is also known to bind/seq/ref.go and bind/java/Seq.java
|
|
#define NULL_REFNUM 41
|
|
|
|
// RefTracker encapsulates a map of objective-C objects passed to Go and
|
|
// the reference number counter which is incremented whenever an objective-C
|
|
// object that implements a Go interface is created.
|
|
@interface RefTracker : NSObject {
|
|
int32_t _next;
|
|
NSMutableDictionary *_refs; // map: object ptr -> refnum
|
|
NSMutableDictionary *_objs; // map: refnum -> RefCounter*
|
|
}
|
|
|
|
- (id)init;
|
|
|
|
// decrements the counter of the objective-C object with the reference number.
|
|
// This is called whenever a Go proxy to this object is finalized.
|
|
// When the counter reaches 0, the object is removed from the map.
|
|
- (void)dec:(int32_t)refnum;
|
|
|
|
// returns the object of the reference number.
|
|
- (id)get:(int32_t)refnum;
|
|
|
|
// returns the reference number of the object and increments the ref count.
|
|
// This is called whenever an Objective-C object is sent to Go side.
|
|
- (int32_t)assignRefnumAndIncRefcount:(id)obj;
|
|
@end
|
|
|
|
static RefTracker *tracker = NULL;
|
|
|
|
#define IS_FROM_GO(refnum) ((refnum) < 0)
|
|
|
|
// init_seq is called when the Go side is initialized.
|
|
void init_seq() { tracker = [[RefTracker alloc] init]; }
|
|
|
|
void go_seq_dec_ref(int32_t refnum) {
|
|
[tracker dec:refnum];
|
|
}
|
|
|
|
NSData *go_seq_to_objc_bytearray(nbyteslice s, int copy) {
|
|
if (s.ptr == NULL) {
|
|
return NULL;
|
|
}
|
|
BOOL freeWhenDone = copy ? YES : NO;
|
|
return [NSData dataWithBytesNoCopy:s.ptr length:s.len freeWhenDone:freeWhenDone];
|
|
}
|
|
|
|
NSString *go_seq_to_objc_string(nstring str) {
|
|
if (str.len == 0) { // empty string.
|
|
return @"";
|
|
}
|
|
NSString * res = [[NSString alloc] initWithBytesNoCopy:str.ptr
|
|
length:str.len
|
|
encoding:NSUTF8StringEncoding
|
|
freeWhenDone:YES];
|
|
return res;
|
|
}
|
|
|
|
id go_seq_objc_from_refnum(int32_t refnum) {
|
|
return [tracker get:refnum];
|
|
}
|
|
|
|
GoSeqRef *go_seq_from_refnum(int32_t refnum) {
|
|
if (refnum == NULL_REFNUM) {
|
|
return nil;
|
|
}
|
|
if (IS_FROM_GO(refnum)) {
|
|
return [[GoSeqRef alloc] initWithRefnum:refnum obj:NULL];
|
|
}
|
|
return [[GoSeqRef alloc] initWithRefnum:refnum obj:go_seq_objc_from_refnum(refnum)];
|
|
}
|
|
|
|
int32_t go_seq_to_refnum(id obj) {
|
|
if (obj == nil) {
|
|
return NULL_REFNUM;
|
|
}
|
|
return [tracker assignRefnumAndIncRefcount:obj];
|
|
}
|
|
|
|
int32_t go_seq_go_to_refnum(GoSeqRef *ref) {
|
|
int32_t refnum = ref.refnum;
|
|
if (!IS_FROM_GO(refnum)) {
|
|
LOG_FATAL(@"go_seq_go_to_refnum on objective-c objects is not permitted");
|
|
}
|
|
return refnum;
|
|
}
|
|
|
|
nbyteslice go_seq_from_objc_bytearray(NSData *data, int copy) {
|
|
struct nbyteslice res = {NULL, 0, NO};
|
|
int sz = data.length;
|
|
if (sz == 0) {
|
|
return res;
|
|
}
|
|
void *ptr;
|
|
// If the argument was not a NSMutableData, copy the data so that
|
|
// the NSData is not changed from Go. The corresponding free is called
|
|
// by releaseByteSlice.
|
|
if (copy || ![data isKindOfClass:[NSMutableData class]]) {
|
|
void *arr_copy = malloc(sz);
|
|
if (arr_copy == NULL) {
|
|
LOG_FATAL(@"malloc failed");
|
|
return res;
|
|
}
|
|
memcpy(arr_copy, [data bytes], sz);
|
|
ptr = arr_copy;
|
|
} else {
|
|
ptr = (void *)[data bytes];
|
|
}
|
|
res.ptr = ptr;
|
|
res.len = sz;
|
|
return res;
|
|
}
|
|
|
|
nstring go_seq_from_objc_string(NSString *s) {
|
|
nstring res = {NULL, 0};
|
|
int len = [s lengthOfBytesUsingEncoding:NSUTF8StringEncoding];
|
|
|
|
if (len == 0) {
|
|
if (s.length > 0) {
|
|
LOG_INFO(@"unable to encode an NSString into UTF-8");
|
|
}
|
|
return res;
|
|
}
|
|
|
|
char *buf = (char *)malloc(len);
|
|
if (buf == NULL) {
|
|
LOG_FATAL(@"malloc failed");
|
|
return res;
|
|
}
|
|
NSUInteger used;
|
|
[s getBytes:buf
|
|
maxLength:len
|
|
usedLength:&used
|
|
encoding:NSUTF8StringEncoding
|
|
options:0
|
|
range:NSMakeRange(0, [s length])
|
|
remainingRange:NULL];
|
|
res.ptr = buf;
|
|
res.len = used;
|
|
return res;
|
|
}
|
|
|
|
@implementation GoSeqRef {
|
|
}
|
|
|
|
- (id)init {
|
|
LOG_FATAL(@"GoSeqRef init is disallowed");
|
|
return nil;
|
|
}
|
|
|
|
// called when an object from Go is passed in.
|
|
- (instancetype)initWithRefnum:(int32_t)refnum obj:(id)obj {
|
|
self = [super init];
|
|
if (self) {
|
|
_refnum = refnum;
|
|
_obj = obj;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (void)dealloc {
|
|
if (IS_FROM_GO(_refnum)) {
|
|
DestroyRef(_refnum);
|
|
}
|
|
}
|
|
@end
|
|
|
|
// RefCounter is a pair of (GoSeqProxy, count). GoSeqProxy has a strong
|
|
// reference to an Objective-C object. The count corresponds to
|
|
// the number of Go proxy objects.
|
|
//
|
|
// RefTracker maintains a map of refnum to RefCounter, for every
|
|
// Objective-C objects passed to Go. This map allows the transact
|
|
// call to relay the method call to the right Objective-C object, and
|
|
// prevents the Objective-C objects from being deallocated
|
|
// while they are still referenced from Go side.
|
|
@interface RefCounter : NSObject {
|
|
}
|
|
@property(strong, readonly) id obj;
|
|
@property int cnt;
|
|
|
|
- (id)initWithObject:(id)obj;
|
|
@end
|
|
|
|
@implementation RefCounter {
|
|
}
|
|
- (id)initWithObject:(id)obj {
|
|
self = [super init];
|
|
if (self) {
|
|
_obj = obj;
|
|
_cnt = 0;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
@end
|
|
|
|
@implementation RefTracker {
|
|
}
|
|
|
|
- (id)init {
|
|
self = [super init];
|
|
if (self) {
|
|
_next = 42;
|
|
_objs = [[NSMutableDictionary alloc] init];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (void)dec:(int32_t)refnum { // called whenever a go proxy object is finalized.
|
|
if (IS_FROM_GO(refnum)) {
|
|
LOG_FATAL(@"dec:invalid refnum for Objective-C objects");
|
|
return;
|
|
}
|
|
@synchronized(self) {
|
|
id key = @(refnum);
|
|
RefCounter *counter = [_objs objectForKey:key];
|
|
if (counter == NULL) {
|
|
LOG_FATAL(@"unknown refnum");
|
|
return;
|
|
}
|
|
int n = counter.cnt;
|
|
if (n <= 0) {
|
|
LOG_FATAL(@"refcount underflow");
|
|
} else if (n == 1) {
|
|
LOG_DEBUG(@"remove the reference %d", refnum);
|
|
NSValue *ptr = [NSValue valueWithPointer:(const void *)(counter.obj)];
|
|
[_refs removeObjectForKey:ptr];
|
|
[_objs removeObjectForKey:key];
|
|
} else {
|
|
counter.cnt = n - 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
- (id)get:(int32_t)refnum {
|
|
if (IS_FROM_GO(refnum)) {
|
|
LOG_FATAL(@"get:invalid refnum for Objective-C objects");
|
|
return NULL;
|
|
}
|
|
@synchronized(self) {
|
|
RefCounter *counter = _objs[@(refnum)];
|
|
if (counter == NULL) {
|
|
LOG_FATAL(@"unidentified object refnum: %d", refnum);
|
|
return NULL;
|
|
}
|
|
return counter.obj;
|
|
}
|
|
}
|
|
|
|
- (int32_t)assignRefnumAndIncRefcount:(id)obj {
|
|
@synchronized(self) {
|
|
NSValue *ptr = [NSValue valueWithPointer:(const void *)(obj)];
|
|
NSNumber *refnum = [_refs objectForKey:ptr];
|
|
if (refnum == NULL) {
|
|
refnum = @(_next++);
|
|
_refs[ptr] = refnum;
|
|
}
|
|
RefCounter *counter = [_objs objectForKey:refnum];
|
|
if (counter == NULL) {
|
|
counter = [[RefCounter alloc] initWithObject:obj];
|
|
counter.cnt = 1;
|
|
_objs[refnum] = counter;
|
|
} else {
|
|
counter.cnt++;
|
|
}
|
|
return (int32_t)([refnum intValue]);
|
|
}
|
|
}
|
|
|
|
@end
|