The seq serialization machinery is a historic artifact from when Go mobile code had to run in a separate process. Now that Go code is running in-process, replace the explicit serialization with direct calls and pass arguments on the stack. The benefits are a much smaller bind runtime, much less garbage (and, in Java, fewer objects with finalizers), less argument copying, and faster cross-language calls. The cost is a more complex generator, because some of the work from the bind runtime is moved to generated code. Generated code now handles conversion between Go and Java/ObjC types, multiple return values and memory management of byte slice and string arguments. To overcome the lack of calling C code between Go packages, all bound packages now end up in the same (fake) package, "gomobile_bind", instead of separate packages (go_<pkgname>). To avoid name clashes, the package name is added as a prefix to generated functions and types. Also, don't copy byte arrays passed to Go, saving call time and allowing read([]byte)-style interfaces to foreign callers (#12113). Finally, add support for nil interfaces and struct pointers to objc. This is a large CL, but most of the changes stem from changing testdata. The full benchcmp output on the CL/20095 benchmarks on my Nexus 5 is reproduced below. Note that the savings for the JavaSlice* benchmarks are skewed because byte slices are no longer copied before passing them to Go. benchmark old ns/op new ns/op delta BenchmarkJavaEmpty 26.0 19.0 -26.92% BenchmarkJavaEmptyDirect 23.0 22.0 -4.35% BenchmarkJavaNoargs 7685 2339 -69.56% BenchmarkJavaNoargsDirect 17405 8041 -53.80% BenchmarkJavaOnearg 26887 2366 -91.20% BenchmarkJavaOneargDirect 34266 7910 -76.92% BenchmarkJavaOneret 38325 2245 -94.14% BenchmarkJavaOneretDirect 46265 7708 -83.34% BenchmarkJavaManyargs 41720 2535 -93.92% BenchmarkJavaManyargsDirect 51026 8373 -83.59% BenchmarkJavaRefjava 38139 21260 -44.26% BenchmarkJavaRefjavaDirect 42706 28150 -34.08% BenchmarkJavaRefgo 34403 6843 -80.11% BenchmarkJavaRefgoDirect 40193 16582 -58.74% BenchmarkJavaStringShort 32366 9323 -71.20% BenchmarkJavaStringShortDirect 41973 19118 -54.45% BenchmarkJavaStringLong 127879 94420 -26.16% BenchmarkJavaStringLongDirect 133776 114760 -14.21% BenchmarkJavaStringShortUnicode 32562 9221 -71.68% BenchmarkJavaStringShortUnicodeDirect 41464 19094 -53.95% BenchmarkJavaStringLongUnicode 131015 89401 -31.76% BenchmarkJavaStringLongUnicodeDirect 134130 90786 -32.31% BenchmarkJavaSliceShort 42462 7538 -82.25% BenchmarkJavaSliceShortDirect 52940 17017 -67.86% BenchmarkJavaSliceLong 138391 8466 -93.88% BenchmarkJavaSliceLongDirect 205804 15666 -92.39% BenchmarkGoEmpty 3.00 3.00 +0.00% BenchmarkGoEmptyDirect 3.00 3.00 +0.00% BenchmarkGoNoarg 40342 13716 -66.00% BenchmarkGoNoargDirect 46691 13569 -70.94% BenchmarkGoOnearg 43529 13757 -68.40% BenchmarkGoOneargDirect 44867 14078 -68.62% BenchmarkGoOneret 45456 13559 -70.17% BenchmarkGoOneretDirect 44694 13442 -69.92% BenchmarkGoRefjava 55111 28071 -49.06% BenchmarkGoRefjavaDirect 60883 26872 -55.86% BenchmarkGoRefgo 57038 29223 -48.77% BenchmarkGoRefgoDirect 56153 27812 -50.47% BenchmarkGoManyargs 67967 17398 -74.40% BenchmarkGoManyargsDirect 60617 16998 -71.96% BenchmarkGoStringShort 57538 22600 -60.72% BenchmarkGoStringShortDirect 52627 22704 -56.86% BenchmarkGoStringLong 128485 52530 -59.12% BenchmarkGoStringLongDirect 138377 52079 -62.36% BenchmarkGoStringShortUnicode 57062 22994 -59.70% BenchmarkGoStringShortUnicodeDirect 62563 22938 -63.34% BenchmarkGoStringLongUnicode 139913 55553 -60.29% BenchmarkGoStringLongUnicodeDirect 150863 57791 -61.69% BenchmarkGoSliceShort 59279 20215 -65.90% BenchmarkGoSliceShortDirect 60160 21136 -64.87% BenchmarkGoSliceLong 411225 301870 -26.59% BenchmarkGoSliceLongDirect 399029 298915 -25.09% Fixes golang/go#12619 Fixes golang/go#12113 Fixes golang/go#13033 Change-Id: I2b45e9e98a1248e3c23a5137f775f7364908bec7 Reviewed-on: https://go-review.googlesource.com/19821 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
248 lines
6.2 KiB
Go
248 lines
6.2 KiB
Go
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package bind
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"go/token"
|
|
"go/types"
|
|
"io"
|
|
"regexp"
|
|
)
|
|
|
|
type (
|
|
ErrorList []error
|
|
|
|
// varMode describes the lifetime of an argument or
|
|
// return value. Modes are used to guide the conversion
|
|
// of string and byte slice values accross the language
|
|
// barrier. The same conversion mode must be used for
|
|
// both the conversion before a foreign call and the
|
|
// corresponding conversion after the call.
|
|
// See the mode* constants for a description of
|
|
// each mode.
|
|
varMode int
|
|
)
|
|
|
|
const (
|
|
// modeTransient are for function arguments that
|
|
// are not used after the function returns.
|
|
// Transient strings and byte slices don't need copying
|
|
// when passed accross the language barrier.
|
|
modeTransient varMode = iota
|
|
// modeRetained are for function arguments that are
|
|
// used after the function returns. Retained strings
|
|
// don't need an intermediate copy, while byte slices do.
|
|
modeRetained
|
|
// modeReturned are for values that are returned to the
|
|
// caller of a function. Returned values are always copied.
|
|
modeReturned
|
|
)
|
|
|
|
func (m varMode) copyString() bool {
|
|
return m == modeReturned
|
|
}
|
|
|
|
func (m varMode) copySlice() bool {
|
|
return m == modeReturned || m == modeRetained
|
|
}
|
|
|
|
func (list ErrorList) Error() string {
|
|
buf := new(bytes.Buffer)
|
|
for i, err := range list {
|
|
if i > 0 {
|
|
buf.WriteRune('\n')
|
|
}
|
|
io.WriteString(buf, err.Error())
|
|
}
|
|
return buf.String()
|
|
}
|
|
|
|
type generator struct {
|
|
*printer
|
|
fset *token.FileSet
|
|
pkg *types.Package
|
|
err ErrorList
|
|
|
|
// fields set by init.
|
|
pkgName string
|
|
// pkgPrefix is a prefix for disambiguating
|
|
// function names for binding multiple packages
|
|
pkgPrefix string
|
|
funcs []*types.Func
|
|
constants []*types.Const
|
|
vars []*types.Var
|
|
|
|
interfaces []interfaceInfo
|
|
structs []structInfo
|
|
otherNames []*types.TypeName
|
|
}
|
|
|
|
func (g *generator) init() {
|
|
g.pkgName = g.pkg.Name()
|
|
// TODO(elias.naur): Avoid (and test) name clashes from multiple packages
|
|
// with the same name. Perhaps use the index from the order the package is
|
|
// generated.
|
|
g.pkgPrefix = g.pkgName
|
|
|
|
scope := g.pkg.Scope()
|
|
hasExported := false
|
|
for _, name := range scope.Names() {
|
|
obj := scope.Lookup(name)
|
|
if !obj.Exported() {
|
|
continue
|
|
}
|
|
hasExported = true
|
|
switch obj := obj.(type) {
|
|
case *types.Func:
|
|
if isCallable(obj) {
|
|
g.funcs = append(g.funcs, obj)
|
|
}
|
|
case *types.TypeName:
|
|
named := obj.Type().(*types.Named)
|
|
switch t := named.Underlying().(type) {
|
|
case *types.Struct:
|
|
g.structs = append(g.structs, structInfo{obj, t})
|
|
case *types.Interface:
|
|
g.interfaces = append(g.interfaces, interfaceInfo{obj, t, makeIfaceSummary(t)})
|
|
default:
|
|
g.otherNames = append(g.otherNames, obj)
|
|
}
|
|
case *types.Const:
|
|
if _, ok := obj.Type().(*types.Basic); !ok {
|
|
g.errorf("unsupported exported const for %s: %T", obj.Name(), obj)
|
|
continue
|
|
}
|
|
g.constants = append(g.constants, obj)
|
|
case *types.Var:
|
|
g.vars = append(g.vars, obj)
|
|
default:
|
|
g.errorf("unsupported exported type for %s: %T", obj.Name(), obj)
|
|
}
|
|
}
|
|
if !hasExported {
|
|
g.errorf("no exported names in the package %q", g.pkg.Path())
|
|
}
|
|
}
|
|
|
|
func (_ *generator) toCFlag(v bool) int {
|
|
if v {
|
|
return 1
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func (g *generator) errorf(format string, args ...interface{}) {
|
|
g.err = append(g.err, fmt.Errorf(format, args...))
|
|
}
|
|
|
|
// cgoType returns the name of a Cgo type suitable for converting a value of
|
|
// the given type.
|
|
func (g *generator) cgoType(t types.Type) string {
|
|
if isErrorType(t) {
|
|
return g.cgoType(types.Typ[types.String])
|
|
}
|
|
switch t := t.(type) {
|
|
case *types.Basic:
|
|
switch t.Kind() {
|
|
case types.Bool, types.UntypedBool:
|
|
return "char"
|
|
case types.Int:
|
|
return "nint"
|
|
case types.Int8:
|
|
return "int8_t"
|
|
case types.Int16:
|
|
return "int16_t"
|
|
case types.Int32, types.UntypedRune: // types.Rune
|
|
return "int32_t"
|
|
case types.Int64, types.UntypedInt:
|
|
return "int64_t"
|
|
case types.Uint8: // types.Byte
|
|
return "uint8_t"
|
|
// TODO(crawshaw): case types.Uint, types.Uint16, types.Uint32, types.Uint64:
|
|
case types.Float32:
|
|
return "float"
|
|
case types.Float64, types.UntypedFloat:
|
|
return "double"
|
|
case types.String:
|
|
return "nstring"
|
|
default:
|
|
panic(fmt.Sprintf("unsupported basic type: %s", t))
|
|
}
|
|
case *types.Slice:
|
|
switch e := t.Elem().(type) {
|
|
case *types.Basic:
|
|
switch e.Kind() {
|
|
case types.Uint8: // Byte.
|
|
return "nbyteslice"
|
|
default:
|
|
panic(fmt.Sprintf("unsupported slice type: %s", t))
|
|
}
|
|
default:
|
|
panic(fmt.Sprintf("unsupported slice type: %s", t))
|
|
}
|
|
case *types.Pointer:
|
|
if _, ok := t.Elem().(*types.Named); ok {
|
|
return g.cgoType(t.Elem())
|
|
}
|
|
panic(fmt.Sprintf("unsupported pointer to type: %s", t))
|
|
case *types.Named:
|
|
return "int32_t"
|
|
default:
|
|
panic(fmt.Sprintf("unsupported type: %s", t))
|
|
}
|
|
}
|
|
|
|
func (g *generator) genInterfaceMethodSignature(m *types.Func, iName string, header bool) {
|
|
sig := m.Type().(*types.Signature)
|
|
params := sig.Params()
|
|
res := sig.Results()
|
|
|
|
if res.Len() == 0 {
|
|
g.Printf("void ")
|
|
} else {
|
|
if res.Len() == 1 {
|
|
g.Printf("%s ", g.cgoType(res.At(0).Type()))
|
|
} else {
|
|
if header {
|
|
g.Printf("typedef struct cproxy%s_%s_%s_return {\n", g.pkgPrefix, iName, m.Name())
|
|
g.Indent()
|
|
for i := 0; i < res.Len(); i++ {
|
|
t := res.At(i).Type()
|
|
g.Printf("%s r%d;\n", g.cgoType(t), i)
|
|
}
|
|
g.Outdent()
|
|
g.Printf("} cproxy%s_%s_%s_return;\n", g.pkgPrefix, iName, m.Name())
|
|
}
|
|
g.Printf("struct cproxy%s_%s_%s_return ", g.pkgPrefix, iName, m.Name())
|
|
}
|
|
}
|
|
g.Printf("cproxy%s_%s_%s(int32_t refnum", g.pkgPrefix, iName, m.Name())
|
|
for i := 0; i < params.Len(); i++ {
|
|
t := params.At(i).Type()
|
|
g.Printf(", %s %s", g.cgoType(t), paramName(params, i))
|
|
}
|
|
g.Printf(")")
|
|
if header {
|
|
g.Printf(";\n")
|
|
} else {
|
|
g.Printf(" {\n")
|
|
}
|
|
}
|
|
|
|
var paramRE = regexp.MustCompile(`^p[0-9]*$`)
|
|
|
|
// paramName replaces incompatible name with a p0-pN name.
|
|
// Missing names, or existing names of the form p[0-9] are incompatible.
|
|
// TODO(crawshaw): Replace invalid unicode names.
|
|
func paramName(params *types.Tuple, pos int) string {
|
|
name := params.At(pos).Name()
|
|
if name == "" || name[0] == '_' || paramRE.MatchString(name) {
|
|
name = fmt.Sprintf("p%d", pos)
|
|
}
|
|
return name
|
|
}
|