6d8ad35e46
This is is a follow-up from my previous PR (#65). It makes gomobile aware of GOOS=ios and adds support for specifying specific Apple platforms, instead of overloading the "ios" platform. Supported platforms: ios, iossimulator, macos, and maccatalyst These can now be specified the -target argument to gomobile, e.g.: gomobile build -target=ios,iossimulator,macos,maccatalyst It preserves the current behavior of -target=ios, which will build for ios and iossimulator on supported architectures (arm64 and amd64). It adds platform-specific build tags so Go code can discriminate between different Apple platforms like maccatalyst (UIKit on macOS). This PR also fixes a number of broken tests. TODO: cgo has a bug where c-archive builds targeting Catalyst will fail unless -tags=ios is supplied. See https://golang.org/issues/47228 Fixes https://golang.org/issues/47212 Updates https://golang.org/issues/47228 Change-Id: Ib1a2f5302c5edd0704c13ffbe8f4061211f50d4e GitHub-Last-Rev: 01ab28e63fe6890a9f9783e3fc41b1c895b0274d GitHub-Pull-Request: golang/mobile#70 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/334689 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hajime Hoshi <hajimehoshi@gmail.com>
327 lines
9.8 KiB
Go
327 lines
9.8 KiB
Go
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
"text/template"
|
|
)
|
|
|
|
func TestBindAndroid(t *testing.T) {
|
|
androidHome := os.Getenv("ANDROID_HOME")
|
|
if androidHome == "" {
|
|
t.Skip("ANDROID_HOME not found, skipping bind")
|
|
}
|
|
platform, err := androidAPIPath()
|
|
if err != nil {
|
|
t.Skip("No android API platform found in $ANDROID_HOME, skipping bind")
|
|
}
|
|
platform = strings.Replace(platform, androidHome, "$ANDROID_HOME", -1)
|
|
|
|
defer func() {
|
|
xout = os.Stderr
|
|
buildN = false
|
|
buildX = false
|
|
buildO = ""
|
|
buildTarget = ""
|
|
bindJavaPkg = ""
|
|
}()
|
|
buildN = true
|
|
buildX = true
|
|
buildO = "asset.aar"
|
|
buildTarget = "android/arm"
|
|
|
|
tests := []struct {
|
|
javaPkg string
|
|
}{
|
|
{
|
|
// Empty javaPkg
|
|
},
|
|
{
|
|
javaPkg: "com.example.foo",
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
bindJavaPkg = tc.javaPkg
|
|
|
|
buf := new(bytes.Buffer)
|
|
xout = buf
|
|
gopath = filepath.SplitList(goEnv("GOPATH"))[0]
|
|
if goos == "windows" {
|
|
os.Setenv("HOMEDRIVE", "C:")
|
|
}
|
|
cmdBind.flag.Parse([]string{"golang.org/x/mobile/asset"})
|
|
err := runBind(cmdBind)
|
|
if err != nil {
|
|
t.Log(buf.String())
|
|
t.Fatal(err)
|
|
}
|
|
got := filepath.ToSlash(buf.String())
|
|
|
|
output, err := defaultOutputData()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
data := struct {
|
|
outputData
|
|
AndroidPlatform string
|
|
JavaPkg string
|
|
}{
|
|
outputData: output,
|
|
AndroidPlatform: platform,
|
|
JavaPkg: tc.javaPkg,
|
|
}
|
|
|
|
wantBuf := new(bytes.Buffer)
|
|
if err := bindAndroidTmpl.Execute(wantBuf, data); err != nil {
|
|
t.Errorf("%+v: computing diff failed: %v", tc, err)
|
|
continue
|
|
}
|
|
|
|
diff, err := diff(got, wantBuf.String())
|
|
if err != nil {
|
|
t.Errorf("%+v: computing diff failed: %v", tc, err)
|
|
continue
|
|
}
|
|
if diff != "" {
|
|
t.Errorf("%+v: unexpected output:\n%s", tc, diff)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBindApple(t *testing.T) {
|
|
if !xcodeAvailable() {
|
|
t.Skip("Xcode is missing")
|
|
}
|
|
defer func() {
|
|
xout = os.Stderr
|
|
buildN = false
|
|
buildX = false
|
|
buildO = ""
|
|
buildTarget = ""
|
|
bindPrefix = ""
|
|
}()
|
|
buildN = true
|
|
buildX = true
|
|
buildO = "Asset.xcframework"
|
|
buildTarget = "ios/arm64"
|
|
|
|
tests := []struct {
|
|
prefix string
|
|
out string
|
|
}{
|
|
{
|
|
// empty prefix
|
|
},
|
|
{
|
|
prefix: "Foo",
|
|
},
|
|
{
|
|
out: "Abcde.xcframework",
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
bindPrefix = tc.prefix
|
|
if tc.out != "" {
|
|
buildO = tc.out
|
|
}
|
|
|
|
buf := new(bytes.Buffer)
|
|
xout = buf
|
|
gopath = filepath.SplitList(goEnv("GOPATH"))[0]
|
|
if goos == "windows" {
|
|
os.Setenv("HOMEDRIVE", "C:")
|
|
}
|
|
cmdBind.flag.Parse([]string{"golang.org/x/mobile/asset"})
|
|
if err := runBind(cmdBind); err != nil {
|
|
t.Log(buf.String())
|
|
t.Fatal(err)
|
|
}
|
|
got := filepath.ToSlash(buf.String())
|
|
|
|
output, err := defaultOutputData()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
data := struct {
|
|
outputData
|
|
Output string
|
|
Prefix string
|
|
}{
|
|
outputData: output,
|
|
Output: buildO[:len(buildO)-len(".xcframework")],
|
|
Prefix: tc.prefix,
|
|
}
|
|
|
|
wantBuf := new(bytes.Buffer)
|
|
if err := bindAppleTmpl.Execute(wantBuf, data); err != nil {
|
|
t.Errorf("%+v: computing diff failed: %v", tc, err)
|
|
continue
|
|
}
|
|
|
|
diff, err := diff(got, wantBuf.String())
|
|
if err != nil {
|
|
t.Errorf("%+v: computing diff failed: %v", tc, err)
|
|
continue
|
|
}
|
|
if diff != "" {
|
|
t.Errorf("%+v: unexpected output:\n%s", tc, diff)
|
|
}
|
|
}
|
|
}
|
|
|
|
var bindAndroidTmpl = template.Must(template.New("output").Parse(`GOMOBILE={{.GOPATH}}/pkg/gomobile
|
|
WORK=$WORK
|
|
GOOS=android CGO_ENABLED=1 gobind -lang=go,java -outdir=$WORK{{if .JavaPkg}} -javapkg={{.JavaPkg}}{{end}} golang.org/x/mobile/asset
|
|
mkdir -p $WORK/src
|
|
PWD=$WORK/src GOOS=android GOARCH=arm CC=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang CXX=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang++ CGO_ENABLED=1 GOARM=7 GOPATH=$WORK:$GOPATH go mod tidy
|
|
PWD=$WORK/src GOOS=android GOARCH=arm CC=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang CXX=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang++ CGO_ENABLED=1 GOARM=7 GOPATH=$WORK:$GOPATH go build -x -buildmode=c-shared -o=$WORK/android/src/main/jniLibs/armeabi-v7a/libgojni.so ./gobind
|
|
PWD=$WORK/java javac -d $WORK/javac-output -source 1.7 -target 1.7 -bootclasspath {{.AndroidPlatform}}/android.jar *.java
|
|
jar c -C $WORK/javac-output .
|
|
`))
|
|
|
|
var bindAppleTmpl = template.Must(template.New("output").Parse(`GOMOBILE={{.GOPATH}}/pkg/gomobile
|
|
WORK=$WORK
|
|
rm -r -f "{{.Output}}.xcframework"
|
|
GOOS=ios CGO_ENABLED=1 gobind -lang=go,objc -outdir=$WORK/ios -tags=ios{{if .Prefix}} -prefix={{.Prefix}}{{end}} golang.org/x/mobile/asset
|
|
mkdir -p $WORK/ios/src
|
|
PWD=$WORK/ios/src GOOS=ios GOARCH=arm64 GOFLAGS=-tags=ios CC=iphoneos-clang CXX=iphoneos-clang++ CGO_CFLAGS=-isysroot iphoneos -miphoneos-version-min=13.0 -fembed-bitcode -arch arm64 CGO_CXXFLAGS=-isysroot iphoneos -miphoneos-version-min=13.0 -fembed-bitcode -arch arm64 CGO_LDFLAGS=-isysroot iphoneos -miphoneos-version-min=13.0 -fembed-bitcode -arch arm64 CGO_ENABLED=1 DARWIN_SDK=iphoneos GOPATH=$WORK/ios:$GOPATH go mod tidy
|
|
PWD=$WORK/ios/src GOOS=ios GOARCH=arm64 GOFLAGS=-tags=ios CC=iphoneos-clang CXX=iphoneos-clang++ CGO_CFLAGS=-isysroot iphoneos -miphoneos-version-min=13.0 -fembed-bitcode -arch arm64 CGO_CXXFLAGS=-isysroot iphoneos -miphoneos-version-min=13.0 -fembed-bitcode -arch arm64 CGO_LDFLAGS=-isysroot iphoneos -miphoneos-version-min=13.0 -fembed-bitcode -arch arm64 CGO_ENABLED=1 DARWIN_SDK=iphoneos GOPATH=$WORK/ios:$GOPATH go build -x -buildmode=c-archive -o $WORK/{{.Output}}-ios-arm64.a ./gobind
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers
|
|
ln -s A $WORK/ios/iphoneos/{{.Output}}.framework/Versions/Current
|
|
ln -s Versions/Current/Headers $WORK/ios/iphoneos/{{.Output}}.framework/Headers
|
|
ln -s Versions/Current/{{.Output}} $WORK/ios/iphoneos/{{.Output}}.framework/{{.Output}}
|
|
xcrun lipo $WORK/{{.Output}}-ios-arm64.a -create -o $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/{{.Output}}
|
|
cp $WORK/ios/src/gobind/{{.Prefix}}Asset.objc.h $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers/{{.Prefix}}Asset.objc.h
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers
|
|
cp $WORK/ios/src/gobind/Universe.objc.h $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers/Universe.objc.h
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers
|
|
cp $WORK/ios/src/gobind/ref.h $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers/ref.h
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Headers
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Resources
|
|
ln -s Versions/Current/Resources $WORK/ios/iphoneos/{{.Output}}.framework/Resources
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Resources
|
|
mkdir -p $WORK/ios/iphoneos/{{.Output}}.framework/Versions/A/Modules
|
|
ln -s Versions/Current/Modules $WORK/ios/iphoneos/{{.Output}}.framework/Modules
|
|
xcodebuild -create-xcframework -framework $WORK/ios/iphoneos/{{.Output}}.framework -output {{.Output}}.xcframework
|
|
`))
|
|
|
|
func TestBindAppleAll(t *testing.T) {
|
|
if !xcodeAvailable() {
|
|
t.Skip("Xcode is missing")
|
|
}
|
|
defer func() {
|
|
xout = os.Stderr
|
|
buildN = false
|
|
buildX = false
|
|
buildO = ""
|
|
buildTarget = ""
|
|
bindPrefix = ""
|
|
}()
|
|
buildN = true
|
|
buildX = true
|
|
buildO = "Asset.xcframework"
|
|
buildTarget = "ios"
|
|
|
|
buf := new(bytes.Buffer)
|
|
xout = buf
|
|
gopath = filepath.SplitList(goEnv("GOPATH"))[0]
|
|
if goos == "windows" {
|
|
os.Setenv("HOMEDRIVE", "C:")
|
|
}
|
|
cmdBind.flag.Parse([]string{"golang.org/x/mobile/asset"})
|
|
if err := runBind(cmdBind); err != nil {
|
|
t.Log(buf.String())
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestBindWithGoModules(t *testing.T) {
|
|
if runtime.GOOS == "android" || runtime.GOOS == "ios" {
|
|
t.Skipf("gomobile and gobind are not available on %s", runtime.GOOS)
|
|
}
|
|
|
|
dir, err := ioutil.TempDir("", "gomobile-test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dir)
|
|
|
|
if out, err := exec.Command("go", "build", "-o="+dir, "golang.org/x/mobile/cmd/gobind").CombinedOutput(); err != nil {
|
|
t.Fatalf("%v: %s", err, string(out))
|
|
}
|
|
if out, err := exec.Command("go", "build", "-o="+dir, "golang.org/x/mobile/cmd/gomobile").CombinedOutput(); err != nil {
|
|
t.Fatalf("%v: %s", err, string(out))
|
|
}
|
|
path := dir
|
|
if p := os.Getenv("PATH"); p != "" {
|
|
path += string(filepath.ListSeparator) + p
|
|
}
|
|
|
|
for _, target := range []string{"android", "ios"} {
|
|
t.Run(target, func(t *testing.T) {
|
|
switch target {
|
|
case "android":
|
|
androidHome := os.Getenv("ANDROID_HOME")
|
|
if androidHome == "" {
|
|
t.Skip("ANDROID_HOME not found, skipping bind")
|
|
}
|
|
if _, err := androidAPIPath(); err != nil {
|
|
t.Skip("No android API platform found in $ANDROID_HOME, skipping bind")
|
|
}
|
|
case "ios":
|
|
if !xcodeAvailable() {
|
|
t.Skip("Xcode is missing")
|
|
}
|
|
}
|
|
|
|
var out string
|
|
switch target {
|
|
case "android":
|
|
out = filepath.Join(dir, "cgopkg.aar")
|
|
case "ios":
|
|
out = filepath.Join(dir, "Cgopkg.xcframework")
|
|
}
|
|
|
|
tests := []struct {
|
|
Name string
|
|
Path string
|
|
Dir string
|
|
}{
|
|
{
|
|
Name: "Absolute Path",
|
|
Path: "golang.org/x/mobile/bind/testdata/cgopkg",
|
|
},
|
|
{
|
|
Name: "Relative Path",
|
|
Path: "./bind/testdata/cgopkg",
|
|
Dir: filepath.Join("..", ".."),
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
tc := tc
|
|
t.Run(tc.Name, func(t *testing.T) {
|
|
cmd := exec.Command(filepath.Join(dir, "gomobile"), "bind", "-target="+target, "-o="+out, tc.Path)
|
|
cmd.Env = append(os.Environ(), "PATH="+path, "GO111MODULE=on")
|
|
cmd.Dir = tc.Dir
|
|
if out, err := cmd.CombinedOutput(); err != nil {
|
|
t.Errorf("gomobile bind failed: %v\n%s", err, string(out))
|
|
}
|
|
})
|
|
}
|
|
})
|
|
}
|
|
}
|