a3e0621280
Gobind uses strings for passing errors across the language barrier. However, since Gobind doesn't have a concept of a nil string, it can't separate an empty native string from a nil string. In turn, that means that empty errors, exceptions or NSError * with an empty description are treated as no error. With ObjC, empty errors are replaced with a default string to workaround the issue, while with Java empty errors are silently ignored. Fix this by replacing strings with actual error objects, wrapping the Go error, Java Throwable or ObjC NSError *, and letting the existing bind machinery take care of passing the references across. It's a large change for a small corner case, but I believe objects are a better fit for exception that strings. Error objects also naturally leads to future additions, for example accessing the exception class name or chained exception. Change-Id: Ie03b47cafcb231ad1e12a80195693fa7459c6265 Reviewed-on: https://go-review.googlesource.com/24100 Reviewed-by: David Crawshaw <crawshaw@golang.org>
43 lines
1006 B
Plaintext
43 lines
1006 B
Plaintext
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package gomobile_bind
|
|
|
|
// Go support functions for generated Go bindings. This file is
|
|
// copied into the generated package, gomobile_bind, and compiled
|
|
// along with the bindings.
|
|
|
|
// #include <stdlib.h>
|
|
// #include "seq.h"
|
|
import "C"
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
_seq "golang.org/x/mobile/bind/seq"
|
|
)
|
|
|
|
func init() {
|
|
_seq.FinalizeRef = func(ref *_seq.Ref) {
|
|
refnum := ref.Bind_Num
|
|
if refnum < 0 {
|
|
panic(fmt.Sprintf("not a foreign ref: %d", refnum))
|
|
}
|
|
C.go_seq_dec_ref(C.int32_t(refnum))
|
|
}
|
|
_seq.IncForeignRef = func(refnum int32) {
|
|
if refnum < 0 {
|
|
panic(fmt.Sprintf("not a foreign ref: %d", refnum))
|
|
}
|
|
C.go_seq_inc_ref(C.int32_t(refnum))
|
|
}
|
|
}
|
|
|
|
// IncGoRef is called by foreign code to pin a Go object while its refnum is crossing
|
|
// the language barrier
|
|
//export IncGoRef
|
|
func IncGoRef(refnum C.int32_t) {
|
|
_seq.Inc(int32(refnum))
|
|
}
|