This CL is a pure refactoring. This removes a global variable ctx, which is a build.Default. Before this change, ctx was used to keep build tags and its state affected go command executions. As the variable is mutable, the code was not readable. This changes introduces another global variable buildTags instead, but this is more consistent with other build flags, and this is immutable. Updates golang/go#27234 Change-Id: Id8d0c779de21b249e96febd2f40833cd0c84534f Reviewed-on: https://go-review.googlesource.com/c/mobile/+/208060 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
186 lines
4.5 KiB
Go
186 lines
4.5 KiB
Go
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
"text/template"
|
|
)
|
|
|
|
func TestRFC1034Label(t *testing.T) {
|
|
tests := []struct {
|
|
in, want string
|
|
}{
|
|
{"a", "a"},
|
|
{"123", "-23"},
|
|
{"a.b.c", "a-b-c"},
|
|
{"a-b", "a-b"},
|
|
{"a:b", "a-b"},
|
|
{"a?b", "a-b"},
|
|
{"αβγ", "---"},
|
|
{"💩", "--"},
|
|
{"My App", "My-App"},
|
|
{"...", ""},
|
|
{".-.", "--"},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
if got := rfc1034Label(tc.in); got != tc.want {
|
|
t.Errorf("rfc1034Label(%q) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAndroidPkgName(t *testing.T) {
|
|
tests := []struct {
|
|
in, want string
|
|
}{
|
|
{"a", "a"},
|
|
{"a123", "a123"},
|
|
{"a.b.c", "a_b_c"},
|
|
{"a-b", "a_b"},
|
|
{"a:b", "a_b"},
|
|
{"a?b", "a_b"},
|
|
{"αβγ", "go___"},
|
|
{"💩", "go_"},
|
|
{"My App", "My_App"},
|
|
{"...", "go___"},
|
|
{".-.", "go___"},
|
|
{"abstract", "abstract_"},
|
|
{"Abstract", "Abstract"},
|
|
{"12345", "go12345"},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
if got := androidPkgName(tc.in); got != tc.want {
|
|
t.Errorf("len %d", len(tc.in))
|
|
t.Errorf("androidPkgName(%q) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAndroidBuild(t *testing.T) {
|
|
if runtime.GOOS == "android" {
|
|
t.Skip("not available on Android")
|
|
}
|
|
buf := new(bytes.Buffer)
|
|
defer func() {
|
|
xout = os.Stderr
|
|
buildN = false
|
|
buildX = false
|
|
}()
|
|
xout = buf
|
|
buildN = true
|
|
buildX = true
|
|
buildO = "basic.apk"
|
|
buildTarget = "android/arm"
|
|
gopath = filepath.ToSlash(filepath.SplitList(goEnv("GOPATH"))[0])
|
|
if goos == "windows" {
|
|
os.Setenv("HOMEDRIVE", "C:")
|
|
}
|
|
cmdBuild.flag.Parse([]string{"golang.org/x/mobile/example/basic"})
|
|
oldTags := buildTags
|
|
buildTags = []string{"tag1"}
|
|
defer func() {
|
|
buildTags = oldTags
|
|
}()
|
|
err := runBuild(cmdBuild)
|
|
if err != nil {
|
|
t.Log(buf.String())
|
|
t.Fatal(err)
|
|
}
|
|
|
|
diff, err := diffOutput(buf.String(), androidBuildTmpl)
|
|
if err != nil {
|
|
t.Fatalf("computing diff failed: %v", err)
|
|
}
|
|
if diff != "" {
|
|
t.Errorf("unexpected output:\n%s", diff)
|
|
}
|
|
}
|
|
|
|
var androidBuildTmpl = template.Must(template.New("output").Parse(`GOMOBILE={{.GOPATH}}/pkg/gomobile
|
|
WORK=$WORK
|
|
mkdir -p $WORK/lib/armeabi-v7a
|
|
GOOS=android GOARCH=arm CC=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang CXX=$NDK_PATH/toolchains/llvm/prebuilt/{{.NDKARCH}}/bin/armv7a-linux-androideabi16-clang++ CGO_ENABLED=1 GOARM=7 GO111MODULE=off go build -tags tag1 -x -buildmode=c-shared -o $WORK/lib/armeabi-v7a/libbasic.so golang.org/x/mobile/example/basic
|
|
`))
|
|
|
|
func TestParseBuildTargetFlag(t *testing.T) {
|
|
archs := strings.Join(allArchs, ",")
|
|
|
|
tests := []struct {
|
|
in string
|
|
wantErr bool
|
|
wantOS string
|
|
wantArchs string
|
|
}{
|
|
{"android", false, "android", archs},
|
|
{"android,android/arm", false, "android", archs},
|
|
{"android/arm", false, "android", "arm"},
|
|
|
|
{"ios", false, "darwin", archs},
|
|
{"ios,ios/arm", false, "darwin", archs},
|
|
{"ios/arm", false, "darwin", "arm"},
|
|
{"ios/amd64", false, "darwin", "amd64"},
|
|
|
|
{"", true, "", ""},
|
|
{"linux", true, "", ""},
|
|
{"android/x86", true, "", ""},
|
|
{"android/arm5", true, "", ""},
|
|
{"ios/mips", true, "", ""},
|
|
{"android,ios", true, "", ""},
|
|
{"ios,android", true, "", ""},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
gotOS, gotArchs, err := parseBuildTarget(tc.in)
|
|
if tc.wantErr {
|
|
if err == nil {
|
|
t.Errorf("-target=%q; want error, got (%q, %q, nil)", tc.in, gotOS, gotArchs)
|
|
}
|
|
continue
|
|
}
|
|
if err != nil || gotOS != tc.wantOS || strings.Join(gotArchs, ",") != tc.wantArchs {
|
|
t.Errorf("-target=%q; want (%v, [%v], nil), got (%q, %q, %v)",
|
|
tc.in, tc.wantOS, tc.wantArchs, gotOS, gotArchs, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestRegexImportGolangXPackage(t *testing.T) {
|
|
tests := []struct {
|
|
in string
|
|
want string
|
|
wantLen int
|
|
}{
|
|
{"ffffffff t golang.org/x/mobile", "golang.org/x/mobile", 2},
|
|
{"ffffffff t github.com/example/repo/vendor/golang.org/x/mobile", "golang.org/x/mobile", 2},
|
|
{"ffffffff t github.com/example/golang.org/x/mobile", "", 0},
|
|
{"ffffffff t github.com/example/repo", "", 0},
|
|
{"ffffffff t github.com/example/repo/vendor", "", 0},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
res := nmRE.FindStringSubmatch(tc.in)
|
|
if len(res) != tc.wantLen {
|
|
t.Errorf("nmRE returned unexpected result for %q: want len(res) = %d, got %d",
|
|
tc.in, tc.wantLen, len(res))
|
|
continue
|
|
}
|
|
if tc.wantLen == 0 {
|
|
continue
|
|
}
|
|
if res[1] != tc.want {
|
|
t.Errorf("nmRE returned unexpected result. want (%v), got (%v)",
|
|
tc.want, res[1])
|
|
}
|
|
}
|
|
}
|