status-im/mobile
2
0
Fork 0
mirror of synced 2025-02-23 14:58:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/gomobile: require -bundleid set for -target=ios

Browse Source 
The default, org.golang.todo, is not available outside Google
and the resulting error is confusing.

Fixes golang/go#26615

Change-Id: I417a2f83bc3755628f1f3541a061c9272eb318c0
Reviewed-on: https://go-review.googlesource.com/c/156498
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Elias Naur 2019-01-07 13:23:47 +01:00
parent 9a2b4796a4
commit dc07713565
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/gomobile/build.go
View File

@ -50,8 +50,8 @@ are copied into the output.
Flag -iosversion sets the minimal version of the iOS SDK to compile against.
The default version is 6.1.
The -bundleid flag is for -target ios only and sets the bundle ID to use
with the app; defaults to "org.golang.todo".
The -bundleid flag is required for -target ios and sets the bundle ID to use
with the app.
The -o flag specifies the output file name. If not specified, the
output file name depends on the package built.
@ -134,6 +134,9 @@ func runBuild(cmd *command) (err error) {
}
return nil
}
if buildBundleID == "" {
return fmt.Errorf("-target=ios requires -bundleid set")
}
nmpkgs, err = goIOSBuild(pkg, buildBundleID, targetArchs)
if err != nil {
return err
@ -240,7 +243,7 @@ func addBuildFlags(cmd *command) {
cmd.flag.StringVar(&buildGcflags, "gcflags", "", "")
cmd.flag.StringVar(&buildLdflags, "ldflags", "", "")
cmd.flag.StringVar(&buildTarget, "target", "android", "")
cmd.flag.StringVar(&buildBundleID, "bundleid", "org.golang.todo", "")
cmd.flag.StringVar(&buildBundleID, "bundleid", "", "")
cmd.flag.StringVar(&buildIOSVersion, "iosversion", "6.1", "")
cmd.flag.BoolVar(&buildA, "a", false, "")

4
cmd/gomobile/doc.go
View File

@ -106,8 +106,8 @@ are copied into the output.
Flag -iosversion sets the minimal version of the iOS SDK to compile against.
The default version is 6.1.
The -bundleid flag is for -target ios only and sets the bundle ID to use
with the app; defaults to "org.golang.todo".
The -bundleid flag is required for -target ios and sets the bundle ID to use
with the app.
The -o flag specifies the output file name. If not specified, the
output file name depends on the package built.