From 6fa95d984e88af20c7b8869192a2345dc560fdbf Mon Sep 17 00:00:00 2001 From: Junda Liu Date: Thu, 6 Jun 2019 13:07:05 -0700 Subject: [PATCH] bind: keep package function comments in java file previously package level function comments are ignored. this change keeps the comment in generated java files Change-Id: I86dcd93b1026c4455d2c4782cbc9f30b514b3107 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/181038 Reviewed-by: Hyang-Ah Hana Kim --- bind/genjava.go | 1 + bind/testdata/doc.java.golden | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/bind/genjava.go b/bind/genjava.go index d4d6eb0..e5d31de 100644 --- a/bind/genjava.go +++ b/bind/genjava.go @@ -1655,6 +1655,7 @@ func (g *JavaGen) GenJava() error { g.Printf("// skipped function %s with unsupported parameter or return types\n\n", f.Name()) continue } + g.javadoc(g.docs[f.Name()].Doc()) g.Printf("public static native ") g.genFuncSignature(f, nil, false) } diff --git a/bind/testdata/doc.java.golden b/bind/testdata/doc.java.golden index 8a2ac77..90172e7 100644 --- a/bind/testdata/doc.java.golden +++ b/bind/testdata/doc.java.golden @@ -308,6 +308,12 @@ public abstract class Doc { */ public static native String getV(); + /** + * F is a function. + */ public static native void f(); + /** + * NewS is a constructor. + */ public static native S newS(); }