2015-08-26 12:28:14 -04:00
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
package bind
|
|
|
|
|
|
|
|
import (
|
mobile/bind: replace seq serialization with direct calls
The seq serialization machinery is a historic artifact from when Go
mobile code had to run in a separate process. Now that Go code is running
in-process, replace the explicit serialization with direct calls and pass
arguments on the stack.
The benefits are a much smaller bind runtime, much less garbage (and, in
Java, fewer objects with finalizers), less argument copying, and faster
cross-language calls.
The cost is a more complex generator, because some of the work from the
bind runtime is moved to generated code. Generated code now handles
conversion between Go and Java/ObjC types, multiple return values and memory
management of byte slice and string arguments.
To overcome the lack of calling C code between Go packages, all bound
packages now end up in the same (fake) package, "gomobile_bind", instead of
separate packages (go_<pkgname>). To avoid name clashes, the package name is
added as a prefix to generated functions and types.
Also, don't copy byte arrays passed to Go, saving call time and
allowing read([]byte)-style interfaces to foreign callers (#12113).
Finally, add support for nil interfaces and struct pointers to objc.
This is a large CL, but most of the changes stem from changing testdata.
The full benchcmp output on the CL/20095 benchmarks on my Nexus 5 is
reproduced below. Note that the savings for the JavaSlice* benchmarks are
skewed because byte slices are no longer copied before passing them to Go.
benchmark old ns/op new ns/op delta
BenchmarkJavaEmpty 26.0 19.0 -26.92%
BenchmarkJavaEmptyDirect 23.0 22.0 -4.35%
BenchmarkJavaNoargs 7685 2339 -69.56%
BenchmarkJavaNoargsDirect 17405 8041 -53.80%
BenchmarkJavaOnearg 26887 2366 -91.20%
BenchmarkJavaOneargDirect 34266 7910 -76.92%
BenchmarkJavaOneret 38325 2245 -94.14%
BenchmarkJavaOneretDirect 46265 7708 -83.34%
BenchmarkJavaManyargs 41720 2535 -93.92%
BenchmarkJavaManyargsDirect 51026 8373 -83.59%
BenchmarkJavaRefjava 38139 21260 -44.26%
BenchmarkJavaRefjavaDirect 42706 28150 -34.08%
BenchmarkJavaRefgo 34403 6843 -80.11%
BenchmarkJavaRefgoDirect 40193 16582 -58.74%
BenchmarkJavaStringShort 32366 9323 -71.20%
BenchmarkJavaStringShortDirect 41973 19118 -54.45%
BenchmarkJavaStringLong 127879 94420 -26.16%
BenchmarkJavaStringLongDirect 133776 114760 -14.21%
BenchmarkJavaStringShortUnicode 32562 9221 -71.68%
BenchmarkJavaStringShortUnicodeDirect 41464 19094 -53.95%
BenchmarkJavaStringLongUnicode 131015 89401 -31.76%
BenchmarkJavaStringLongUnicodeDirect 134130 90786 -32.31%
BenchmarkJavaSliceShort 42462 7538 -82.25%
BenchmarkJavaSliceShortDirect 52940 17017 -67.86%
BenchmarkJavaSliceLong 138391 8466 -93.88%
BenchmarkJavaSliceLongDirect 205804 15666 -92.39%
BenchmarkGoEmpty 3.00 3.00 +0.00%
BenchmarkGoEmptyDirect 3.00 3.00 +0.00%
BenchmarkGoNoarg 40342 13716 -66.00%
BenchmarkGoNoargDirect 46691 13569 -70.94%
BenchmarkGoOnearg 43529 13757 -68.40%
BenchmarkGoOneargDirect 44867 14078 -68.62%
BenchmarkGoOneret 45456 13559 -70.17%
BenchmarkGoOneretDirect 44694 13442 -69.92%
BenchmarkGoRefjava 55111 28071 -49.06%
BenchmarkGoRefjavaDirect 60883 26872 -55.86%
BenchmarkGoRefgo 57038 29223 -48.77%
BenchmarkGoRefgoDirect 56153 27812 -50.47%
BenchmarkGoManyargs 67967 17398 -74.40%
BenchmarkGoManyargsDirect 60617 16998 -71.96%
BenchmarkGoStringShort 57538 22600 -60.72%
BenchmarkGoStringShortDirect 52627 22704 -56.86%
BenchmarkGoStringLong 128485 52530 -59.12%
BenchmarkGoStringLongDirect 138377 52079 -62.36%
BenchmarkGoStringShortUnicode 57062 22994 -59.70%
BenchmarkGoStringShortUnicodeDirect 62563 22938 -63.34%
BenchmarkGoStringLongUnicode 139913 55553 -60.29%
BenchmarkGoStringLongUnicodeDirect 150863 57791 -61.69%
BenchmarkGoSliceShort 59279 20215 -65.90%
BenchmarkGoSliceShortDirect 60160 21136 -64.87%
BenchmarkGoSliceLong 411225 301870 -26.59%
BenchmarkGoSliceLongDirect 399029 298915 -25.09%
Fixes golang/go#12619
Fixes golang/go#12113
Fixes golang/go#13033
Change-Id: I2b45e9e98a1248e3c23a5137f775f7364908bec7
Reviewed-on: https://go-review.googlesource.com/19821
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2016-02-12 18:50:33 +01:00
|
|
|
"fmt"
|
2015-08-26 12:28:14 -04:00
|
|
|
"go/types"
|
|
|
|
"log"
|
2016-09-16 19:19:01 +02:00
|
|
|
"strings"
|
2015-08-26 12:28:14 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
type ifaceSummary struct {
|
|
|
|
iface *types.Interface
|
|
|
|
callable []*types.Func
|
|
|
|
implementable bool
|
|
|
|
}
|
|
|
|
|
|
|
|
func makeIfaceSummary(iface *types.Interface) ifaceSummary {
|
|
|
|
summary := ifaceSummary{
|
|
|
|
iface: iface,
|
|
|
|
implementable: true,
|
|
|
|
}
|
|
|
|
methodset := types.NewMethodSet(iface)
|
|
|
|
for i := 0; i < methodset.Len(); i++ {
|
|
|
|
obj := methodset.At(i).Obj()
|
|
|
|
if !obj.Exported() {
|
|
|
|
summary.implementable = false
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
m, ok := obj.(*types.Func)
|
|
|
|
if !ok {
|
|
|
|
log.Panicf("unexpected methodset obj: %s (%T)", obj, obj)
|
|
|
|
}
|
|
|
|
if !isImplementable(m.Type().(*types.Signature)) {
|
|
|
|
summary.implementable = false
|
|
|
|
}
|
|
|
|
if isCallable(m) {
|
|
|
|
summary.callable = append(summary.callable, m)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return summary
|
|
|
|
}
|
|
|
|
|
|
|
|
func isCallable(t *types.Func) bool {
|
|
|
|
// TODO(crawshaw): functions that are not implementable from
|
|
|
|
// another language may still be callable (for example, a
|
|
|
|
// returned value with an unexported type can be treated as
|
|
|
|
// an opaque value by the caller). This restriction could be
|
|
|
|
// lifted.
|
|
|
|
return isImplementable(t.Type().(*types.Signature))
|
|
|
|
}
|
|
|
|
|
|
|
|
func isImplementable(sig *types.Signature) bool {
|
|
|
|
params := sig.Params()
|
|
|
|
for i := 0; i < params.Len(); i++ {
|
|
|
|
if !isExported(params.At(i).Type()) {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
res := sig.Results()
|
|
|
|
for i := 0; i < res.Len(); i++ {
|
|
|
|
if !isExported(res.At(i).Type()) {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
func exportedMethodSet(T types.Type) []*types.Func {
|
|
|
|
var methods []*types.Func
|
|
|
|
methodset := types.NewMethodSet(T)
|
|
|
|
for i := 0; i < methodset.Len(); i++ {
|
|
|
|
obj := methodset.At(i).Obj()
|
|
|
|
if !obj.Exported() {
|
|
|
|
continue
|
|
|
|
}
|
2016-09-13 06:11:15 +02:00
|
|
|
// Skip methods from the embedded classes, so that
|
2016-09-16 19:19:01 +02:00
|
|
|
// only methods that are implemented in Go are included.
|
2016-09-13 06:11:15 +02:00
|
|
|
if pref := pkgFirstElem(obj.Pkg()); pref == "Java" || pref == "ObjC" {
|
2016-09-16 19:19:01 +02:00
|
|
|
continue
|
|
|
|
}
|
2015-08-26 12:28:14 -04:00
|
|
|
switch obj := obj.(type) {
|
|
|
|
case *types.Func:
|
|
|
|
methods = append(methods, obj)
|
|
|
|
default:
|
|
|
|
log.Panicf("unexpected methodset obj: %s", obj)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return methods
|
|
|
|
}
|
|
|
|
|
|
|
|
func exportedFields(T *types.Struct) []*types.Var {
|
|
|
|
var fields []*types.Var
|
|
|
|
for i := 0; i < T.NumFields(); i++ {
|
|
|
|
f := T.Field(i)
|
|
|
|
if !f.Exported() {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
fields = append(fields, f)
|
|
|
|
}
|
|
|
|
return fields
|
|
|
|
}
|
|
|
|
|
|
|
|
func isErrorType(t types.Type) bool {
|
|
|
|
return types.Identical(t, types.Universe.Lookup("error").Type())
|
|
|
|
}
|
|
|
|
|
|
|
|
func isExported(t types.Type) bool {
|
|
|
|
if isErrorType(t) {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
switch t := t.(type) {
|
|
|
|
case *types.Basic:
|
|
|
|
return true
|
|
|
|
case *types.Named:
|
|
|
|
return t.Obj().Exported()
|
|
|
|
case *types.Pointer:
|
|
|
|
return isExported(t.Elem())
|
|
|
|
default:
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
}
|
mobile/bind: replace seq serialization with direct calls
The seq serialization machinery is a historic artifact from when Go
mobile code had to run in a separate process. Now that Go code is running
in-process, replace the explicit serialization with direct calls and pass
arguments on the stack.
The benefits are a much smaller bind runtime, much less garbage (and, in
Java, fewer objects with finalizers), less argument copying, and faster
cross-language calls.
The cost is a more complex generator, because some of the work from the
bind runtime is moved to generated code. Generated code now handles
conversion between Go and Java/ObjC types, multiple return values and memory
management of byte slice and string arguments.
To overcome the lack of calling C code between Go packages, all bound
packages now end up in the same (fake) package, "gomobile_bind", instead of
separate packages (go_<pkgname>). To avoid name clashes, the package name is
added as a prefix to generated functions and types.
Also, don't copy byte arrays passed to Go, saving call time and
allowing read([]byte)-style interfaces to foreign callers (#12113).
Finally, add support for nil interfaces and struct pointers to objc.
This is a large CL, but most of the changes stem from changing testdata.
The full benchcmp output on the CL/20095 benchmarks on my Nexus 5 is
reproduced below. Note that the savings for the JavaSlice* benchmarks are
skewed because byte slices are no longer copied before passing them to Go.
benchmark old ns/op new ns/op delta
BenchmarkJavaEmpty 26.0 19.0 -26.92%
BenchmarkJavaEmptyDirect 23.0 22.0 -4.35%
BenchmarkJavaNoargs 7685 2339 -69.56%
BenchmarkJavaNoargsDirect 17405 8041 -53.80%
BenchmarkJavaOnearg 26887 2366 -91.20%
BenchmarkJavaOneargDirect 34266 7910 -76.92%
BenchmarkJavaOneret 38325 2245 -94.14%
BenchmarkJavaOneretDirect 46265 7708 -83.34%
BenchmarkJavaManyargs 41720 2535 -93.92%
BenchmarkJavaManyargsDirect 51026 8373 -83.59%
BenchmarkJavaRefjava 38139 21260 -44.26%
BenchmarkJavaRefjavaDirect 42706 28150 -34.08%
BenchmarkJavaRefgo 34403 6843 -80.11%
BenchmarkJavaRefgoDirect 40193 16582 -58.74%
BenchmarkJavaStringShort 32366 9323 -71.20%
BenchmarkJavaStringShortDirect 41973 19118 -54.45%
BenchmarkJavaStringLong 127879 94420 -26.16%
BenchmarkJavaStringLongDirect 133776 114760 -14.21%
BenchmarkJavaStringShortUnicode 32562 9221 -71.68%
BenchmarkJavaStringShortUnicodeDirect 41464 19094 -53.95%
BenchmarkJavaStringLongUnicode 131015 89401 -31.76%
BenchmarkJavaStringLongUnicodeDirect 134130 90786 -32.31%
BenchmarkJavaSliceShort 42462 7538 -82.25%
BenchmarkJavaSliceShortDirect 52940 17017 -67.86%
BenchmarkJavaSliceLong 138391 8466 -93.88%
BenchmarkJavaSliceLongDirect 205804 15666 -92.39%
BenchmarkGoEmpty 3.00 3.00 +0.00%
BenchmarkGoEmptyDirect 3.00 3.00 +0.00%
BenchmarkGoNoarg 40342 13716 -66.00%
BenchmarkGoNoargDirect 46691 13569 -70.94%
BenchmarkGoOnearg 43529 13757 -68.40%
BenchmarkGoOneargDirect 44867 14078 -68.62%
BenchmarkGoOneret 45456 13559 -70.17%
BenchmarkGoOneretDirect 44694 13442 -69.92%
BenchmarkGoRefjava 55111 28071 -49.06%
BenchmarkGoRefjavaDirect 60883 26872 -55.86%
BenchmarkGoRefgo 57038 29223 -48.77%
BenchmarkGoRefgoDirect 56153 27812 -50.47%
BenchmarkGoManyargs 67967 17398 -74.40%
BenchmarkGoManyargsDirect 60617 16998 -71.96%
BenchmarkGoStringShort 57538 22600 -60.72%
BenchmarkGoStringShortDirect 52627 22704 -56.86%
BenchmarkGoStringLong 128485 52530 -59.12%
BenchmarkGoStringLongDirect 138377 52079 -62.36%
BenchmarkGoStringShortUnicode 57062 22994 -59.70%
BenchmarkGoStringShortUnicodeDirect 62563 22938 -63.34%
BenchmarkGoStringLongUnicode 139913 55553 -60.29%
BenchmarkGoStringLongUnicodeDirect 150863 57791 -61.69%
BenchmarkGoSliceShort 59279 20215 -65.90%
BenchmarkGoSliceShortDirect 60160 21136 -64.87%
BenchmarkGoSliceLong 411225 301870 -26.59%
BenchmarkGoSliceLongDirect 399029 298915 -25.09%
Fixes golang/go#12619
Fixes golang/go#12113
Fixes golang/go#13033
Change-Id: I2b45e9e98a1248e3c23a5137f775f7364908bec7
Reviewed-on: https://go-review.googlesource.com/19821
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2016-02-12 18:50:33 +01:00
|
|
|
|
|
|
|
func isRefType(t types.Type) bool {
|
|
|
|
if isErrorType(t) {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
switch t := t.(type) {
|
|
|
|
case *types.Named:
|
|
|
|
switch u := t.Underlying().(type) {
|
|
|
|
case *types.Interface:
|
|
|
|
return true
|
|
|
|
default:
|
|
|
|
panic(fmt.Sprintf("unsupported named type: %s / %T", u, u))
|
|
|
|
}
|
|
|
|
case *types.Pointer:
|
|
|
|
return isRefType(t.Elem())
|
|
|
|
default:
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
}
|
2016-09-16 19:19:01 +02:00
|
|
|
|
2016-12-07 14:24:54 +02:00
|
|
|
func isNullableType(t types.Type) bool {
|
|
|
|
return types.AssignableTo(types.Typ[types.UntypedNil].Underlying(), t) || t.String() == "string" // string is mapped to NSString*, which is nullable
|
|
|
|
}
|
|
|
|
|
2016-09-13 06:11:15 +02:00
|
|
|
func typePkgFirstElem(t types.Type) string {
|
2016-09-16 19:19:01 +02:00
|
|
|
nt, ok := t.(*types.Named)
|
|
|
|
if !ok {
|
2016-09-13 06:11:15 +02:00
|
|
|
return ""
|
|
|
|
}
|
|
|
|
return pkgFirstElem(nt.Obj().Pkg())
|
|
|
|
}
|
|
|
|
|
|
|
|
func pkgFirstElem(p *types.Package) string {
|
|
|
|
if p == nil {
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
path := p.Path()
|
|
|
|
idx := strings.Index(path, "/")
|
|
|
|
if idx == -1 {
|
2018-03-09 12:21:00 +01:00
|
|
|
return path
|
2016-09-16 19:19:01 +02:00
|
|
|
}
|
2016-09-13 06:11:15 +02:00
|
|
|
return path[:idx]
|
2016-09-16 19:19:01 +02:00
|
|
|
}
|
|
|
|
|
2016-09-13 06:11:15 +02:00
|
|
|
func isWrapperType(t types.Type) bool {
|
|
|
|
e := typePkgFirstElem(t)
|
|
|
|
return e == "Java" || e == "ObjC"
|
2016-09-16 19:19:01 +02:00
|
|
|
}
|