mirror of
https://github.com/status-im/miniupnp.git
synced 2025-02-11 13:36:42 +00:00
7d5fdf0743
_snprintf() differs from snprintf() in: * on overflow it returns -1 instead of required buffer size * on overflow it does not fill nul byte * does not accept NULL/0 as a buffer Microsoft implemented snprintf() in Visual Studio 2015 as part of UCRT. Mingw32 contains snprintf() implementation only when __USE_MINGW_ANSI_STDIO is defined. Mingw-w64 versions prior to 8.0.0. contain snprintf() implementation when __USE_MINGW_ANSI_STDIO or _UCRT is defined. Since version 8.0.0 it is always supported. Mingw-w64 defines both __MINGW32__ and __MINGW64_VERSION_MAJOR macros. Mingw32 defines only __MINGW32__. _scprintf() just count number of bytes needed for formatting string, so it is basically return value of snprintf(). This change updates miniupnpc code to use snprintf() when is provided by compiler/runtime to avoid usage _snprintf(). And also this changes updates miniupnpc emulation of snprintf() by _snprintf() and _scprintf() functions to avoid buffer overflows. For inspiration full emulation of snprintf() by _snprintf() is available in mingw-w64 stdio library: https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-crt/stdio/snprintf.c
Project: miniupnp Project web page: http://miniupnp.free.fr/ or https://miniupnp.tuxfamily.org/ github: https://github.com/miniupnp/miniupnp Author: Thomas Bernard Copyright (c) 2005-2019 Thomas Bernard This software is subject to the conditions detailed in the LICENSE file provided within this distribution. * miniUPnP Client - miniUPnPc * To compile, simply run 'gmake' (could be 'make' on your system). Under win32, to compile with MinGW, type "mingw32make.bat". MS Visual C solution and project files are supplied in the msvc/ subdirectory. The miniupnpc library is available as a static library or as a DLL : define MINIUPNP_STATICLIB if you want to link against the static library. The compilation is known to work under linux, FreeBSD, OpenBSD, MacOS X, AmigaOS and cygwin. The official AmigaOS4.1 SDK was used for AmigaOS4 and GeekGadgets for AmigaOS3. upx (http://upx.sourceforge.net) is used to compress the win32 .exe files. To install the library and headers on the system use : > su > make install > exit alternatively, to install into a specific location, use : > INSTALLPREFIX=/usr/local make install upnpc.c is a sample client using the libminiupnpc. To use the libminiupnpc in your application, link it with libminiupnpc.a (or .so) and use the following functions found in miniupnpc.h, upnpcommands.h and miniwget.h : - upnpDiscover() - UPNP_GetValidIGD() - miniwget() - parserootdesc() - GetUPNPUrls() - UPNP_* (calling UPNP methods) Note : use #include <miniupnpc/miniupnpc.h> etc... for the includes and -lminiupnpc for the link Discovery process is speeded up when MiniSSDPd is running on the machine. * Python module * you can build a python module with 'make pythonmodule' and install it with 'make installpythonmodule'. setup.py (and setupmingw32.py) are included in the distribution. Feel free to contact me if you have any problem : e-mail : miniupnp@free.fr If you are using libminiupnpc in your application, please send me an email ! For any question, you can use the web forum : https://miniupnp.tuxfamily.org/forum/ Bugs should be reported on github : https://github.com/miniupnp/miniupnp/issues * Linux firewall configuration for UPnP clients * Due to how UPnP protocol is designed, unicast responses to UPnP multicast client requests are not tracked by Linux netfilter. And therefore netfilter executes default action for them (which is in most cases DROP response packet). To workaround this limitation, custom ipset hash table can be used. It is supported since Linux kernel >= 2.6.39. Rules for IPv4: $ ipset create upnp hash:ip,port timeout 3 $ iptables -A OUTPUT -d 239.255.255.250/32 -p udp -m udp --dport 1900 -j SET --add-set upnp src,src --exist $ iptables -A INPUT -p udp -m set --match-set upnp dst,dst -j ACCEPT $ iptables -A INPUT -d 239.255.255.250/32 -p udp -m udp --dport 1900 -j ACCEPT Rules for IPv6: $ ipset create upnp6 hash:ip,port timeout 3 family inet6 $ ip6tables -A OUTPUT -d ff02::c/128 -p udp -m udp --dport 1900 -j SET --add-set upnp6 src,src --exist $ ip6tables -A OUTPUT -d ff05::c/128 -p udp -m udp --dport 1900 -j SET --add-set upnp6 src,src --exist $ ip6tables -A INPUT -p udp -m set --match-set upnp6 dst,dst -j ACCEPT $ ip6tables -A INPUT -d ff02::c/128 -p udp -m udp --dport 1900 -j ACCEPT $ ip6tables -A INPUT -d ff05::c/128 -p udp -m udp --dport 1900 -j ACCEPT Detailed description is available on: https://serverfault.com/a/911286 https://unix.stackexchange.com/a/444804