status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

nftnlrdr.c: fix writing to iaddr instead of rhost 

fixes #462
https://github.com/miniupnp/miniupnp/issues/462
https://github.com/miniupnp/miniupnp/issues/459#issuecomment-636402954
This commit is contained in:
Thomas Bernard 2020-06-01 17:56:38 +02:00
parent c3d71b97ab
commit c09f485482
No known key found for this signature in database
GPG Key ID: 0FF11B67A5C0863C
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
miniupnpd/netfilter_nft/nftnlrdr.c
View File

@ -462,9 +462,13 @@ get_peer_rule_by_index(int index,
}
if (iaddr != NULL) {
/* TODO : use inet_ntop() instead of inet_ntoa() */
/* char * inet_ntoa(struct in_addr in); */
/* const char * inet_ntop(int af, const void * restrict src, char * restrict dst, socklen_t size) */
addr.s_addr = r->iaddr;
addr_str = inet_ntoa(addr);
strncpy(iaddr , addr_str, iaddrlen);
/* inet_ntop(AF_INET, &r->iaddr, iaddr, iaddrlen) */
}
if (iport != NULL) {
@ -478,7 +482,7 @@ get_peer_rule_by_index(int index,
if (rhost != NULL) {
addr.s_addr = r->rhost;
addr_str = inet_ntoa(addr);
strncpy(iaddr , addr_str, rhostlen);
strncpy(rhost, addr_str, rhostlen);
}
if (rport != NULL) {
@ -574,7 +578,7 @@ get_redirect_rule_by_index(int index,
if (rhost != NULL) {
addr.s_addr = r->rhost;
addr_str = inet_ntoa(addr);
strncpy(iaddr , addr_str, rhostlen);
strncpy(rhost, addr_str, rhostlen);
}
if (desc != NULL && r->desc) {