From bbbbb0c95a45ec50965865823934af62b0672ea5 Mon Sep 17 00:00:00 2001 From: Thomas Bernard Date: Mon, 26 Oct 2015 11:27:10 +0100 Subject: [PATCH] minisoap.c: make soapPostSubmit() return -1 for errors --- miniupnpc/minisoap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/miniupnpc/minisoap.c b/miniupnpc/minisoap.c index d9e4358..5c9a114 100644 --- a/miniupnpc/minisoap.c +++ b/miniupnpc/minisoap.c @@ -1,7 +1,7 @@ /* $Id: minisoap.c,v 1.23 2014/11/04 22:31:55 nanard Exp $ */ /* Project : miniupnp * Author : Thomas Bernard - * Copyright (c) 2005-2014 Thomas Bernard + * Copyright (c) 2005-2015 Thomas Bernard * This software is subject to the conditions detailed in the * LICENCE file provided in this distribution. * @@ -43,10 +43,10 @@ httpWrite(int fd, const char * body, int bodysize, /* Note : my old linksys router only took into account * soap request that are sent into only one packet */ char * p; - /* TODO: AVOID MALLOC */ + /* TODO: AVOID MALLOC, we could use writev() for that */ p = malloc(headerssize+bodysize); if(!p) - return 0; + return -1; memcpy(p, headers, headerssize); memcpy(p+headerssize, body, bodysize); /*n = write(fd, p, headerssize+bodysize);*/ @@ -106,7 +106,7 @@ int soapPostSubmit(int fd, "\r\n", url, httpversion, host, portstr, bodysize, action); if ((unsigned int)headerssize >= sizeof(headerbuf)) - return 0; + return -1; #ifdef DEBUG /*printf("SOAP request : headersize=%d bodysize=%d\n", headerssize, bodysize);