From aefebb18cbdcdd0aa757c211901671bf4a5d9f87 Mon Sep 17 00:00:00 2001
From: Thomas Bernard <miniupnp@free.fr>
Date: Mon, 8 Jan 2024 00:24:07 +0100
Subject: [PATCH] miniupnpd.c: fix enforcing min_lifetime minimum of 120secs

---
 miniupnpd/miniupnpd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/miniupnpd/miniupnpd.c b/miniupnpd/miniupnpd.c
index 61ff4e0..686a338 100644
--- a/miniupnpd/miniupnpd.c
+++ b/miniupnpd/miniupnpd.c
@@ -1414,12 +1414,14 @@ init(int argc, char * * argv, struct runtime_vars * v)
 #ifdef ENABLE_PCP
 			case UPNPPCPMINLIFETIME:
 					min_lifetime = atoi(ary_options[i].value);
-					if (min_lifetime > 120 ) {
+					/* RFC6887 15. the minimum value SHOULD be 120 seconds */
+					if (min_lifetime < 120 ) {
 						min_lifetime = 120;
 					}
 				break;
 			case UPNPPCPMAXLIFETIME:
 					max_lifetime = atoi(ary_options[i].value);
+					/* maximum is 24 hours */
 					if (max_lifetime > 86400 ) {
 						max_lifetime = 86400;
 					}