status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

miniupnpd: prevent buffer overread of known_devices_types 

should fix #459
This commit is contained in:
Thomas Bernard 2020-05-29 18:01:39 +02:00
parent 47a55b27c7
commit 827fc6f041
No known key found for this signature in database
GPG Key ID: 0FF11B67A5C0863C
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
miniupnpd/minissdp.c
View File

@ -1,4 +1,4 @@
/* $Id: minissdp.c,v 1.95 2019/05/02 10:08:14 nanard Exp $ */
/* $Id: minissdp.c,v 1.99 2020/05/10 17:55:32 nanard Exp $ */
/* vim: tabstop=4 shiftwidth=4 noexpandtab
* MiniUPnP project
* http://miniupnp.free.fr/ or https://miniupnp.tuxfamily.org/
@ -798,7 +798,8 @@ SendSSDPNotifies(int s, const char * host, unsigned short http_port,
known_service_types[i].s, /* ver_str, USN: */
lifetime);
/* for devices, also send NOTIFY on the uuid */
if(0==memcmp(known_service_types[i].s,
if(i > 0 && /* only known_service_types[0].s is shorter than "urn:schemas-upnp-org:device" */
0==memcmp(known_service_types[i].s,
"urn:schemas-upnp-org:device", sizeof("urn:schemas-upnp-org:device")-1)) {
SendSSDPNotify(s, (struct sockaddr *)&sockname, sockname_len, dest_str,
host, http_port,