From 7aeb624b44f86d335841242ff427433190e7168a Mon Sep 17 00:00:00 2001 From: Thomas Bernard Date: Mon, 11 Dec 2017 14:27:27 +0100 Subject: [PATCH] properly initialize data structure for SOAP parsing in ParseNameValue() topelt field was not properly initialized. should fix #268 --- miniupnpc/upnpreplyparse.c | 9 ++++----- miniupnpd/upnpreplyparse.c | 9 ++++----- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/miniupnpc/upnpreplyparse.c b/miniupnpc/upnpreplyparse.c index 5de5796..ae84b0b 100644 --- a/miniupnpc/upnpreplyparse.c +++ b/miniupnpc/upnpreplyparse.c @@ -1,7 +1,8 @@ /* $Id: upnpreplyparse.c,v 1.19 2015/07/15 10:29:11 nanard Exp $ */ -/* MiniUPnP project +/* vim: tabstop=4 shiftwidth=4 noexpandtab + * MiniUPnP project * http://miniupnp.free.fr/ or http://miniupnp.tuxfamily.org/ - * (c) 2006-2015 Thomas Bernard + * (c) 2006-2017 Thomas Bernard * This software is subject to the conditions detailed * in the LICENCE file provided within the distribution */ @@ -104,9 +105,7 @@ ParseNameValue(const char * buffer, int bufsize, struct NameValueParserData * data) { struct xmlparser parser; - data->l_head = NULL; - data->portListing = NULL; - data->portListingLength = 0; + memset(data, 0, sizeof(struct NameValueParserData)); /* init xmlparser object */ parser.xmlstart = buffer; parser.xmlsize = bufsize; diff --git a/miniupnpd/upnpreplyparse.c b/miniupnpd/upnpreplyparse.c index 5de5796..ae84b0b 100644 --- a/miniupnpd/upnpreplyparse.c +++ b/miniupnpd/upnpreplyparse.c @@ -1,7 +1,8 @@ /* $Id: upnpreplyparse.c,v 1.19 2015/07/15 10:29:11 nanard Exp $ */ -/* MiniUPnP project +/* vim: tabstop=4 shiftwidth=4 noexpandtab + * MiniUPnP project * http://miniupnp.free.fr/ or http://miniupnp.tuxfamily.org/ - * (c) 2006-2015 Thomas Bernard + * (c) 2006-2017 Thomas Bernard * This software is subject to the conditions detailed * in the LICENCE file provided within the distribution */ @@ -104,9 +105,7 @@ ParseNameValue(const char * buffer, int bufsize, struct NameValueParserData * data) { struct xmlparser parser; - data->l_head = NULL; - data->portListing = NULL; - data->portListingLength = 0; + memset(data, 0, sizeof(struct NameValueParserData)); /* init xmlparser object */ parser.xmlstart = buffer; parser.xmlsize = bufsize;