From 55099d5fc6d20433885fc9d7546d8638efd213d1 Mon Sep 17 00:00:00 2001 From: Thomas Bernard Date: Mon, 19 Aug 2013 18:25:54 +0200 Subject: [PATCH] upnpsoap.c: adding TODO... to be done later for compliance --- miniupnpd/upnpsoap.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/miniupnpd/upnpsoap.c b/miniupnpd/upnpsoap.c index b954a35..a8023c0 100644 --- a/miniupnpd/upnpsoap.c +++ b/miniupnpd/upnpsoap.c @@ -1,4 +1,4 @@ -/* $Id: upnpsoap.c,v 1.118 2013/06/13 13:21:30 nanard Exp $ */ +/* $Id: upnpsoap.c,v 1.119 2013/08/19 16:16:00 nanard Exp $ */ /* MiniUPnP project * http://miniupnp.free.fr/ or http://miniupnp.tuxfamily.org/ * (c) 2006-2013 Thomas Bernard @@ -410,6 +410,14 @@ AddPortMapping(struct upnphttp * h, const char * action) action, eport, int_ip, iport, protocol, desc, leaseduration, r_host ? r_host : "NULL"); + /* TODO : be compliant with IGD spec for updating existing port mappings. + See "WANIPConnection:1 Service Template Version 1.01" 2.2.20.PortMappingDescription : + Overwriting Previous / Existing Port Mappings: + If the RemoteHost, ExternalPort, PortMappingProtocol and InternalClient are + exactly the same as an existing mapping, the existing mapping values for InternalPort, + PortMappingDescription, PortMappingEnabled and PortMappingLeaseDuration are + overwritten. + */ r = upnp_redirect(r_host, eport, int_ip, iport, protocol, desc, leaseduration); ClearNameValueList(&data);