status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add IPv4 permission check into PCP MAP operation

This commit is contained in:
Peter Tatrai 2013-07-22 10:48:17 +02:00 committed by Peter Tatrai
parent 3f85c8b859
commit 4bdec457a2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
miniupnpd/pcpserver.c
View File

@ -833,7 +833,7 @@ static void CreatePCPMap(pcp_info_t *pcp_msg_info)
if(r==0) {
if((strncmp(pcp_msg_info->senderaddrstr, iaddr_old,
sizeof(iaddr_old))!=0)
sizeof(iaddr_old))!=0)
|| (pcp_msg_info->int_port != iport_old)) {
/* redirection already existing */
if (pcp_msg_info->pfailure_present) {
@ -850,7 +850,12 @@ static void CreatePCPMap(pcp_info_t *pcp_msg_info)
}
} while (r==0);
if (pcp_msg_info->ext_port == 0) {
if ((pcp_msg_info->ext_port == 0) ||
(IN6_IS_ADDR_V4MAPPED(pcp_msg_info->int_ip) &&
(!check_upnp_rule_against_permissions(upnppermlist,
num_upnpperm, pcp_msg_info->ext_port,
((struct in_addr*)pcp_msg_info->int_ip->s6_addr)[3],
pcp_msg_info->int_port)))) {
pcp_msg_info->result_code = PCP_ERR_CANNOT_PROVIDE_EXTERNAL;
return;
}