Add clean_pinehole_list() in pfpinhole

miniupnpd/pf/pfpinhole.c

@@ -1,7 +1,7 @@
-/* $Id: pfpinhole.c,v 1.9 2012/04/20 22:07:28 nanard Exp $ */
+/* $Id: pfpinhole.c,v 1.11 2012/04/21 23:31:31 nanard Exp $ */
 /* MiniUPnP project
  * http://miniupnp.free.fr/ or http://miniupnp.tuxfamily.org/
- * (c) 2006-2012 Thomas Bernard
+ * (c) 2012 Thomas Bernard
  * This software is subject to the conditions detailed
  * in the LICENCE file provided within the distribution */
 
@@ -43,13 +43,16 @@
 /* /dev/pf when opened */
 extern int dev;
 
-static int uid = 1;
+static int next_uid = 1;
+
+#define PINEHOLE_LABEL_FORMAT "pinhole-%d ts-%u"
 
 int add_pinhole(const char * ifname,
                 const char * rem_host, unsigned short rem_port,
                 const char * int_client, unsigned short int_port,
                 int proto, unsigned int timestamp)
 {
+	int uid;
 	struct pfioc_rule pcr;
 #ifndef PF_NEWSTYLE
 	struct pfioc_pooladdr pp;
@@ -99,8 +102,9 @@ int add_pinhole(const char * ifname,
 		pcr.rule.onrdomain = -1;	/* first appeared in OpenBSD 5.0 */
 #endif
 		pcr.rule.keep_state = 1;
+		uid = next_uid;
 		snprintf(pcr.rule.label, PF_RULE_LABEL_SIZE,
-		         "pinhole-%d ts-%u", uid, timestamp);
+		         PINEHOLE_LABEL_FORMAT, uid, timestamp);
 		if(queue)
 			strlcpy(pcr.rule.qname, queue, PF_QNAME_SIZE);
 		if(tag)
@@ -142,7 +146,10 @@ int add_pinhole(const char * ifname,
 		}
 	}
 
-	return (uid++);
+	if(++next_uid >= 65535) {
+		next_uid = 1;
+	}
+	return uid;
 }
 
 int delete_pinhole(unsigned short uid)
@@ -249,5 +256,81 @@ int get_pinhole(unsigned short uid,
 	return -1;
 }
 
+int clean_pinehole_list(unsigned int * next_timestamp)
+{
+	int i;
+	struct pfioc_rule pr;
+	time_t current_time;
+	unsigned int ts;
+	int uid;
+	unsigned int min_ts = UINT_MAX;
+	int min_uid = INT_MAX, max_uid = -1;
+
+	if(dev<0) {
+		syslog(LOG_ERR, "pf device is not open");
+		return -1;
+	}
+	current_time = time(NULL);
+	memset(&pr, 0, sizeof(pr));
+	strlcpy(pr.anchor, anchor_name, MAXPATHLEN);
+#ifndef PF_NEWSTYLE
+	pr.rule.action = PF_PASS;
+#endif
+	if(ioctl(dev, DIOCGETRULES, &pr) < 0) {
+		syslog(LOG_ERR, "ioctl(dev, DIOCGETRULES, ...): %m");
+		return -1;
+	}
+	for(i = pr.nr - 1; i >= 0; i--) {
+		pr.nr = i;
+		if(ioctl(dev, DIOCGETRULE, &pr) < 0) {
+			syslog(LOG_ERR, "ioctl(dev, DIOCGETRULE): %m");
+			return -1;
+		}
+		if(sscanf(pr.rule.label, PINEHOLE_LABEL_FORMAT, &uid, &ts) != 2) {
+			syslog(LOG_INFO, "rule with label '%s' is not a IGD pinhole", pr.rule.label);
+			continue;
+		}
+		if(ts <= current_time) {
+			syslog(LOG_INFO, "removing expired pinhole '%s'", pr.rule.label);
+			pr.action = PF_CHANGE_GET_TICKET;
+			if(ioctl(dev, DIOCCHANGERULE, &pr) < 0) {
+				syslog(LOG_ERR, "ioctl(dev, DIOCCHANGERULE, ...) PF_CHANGE_GET_TICKET: %m");
+				return -1;
+			}
+			pr.action = PF_CHANGE_REMOVE;
+			pr.nr = i;
+			if(ioctl(dev, DIOCCHANGERULE, &pr) < 0) {
+				syslog(LOG_ERR, "ioctl(dev, DIOCCHANGERULE, ...) PF_CHANGE_REMOVE: %m");
+				return -1;
+			}
+#ifndef PF_NEWSTYLE
+			pr.rule.action = PF_PASS;
+#endif
+			if(ioctl(dev, DIOCGETRULES, &pr) < 0) {
+				syslog(LOG_ERR, "ioctl(dev, DIOCGETRULES, ...): %m");
+				return -1;
+			}
+		} else {
+			if(uid > max_uid)
+				max_uid = uid;
+			else if(uid < min_uid)
+				min_uid = uid;
+			if(ts < min_ts)
+				min_ts = ts;
+		}
+	}
+	if(next_timestamp)
+		*next_timestamp = min_ts;
+	if(max_uid > 0) {
+		if(((min_uid - 32000) <= next_uid) && (next_uid <= max_uid)) {
+			next_uid = max_uid + 1;
+		}
+		if(next_uid >= 65535) {
+			next_uid = 1;
+		}
+	}
+	return 0;
+}
+
 #endif /* ENABLE_IPV6 */
 

miniupnpd/pf/pfpinhole.h

@@ -1,4 +1,4 @@
-/* $Id: pfpinhole.h,v 1.4 2012/04/20 21:49:13 nanard Exp $ */
+/* $Id: pfpinhole.h,v 1.5 2012/04/21 23:25:18 nanard Exp $ */
 /* MiniUPnP project
  * http://miniupnp.free.fr/ or http://miniupnp.tuxfamily.org/
  * (c) 2012 Thomas Bernard
@@ -20,5 +20,7 @@ int get_pinhole(unsigned short uid,
                 char * int_client, int int_clientlen, unsigned short * int_port,
                 int * proto, unsigned int * timestamp);
 
+int clean_pinehole_list(unsigned int * next_timestamp);
+
 #endif
 

miniupnpd/pf/testpfpinhole.c

@@ -1,7 +1,7 @@
-/* $Id: testpfpinhole.c,v 1.6 2012/04/20 21:49:13 nanard Exp $ */
+/* $Id: testpfpinhole.c,v 1.8 2012/04/21 23:31:31 nanard Exp $ */
 /* MiniUPnP project
  * http://miniupnp.free.fr/ or http://miniupnp.tuxfamily.org/
- * (c) 2006-2012 Thomas Bernard
+ * (c) 2012 Thomas Bernard
  * This software is subject to the conditions detailed
  * in the LICENCE file provided within the distribution */
 
@@ -73,6 +73,7 @@ int main(int argc, char * *argv)
 
 	print_pinhole(1);
 	print_pinhole(2);
+	clean_pinehole_list(NULL);
 
 	ret = delete_pinhole(1);
 	printf("delete_pinhole() returned %d\n", ret);