status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

IGD_V2: Send byebye before sending the intial ssdp:alive 

fixes #697

http://upnp.org/specs/gw/UPnP-gw-WANIPConnection-v2-Service.pdf
p9:
1.2 Changes since WANIPConnection:1

Upon startup, UPnP IGD DCP MUST broadcast an ssdp:byebye before sending the initial
ssdp:alive onto the local network. Sending an ssdp:byebye as part of the normal start up process
for a UPnP device ensures that UPnP control points with information about the previous device
instance will safely discard state information about the previous device instance before
communicating with the new device instance.
This commit is contained in:
Thomas Bernard 2024-05-08 19:30:50 +02:00
parent c0a50ce33e
commit 3ab526b665
No known key found for this signature in database
GPG Key ID: DB511043A31ACAAF
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
miniupnpd/miniupnpd.c
View File

@ -2421,6 +2421,28 @@ main(int argc, char * * argv)
return 1;
}
#if defined(UPNP_STRICT) && defined(IGD_V2)
/* WANIPConnection:2 Service p9 :
* Upon startup, UPnP IGD DCP MUST broadcast an ssdp:byebye before
* sending the initial ssdp:alive onto the local network. Sending an
* ssdp:byebye as part of the normal start up process for a UPnP
* device ensures that UPnP control points with information about the
* previous device instance will safely discard state information
* about the previous device instance before communicating with the
* new device instance. */
if (GETFLAG(ENABLEUPNPMASK))
{
#ifndef ENABLE_IPV6
if(SendSSDPGoodbye(snotify, addr_count) < 0)
#else
if(SendSSDPGoodbye(snotify, addr_count * 2) < 0)
#endif
{
syslog(LOG_WARNING, "Failed to broadcast good-bye notifications");
}
}
#endif /* UPNP_STRICT */
#ifdef USE_IFACEWATCHER
/* open socket for kernel notifications about new network interfaces */
if (sudp >= 0)