status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #57 from razzfazz/natpmp_avoid_port_zero 

miniupnpd/natpmp.c: skip port zero when finding free eport
This commit is contained in:
Thomas BERNARD 2014-03-08 01:03:43 +01:00
parent 69643d377c 1db670d6ff
commit 0ff8e67c26
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
miniupnpd/natpmp.c
View File

@ -281,6 +281,7 @@ void ProcessIncomingNATPMPPacket(int s, unsigned char *msg_buff, int len,
while(resp[3] == 0) { while(resp[3] == 0) {
if(!check_upnp_rule_against_permissions(upnppermlist, num_upnpperm, eport, senderaddr->sin_addr, iport)) { if(!check_upnp_rule_against_permissions(upnppermlist, num_upnpperm, eport, senderaddr->sin_addr, iport)) {
eport++; eport++;
if(eport == 0) eport++; /* skip port zero */
if(eport == eport_first) { /* no external port available */ if(eport == eport_first) { /* no external port available */
syslog(LOG_ERR, "Failed to find available eport for NAT-PMP %hu %s->%s:%hu", syslog(LOG_ERR, "Failed to find available eport for NAT-PMP %hu %s->%s:%hu",
eport, (proto==IPPROTO_TCP)?"tcp":"udp", senderaddrstr, iport); eport, (proto==IPPROTO_TCP)?"tcp":"udp", senderaddrstr, iport);
@ -305,6 +306,7 @@ void ProcessIncomingNATPMPPacket(int s, unsigned char *msg_buff, int len,
} }
} else { } else {
eport++; eport++;
if(eport == 0) eport++; /* skip port zero */
if(eport == eport_first) { /* no external port available */ if(eport == eport_first) { /* no external port available */
syslog(LOG_ERR, "Failed to find available eport for NAT-PMP %hu %s->%s:%hu", syslog(LOG_ERR, "Failed to find available eport for NAT-PMP %hu %s->%s:%hu",
eport, (proto==IPPROTO_TCP)?"tcp":"udp", senderaddrstr, iport); eport, (proto==IPPROTO_TCP)?"tcp":"udp", senderaddrstr, iport);