status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

miniupnpd/pcpserver.c: check source address of PCP request

This commit is contained in:
Thomas Bernard 2014-03-24 15:03:12 +01:00
parent d233655630
commit 0decb351e9
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
miniupnpd/pcpserver.c
View File

@ -1,4 +1,4 @@
/* $Id: pcpserver.c,v 1.25 2014/03/24 11:13:04 nanard Exp $ */
/* $Id: pcpserver.c,v 1.26 2014/03/24 13:08:52 nanard Exp $ */
/* MiniUPnP project
* Website : http://miniupnp.free.fr/
* Author : Peter Tatrai
@ -1390,9 +1390,8 @@ int ProcessIncomingPCPPacket(int s, unsigned char *buff, int len,
const struct sockaddr * senderaddr)
{
pcp_info_t pcp_msg_info;
#ifdef DEBUG
struct lan_addr_s * lan_addr;
char addr_str[64];
#endif
memset(&pcp_msg_info, 0, sizeof(pcp_info_t));
@ -1405,17 +1404,22 @@ int ProcessIncomingPCPPacket(int s, unsigned char *buff, int len,
syslog(LOG_ERR, "inet_ntop(pcpserver): %m");
}
}
#ifdef DEBUG
if(sockaddr_to_string(senderaddr, addr_str, sizeof(addr_str)))
syslog(LOG_DEBUG, "PCP request received from %s %dbytes",
addr_str, len);
#endif
if(buff[1] & 128) {
/* discarding PCP responses silently */
return 0;
}
lan_addr = get_lan_for_peer(senderaddr);
if(lan_addr == NULL) {
syslog(LOG_WARNING, "SSDP packet sender %s not from a LAN, ignoring",
addr_str);
return 0;
}
if (processPCPRequest(buff, len, &pcp_msg_info) ) {
createPCPResponse(buff, &pcp_msg_info);