status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

obsdrdr.c: fixes to 6e8b02b715 

two missing `break` statements, a missed goto and a missed return -1
see https://github.com/miniupnp/miniupnp/pull/674#issuecomment-1877957466
This commit is contained in:
Thomas Bernard 2024-01-06 20:11:42 +01:00
parent d135bd3f6d
commit 0206bc0051
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
miniupnpd/pf/obsdrdr.c
View File

@ -2,7 +2,7 @@
/* vim: tabstop=4 shiftwidth=4 noexpandtab
* MiniUPnP project
* http://miniupnp.free.fr/ or https://miniupnp.tuxfamily.org/
* (c) 2006-2023 Thomas Bernard
* (c) 2006-2024 Thomas Bernard
* This software is subject to the conditions detailed
* in the LICENCE file provided within the distribution */
@ -984,6 +984,7 @@ get_redirect_rule(const char * ifname, unsigned short eport, int proto,
if(timestamp)
*timestamp = get_timestamp(eport, proto);
r = 0;
break;
}
}
release_ticket(dev, tnum);
@ -1134,6 +1135,7 @@ priv_delete_redirect_rule_check_desc(const char * ifname, unsigned short eport,
}
remove_timestamp_entry(eport, proto);
r = 0;
break;
}
}
if (r == -2)
@ -1174,7 +1176,7 @@ priv_delete_filter_rule(const char * ifname, unsigned short iport,
if(ioctl(dev, DIOCGETRULES, &pr) < 0)
{
syslog(LOG_ERR, "ioctl(dev, DIOCGETRULES, ...): %m");
goto error;
return -1;
}
n = pr.nr;
#ifdef PF_RELEASETICKETS
@ -1225,7 +1227,7 @@ syslog(LOG_DEBUG, "%2d port=%hu proto=%d addr=%8x",
if (r == -2)
syslog(LOG_NOTICE, "could not find filter rule to delete iport=%hu addr=%8x", iport, ntohl(iaddr));
release_ticket(dev, tnum);
return -1;
return r;
#endif
}