migrate/util_test.go
Erik Dubbelboer eb7d0dd6a1 Fix in the URL parser with go 1.12.8 and github.com/go-sql-driver/mysql (#265)
* Fix in the URL parser with go 1.12.8 and github.com/go-sql-driver/mysql

Change schemeFromURL to just split the url by :// to find the scheme.
It's not required to parse the whole URL. MySQL DSNs aren't valid URLs.

Fixes #264

* The mysql driver itself also used net/url.Parse

* Also fix TestPasswordUnencodedReservedURLChars

* Keep backwards compatibility with url encoded username and passwords

* Fix suggestions

* Reuse old function names
2019-08-16 23:09:12 -07:00

135 lines
2.6 KiB
Go

package migrate
import (
"errors"
nurl "net/url"
"testing"
)
func TestSuintPanicsWithNegativeInput(t *testing.T) {
defer func() {
if r := recover(); r == nil {
t.Fatal("expected suint to panic for -1")
}
}()
suint(-1)
}
func TestSuint(t *testing.T) {
if u := suint(0); u != 0 {
t.Fatalf("expected 0, got %v", u)
}
}
func TestFilterCustomQuery(t *testing.T) {
n, err := nurl.Parse("foo://host?a=b&x-custom=foo&c=d")
if err != nil {
t.Fatal(err)
}
nx := FilterCustomQuery(n).Query()
if nx.Get("x-custom") != "" {
t.Fatalf("didn't expect x-custom")
}
}
func TestSourceSchemeFromUrlSuccess(t *testing.T) {
urlStr := "protocol://path"
expected := "protocol"
u, err := sourceSchemeFromURL(urlStr)
if err != nil {
t.Fatalf("expected no error, but received %q", err)
}
if u != expected {
t.Fatalf("expected %q, but received %q", expected, u)
}
}
func TestSourceSchemeFromUrlFailure(t *testing.T) {
cases := []struct {
name string
urlStr string
expectErr error
}{
{
name: "Empty",
urlStr: "",
expectErr: errors.New("source: URL cannot be empty"),
},
{
name: "NoScheme",
urlStr: "hello",
expectErr: errors.New("source: no scheme"),
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
_, err := sourceSchemeFromURL(tc.urlStr)
if err.Error() != tc.expectErr.Error() {
t.Fatalf("expected %q, but received %q", tc.expectErr, err)
}
})
}
}
func TestDatabaseSchemeFromUrlSuccess(t *testing.T) {
cases := []struct {
name string
urlStr string
expected string
}{
{
name: "Simple",
urlStr: "protocol://path",
expected: "protocol",
},
{
// See issue #264
name: "MySQLWithPort",
urlStr: "mysql://user:pass@tcp(host:1337)/db",
expected: "mysql",
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
u, err := databaseSchemeFromURL(tc.urlStr)
if err != nil {
t.Fatalf("expected no error, but received %q", err)
}
if u != tc.expected {
t.Fatalf("expected %q, but received %q", tc.expected, u)
}
})
}
}
func TestDatabaseSchemeFromUrlFailure(t *testing.T) {
cases := []struct {
name string
urlStr string
expectErr error
}{
{
name: "Empty",
urlStr: "",
expectErr: errors.New("database: URL cannot be empty"),
},
{
name: "NoScheme",
urlStr: "hello",
expectErr: errors.New("database: no scheme"),
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
_, err := databaseSchemeFromURL(tc.urlStr)
if err.Error() != tc.expectErr.Error() {
t.Fatalf("expected %q, but received %q", tc.expectErr, err)
}
})
}
}