status-im
/
migrate
mirror of https://github.com/status-im/migrate.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
838 Commits 5 Branches 25 Tags 1.2 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Erik Dubbelboer eb7d0dd6a1 Fix in the URL parser with go 1.12.8 and github.com/go-sql-driver/mysql (#265) 
* Fix in the URL parser with go 1.12.8 and github.com/go-sql-driver/mysql

Change schemeFromURL to just split the url by :// to find the scheme.
It's not required to parse the whole URL. MySQL DSNs aren't valid URLs.

Fixes #264

* The mysql driver itself also used net/url.Parse

* Also fix TestPasswordUnencodedReservedURLChars

* Keep backwards compatibility with url encoded username and passwords

* Fix suggestions

* Reuse old function names
 2019-08-16 23:09:12 -07:00
Dale Hui 43e4503343 Update golangci-lint config and implore contributors to use it 
- Run golangci-lint on tests and fix found issues
 2019-03-28 18:55:12 -07:00
Dale Hui b5edb8e50c Improve error messaging when URL parsing fails 
- Improve docs around escaping/encoding reserved URL characters
    - Add tests for net/url Parse() and reserved characters to document understanding
    - Addresses: https://github.com/golang-migrate/migrate/issues/77
 2018-07-24 17:55:58 -07:00