Commit Graph

5 Commits

Author SHA1 Message Date
Alexey 95c1eda902 Straightforward deploy approach
Summary:
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->

**Summary**

As rafeca mentioned on Discord channel, `deploy` script fails. This PR is composed with intention to fix this error.

**Test plan**

- Try to deploy a new version using CircleCI config from this PR
<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->
Closes https://github.com/facebook/metro-bundler/pull/94

Reviewed By: mjesun

Differential Revision: D6405189

Pulled By: rafeca

fbshipit-source-id: 9adca768044515784474aa6f71ca6f733db5b07e
2017-11-24 07:35:55 -08:00
Alexey Kureev 8ee5385e5c Setup Continuous Delivery
Summary:
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->

**Summary**
As we discussed on Discord channel on Nov 6th, this PR adds appropriate hooks to CircleCI in order to deploy successful builds (on master branch) to `npm` using tag that has been assigned to the latest commit.

This is how deployment process should look like:
Once you want to deploy, push a new tag to master. That will trigger a deployment script on CI. [According to CircleCI documentation](https://circleci.com/docs/1.0/npm-continuous-deployment/), the best way is to use
```
npm version x.y.z
```
in order to update package version and create git tag.  Then, you can push your code using
```
git push --follow-tags
```
After successful build, a new version will be released.

<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->

**Test plan**
Not sure if there is a way to properly test it before the merge. I think the only way is to merge it in, setup NPM_TOKEN env variable and try to create a new version by running build on CI. Please, let me know if you see alternative scenarios.

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->
Closes https://github.com/facebook/metro-bundler/pull/88

Reviewed By: BYK, cpojer

Differential Revision: D6332813

Pulled By: rafeca

fbshipit-source-id: 1902afa8eb77a59e813cefc8e7f650a0106edfef
2017-11-17 03:47:46 -08:00
Jean Lauliac 84e0fe4606 Revert "attempt at fixing yarn install in CircleCI"
This reverts commit 669f432dfb.
2017-07-19 17:31:28 +01:00
Jean Lauliac 669f432dfb attempt at fixing yarn install in CircleCI 2017-07-19 15:54:12 +01:00
Christoph Pojer 52c6ba4b75 Add circle.yml
Reviewed By: davidaurelio

Differential Revision: D5190477

fbshipit-source-id: 71769400dc3b67bd0c8eec27e4e317a9eb3de1f2
2017-06-06 08:41:04 -07:00