status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Make HMR compatible with numeric IDs 

Summary:We recently refactor the packager to transform the module names into numeric IDs but we forgot to update the HMR call site. As a consequence, HMR doesn't work the first time a file is saved but the second one.

This is affecting master as of 3/20. If we don't land this before v0.23 is cut we'll have to cherry pick it. This rev does *not* need to be picked on v0.22.

Reviewed By: bestander

Differential Revision: D3075192

fb-gh-sync-id: 410e4bf8f937c0cdb8f2b462dd36f928a24e8aa8
shipit-source-id: 410e4bf8f937c0cdb8f2b462dd36f928a24e8aa8
This commit is contained in:
Martín Bigio 2016-03-21 15:50:15 -07:00 committed by Facebook Github Bot 4
parent abbc1a5157
commit ebfb4f738a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
react-packager/src/Bundler/HMRBundle.js vendored
View File

@ -34,10 +34,10 @@ class HMRBundle extends BundleBase {
return Promise.resolve();
}
getModulesNamesAndCode() {
getModulesIdsAndCode() {
return this._modules.map(module => {
return {
name: JSON.stringify(module.name),
id: JSON.stringify(module.id),
code: module.code,
};
});