status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

extract-dependencies.js: fix out-of-date comment 

Summary: We actually use the AST, not regexes. Fix comment.

Reviewed By: davidaurelio

Differential Revision: D4104797

fbshipit-source-id: e37d168bd541d9d222667d0d168aa6b6099c1275
This commit is contained in:
Jean Lauliac 2016-10-31 11:34:35 -07:00 committed by Facebook Github Bot
parent d8aab602b2
commit d60ac14fd0
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
react-packager/src/JSTransformer/worker/extract-dependencies.js vendored
View File

@ -13,13 +13,8 @@ const babylon = require('babylon');
/**
* Extracts dependencies (module IDs imported with the `require` function) from
* a string containing code.
* The function is regular expression based for speed reasons.
*
* The code is traversed twice:
* 1. An array of ranges is built, where indexes 0-1, 2-3, 4-5, etc. are code,
* and indexes 1-2, 3-4, 5-6, etc. are string literals and comments.
* 2. require calls are extracted with a regular expression.
* a string containing code. This walks the full AST for correctness (versus
* using, for example, regular expressions, that would be faster but inexact.)
*
* The result of the dependency extraction is an de-duplicated array of
* dependencies, and an array of offsets to the string literals with module IDs.