Make output types from Delta Bundler generic

Reviewed By: jeanlauliac

Differential Revision: D7894080

fbshipit-source-id: 0f560c4600b4931bcc8f32ded10a7933d1ead984

packages/metro/src/DeltaBundler.js

@@ -13,14 +13,9 @@
 const DeltaCalculator = require('./DeltaBundler/DeltaCalculator');
 
 import type Bundler from './Bundler';
-import type {
+import type {DeltaResult, Graph, Options} from './DeltaBundler/DeltaCalculator';
-  DeltaResult,
-  Graph as CalculatorGraph,
-  Options,
-} from './DeltaBundler/DeltaCalculator';
 
-export type Delta = DeltaResult;
+export type {DeltaResult, Graph} from './DeltaBundler/DeltaCalculator';
-export type Graph = CalculatorGraph;
 
 /**
  * `DeltaBundler` uses the `DeltaTransformer` to build bundle deltas. This
@@ -28,9 +23,9 @@ export type Graph = CalculatorGraph;
  * concurrent clients requesting their own deltas. This is done through the
  * `clientId` param (which maps a client to a specific delta transformer).
  */
-class DeltaBundler {
+class DeltaBundler<T> {
   _bundler: Bundler;
-  _deltaCalculators: Map<Graph, DeltaCalculator> = new Map();
+  _deltaCalculators: Map<Graph<T>, DeltaCalculator<T>> = new Map();
 
   constructor(bundler: Bundler) {
     this._bundler = bundler;
@@ -43,8 +38,8 @@ class DeltaBundler {
 
   async buildGraph(
     entryPoints: $ReadOnlyArray<string>,
-    options: Options,
+    options: Options<T>,
-  ): Promise<Graph> {
+  ): Promise<Graph<T>> {
     const depGraph = await this._bundler.getDependencyGraph();
 
     const deltaCalculator = new DeltaCalculator(entryPoints, depGraph, options);
@@ -57,7 +52,10 @@ class DeltaBundler {
     return graph;
   }
 
-  async getDelta(graph: Graph, {reset}: {reset: boolean}): Promise<Delta> {
+  async getDelta(
+    graph: Graph<T>,
+    {reset}: {reset: boolean},
+  ): Promise<DeltaResult<T>> {
     const deltaCalculator = this._deltaCalculators.get(graph);
 
     if (!deltaCalculator) {
@@ -67,7 +65,7 @@ class DeltaBundler {
     return await deltaCalculator.getDelta({reset});
   }
 
-  listen(graph: Graph, callback: () => mixed) {
+  listen(graph: Graph<T>, callback: () => mixed) {
     const deltaCalculator = this._deltaCalculators.get(graph);
 
     if (!deltaCalculator) {
@@ -77,7 +75,7 @@ class DeltaBundler {
     deltaCalculator.on('change', callback);
   }
 
-  endGraph(graph: Graph) {
+  endGraph(graph: Graph<T>) {
     const deltaCalculator = this._deltaCalculators.get(graph);
 
     if (!deltaCalculator) {

packages/metro/src/DeltaBundler/DeltaCalculator.js

@@ -20,8 +20,8 @@ const {EventEmitter} = require('events');
 import type DependencyGraph from '../node-haste/DependencyGraph';
 import type {Graph, Module, Options} from './traverseDependencies';
 
-export type DeltaResult = {|
+export type DeltaResult<T> = {|
-  +modified: Map<string, Module>,
+  +modified: Map<string, Module<T>>,
   +deleted: Set<string>,
   +reset: boolean,
 |};
@@ -34,20 +34,20 @@ export type {Graph, Options} from './traverseDependencies';
  * traverse the files that have been changed between calls and avoid having to
  * traverse the whole dependency tree for trivial small changes.
  */
-class DeltaCalculator extends EventEmitter {
+class DeltaCalculator<T> extends EventEmitter {
   _dependencyGraph: DependencyGraph;
-  _options: Options;
+  _options: Options<T>;
 
-  _currentBuildPromise: ?Promise<DeltaResult>;
+  _currentBuildPromise: ?Promise<DeltaResult<T>>;
   _deletedFiles: Set<string> = new Set();
   _modifiedFiles: Set<string> = new Set();
 
-  _graph: Graph;
+  _graph: Graph<T>;
 
   constructor(
     entryPoints: $ReadOnlyArray<string>,
     dependencyGraph: DependencyGraph,
-    options: Options,
+    options: Options<T>,
   ) {
     super();
 
@@ -87,7 +87,7 @@ class DeltaCalculator extends EventEmitter {
    * Main method to calculate the delta of modules. It returns a DeltaResult,
    * which contain the modified/added modules and the removed modules.
    */
-  async getDelta({reset}: {reset: boolean}): Promise<DeltaResult> {
+  async getDelta({reset}: {reset: boolean}): Promise<DeltaResult<T>> {
     // If there is already a build in progress, wait until it finish to start
     // processing a new one (delta server doesn't support concurrent builds).
     if (this._currentBuildPromise) {
@@ -155,7 +155,7 @@ class DeltaCalculator extends EventEmitter {
    * needed information to do the traversing (dependencies, inverseDependencies)
    * plus some metadata.
    */
-  getGraph(): Graph {
+  getGraph(): Graph<T> {
     return this._graph;
   }
 
@@ -191,7 +191,7 @@ class DeltaCalculator extends EventEmitter {
   async _getChangedDependencies(
     modifiedFiles: Set<string>,
     deletedFiles: Set<string>,
-  ): Promise<DeltaResult> {
+  ): Promise<DeltaResult<T>> {
     if (!this._graph.dependencies.size) {
       const {added} = await initialTraverseDependencies(
         this._graph,

packages/metro/src/DeltaBundler/Serializers/deltaJSBundle.js

@@ -15,7 +15,9 @@ const getAppendScripts = require('../../lib/getAppendScripts');
 const {wrapModule} = require('./helpers/js');
 const {getJsOutput, isJsModule} = require('./helpers/js');
 
-import type {Delta, Graph} from '../../DeltaBundler';
+import type {DeltaResult} from '../../DeltaBundler/DeltaCalculator';
+import type {Graph} from '../../DeltaBundler';
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {Module} from '../traverseDependencies';
 
 type Options = {|
@@ -29,10 +31,10 @@ type Options = {|
 
 function deltaJSBundle(
   entryPoint: string,
-  pre: $ReadOnlyArray<Module>,
+  pre: $ReadOnlyArray<Module<JsOutput>>,
-  delta: Delta,
+  delta: DeltaResult<JsOutput>,
   sequenceId: string,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: Options,
 ): string {
   const outputPre = [];

packages/metro/src/DeltaBundler/Serializers/getAllFiles.js

@@ -13,6 +13,7 @@
 const {getAssetFiles} = require('../../Assets');
 const {getJsOutput, isJsModule} = require('./helpers/js');
 
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {Graph} from '../DeltaCalculator';
 import type {Module} from '../traverseDependencies';
 
@@ -21,8 +22,8 @@ type Options = {|
 |};
 
 async function getAllFiles(
-  pre: $ReadOnlyArray<Module>,
+  pre: $ReadOnlyArray<Module<JsOutput>>,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: Options,
 ): Promise<$ReadOnlyArray<string>> {
   const modules = graph.dependencies;

packages/metro/src/DeltaBundler/Serializers/getAssets.js

@@ -16,6 +16,7 @@ const {getAssetData} = require('../../Assets');
 const {getJsOutput, isJsModule} = require('./helpers/js');
 
 import type {AssetData} from '../../Assets';
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {Graph} from '../DeltaCalculator';
 
 type Options = {|
@@ -25,7 +26,7 @@ type Options = {|
 |};
 
 async function getAssets(
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: Options,
 ): Promise<$ReadOnlyArray<AssetData>> {
   const promises = [];

packages/metro/src/DeltaBundler/Serializers/getRamBundleInfo.js

@@ -20,6 +20,7 @@ const {createRamBundleGroups} = require('../../Bundler/util');
 const {isJsModule, wrapModule} = require('./helpers/js');
 
 import type {GetTransformOptions} from '../../Bundler';
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {ModuleTransportLike} from '../../shared/types.flow';
 import type {Graph} from '../DeltaCalculator';
 import type {Module} from '../traverseDependencies';
@@ -45,8 +46,8 @@ export type RamBundleInfo = {|
 
 async function getRamBundleInfo(
   entryPoint: string,
-  pre: $ReadOnlyArray<Module>,
+  pre: $ReadOnlyArray<Module<JsOutput>>,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: Options,
 ): Promise<RamBundleInfo> {
   const modules = [

packages/metro/src/DeltaBundler/Serializers/helpers/getTransitiveDependencies.js

@@ -12,7 +12,10 @@
 
 import type {Graph} from '../../DeltaCalculator';
 
-function getTransitiveDependencies(path: string, graph: Graph): Set<string> {
+function getTransitiveDependencies<T>(
+  path: string,
+  graph: Graph<T>,
+): Set<string> {
   const dependencies = _getDeps(path, graph, new Set());
 
   // Remove the main entry point, since this method only returns the
@@ -22,7 +25,11 @@ function getTransitiveDependencies(path: string, graph: Graph): Set<string> {
   return dependencies;
 }
 
-function _getDeps(path: string, graph: Graph, deps: Set<string>): Set<string> {
+function _getDeps<T>(
+  path: string,
+  graph: Graph<T>,
+  deps: Set<string>,
+): Set<string> {
   if (deps.has(path)) {
     return deps;
   }

packages/metro/src/DeltaBundler/Serializers/helpers/js.js

@@ -14,6 +14,7 @@ const addParamsToDefineCall = require('../../../lib/addParamsToDefineCall');
 const invariant = require('fbjs/lib/invariant');
 const path = require('path');
 
+import type {JsOutput} from '../../../JSTransformer/worker';
 import type {Module} from '../../traverseDependencies';
 
 export type Options = {
@@ -26,7 +27,7 @@ export type Options = {
 // Make sure to set PRINT_REQUIRE_PATHS = true too, and restart Metro
 const PASS_MODULE_PATHS_TO_DEFINE = false;
 
-function wrapModule(module: Module, options: Options) {
+function wrapModule(module: Module<JsOutput>, options: Options) {
   const output = getJsOutput(module);
   if (output.type.startsWith('js/script')) {
     return output.data.code;
@@ -54,7 +55,7 @@ function wrapModule(module: Module, options: Options) {
   return addParamsToDefineCall(output.data.code, ...params);
 }
 
-function getJsOutput(module: Module) {
+function getJsOutput(module: Module<JsOutput>) {
   const jsModules = module.output.filter(({type}) => type.startsWith('js/'));
 
   invariant(
@@ -67,8 +68,10 @@ function getJsOutput(module: Module) {
   return jsModules[0];
 }
 
-function isJsModule(module: Module) {
+function isJsModule(module: Module<JsOutput>) {
-  return module.output.some(output => output.type.startsWith('js/'));
+  const jsModules = module.output.filter(({type}) => type.startsWith('js/'));
+
+  return jsModules.length > 0;
 }
 
 module.exports = {

packages/metro/src/DeltaBundler/Serializers/hmrJSBundle.js

@@ -14,7 +14,9 @@ const addParamsToDefineCall = require('../../lib/addParamsToDefineCall');
 
 const {isJsModule, wrapModule} = require('./helpers/js');
 
-import type {Delta, Graph} from '../../DeltaBundler';
+import type {DeltaResult} from '../../DeltaBundler/DeltaCalculator';
+import type {Graph} from '../../DeltaBundler';
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {Module} from '../traverseDependencies';
 
 type Options = {
@@ -30,7 +32,11 @@ export type Result = {
   },
 };
 
-function hmrJSBundle(delta: Delta, graph: Graph, options: Options): Result {
+function hmrJSBundle(
+  delta: DeltaResult<JsOutput>,
+  graph: Graph<JsOutput>,
+  options: Options,
+): Result {
   const modules = [];
 
   for (const module of delta.modified.values()) {
@@ -50,8 +56,8 @@ function hmrJSBundle(delta: Delta, graph: Graph, options: Options): Result {
 }
 
 function _prepareModule(
-  module: Module,
+  module: Module<JsOutput>,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: Options,
 ): {|+id: number, +code: string|} {
   const code = wrapModule(module, {
@@ -83,7 +89,7 @@ function _prepareModule(
  */
 function _getInverseDependencies(
   path: string,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   inverseDependencies: {[key: string]: Array<string>} = {},
 ): {[key: string]: Array<string>} {
   // Dependency alredy traversed.

packages/metro/src/DeltaBundler/Serializers/plainJSBundle.js

@@ -14,6 +14,7 @@ const getAppendScripts = require('../../lib/getAppendScripts');
 
 const {isJsModule, wrapModule} = require('./helpers/js');
 
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {Graph} from '../DeltaCalculator';
 import type {Module} from '../traverseDependencies';
 
@@ -28,8 +29,8 @@ type Options = {|
 
 function plainJSBundle(
   entryPoint: string,
-  pre: $ReadOnlyArray<Module>,
+  pre: $ReadOnlyArray<Module<JsOutput>>,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: Options,
 ): string {
   for (const module of graph.dependencies.values()) {

packages/metro/src/DeltaBundler/Serializers/sourceMapObject.js

@@ -13,13 +13,14 @@
 const {isJsModule, getJsOutput} = require('./helpers/js');
 const {fromRawMappings} = require('metro-source-map');
 
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {Graph} from '../DeltaCalculator';
 import type {Module} from '../traverseDependencies';
 import type {BabelSourceMap} from '@babel/core';
 
 function fullSourceMapObject(
-  pre: $ReadOnlyArray<Module>,
+  pre: $ReadOnlyArray<Module<JsOutput>>,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: {|+excludeSource: boolean|},
 ): BabelSourceMap {
   const modules = [...pre, ...graph.dependencies.values()]

packages/metro/src/DeltaBundler/Serializers/sourceMapString.js

@@ -13,12 +13,13 @@
 const {isJsModule, getJsOutput} = require('./helpers/js');
 const {fromRawMappings} = require('metro-source-map');
 
+import type {JsOutput} from '../../JSTransformer/worker';
 import type {Graph} from '../DeltaCalculator';
 import type {Module} from '../traverseDependencies';
 
 function fullSourceMap(
-  pre: $ReadOnlyArray<Module>,
+  pre: $ReadOnlyArray<Module<JsOutput>>,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: {|+excludeSource: boolean|},
 ): string {
   const modules = [...pre, ...graph.dependencies.values()]

packages/metro/src/DeltaBundler/traverseDependencies.js

@@ -11,27 +11,26 @@
 'use strict';
 
 import type {TransformResultDependency} from '../ModuleGraph/types.flow';
-import type {MetroSourceMapSegmentTuple} from 'metro-source-map';
 
 export type Dependency = {|
   absolutePath: string,
   data: TransformResultDependency,
 |};
 
-export type Module = {|
+export type Module<T> = {|
   dependencies: Map<string, Dependency>,
   inverseDependencies: Set<string>,
-  output: TransformOutput,
+  output: $ReadOnlyArray<T>,
   path: string,
   getSource: () => string,
 |};
 
-export type Graph = {|
+export type Graph<T> = {|
-  dependencies: Map<string, Module>,
+  dependencies: Map<string, Module<T>>,
   entryPoints: $ReadOnlyArray<string>,
 |};
 
-type Result = {added: Map<string, Module>, deleted: Set<string>};
+type Result<T> = {added: Map<string, Module<T>>, deleted: Set<string>};
 
 /**
  * Internal data structure that the traversal logic uses to know which of the
@@ -39,29 +38,21 @@ type Result = {added: Map<string, Module>, deleted: Set<string>};
  * (a file should not be deleted if it has been added, but it should if it
  * just has been modified).
  **/
-type Delta = {
+type Delta<T> = {
-  added: Map<string, Module>,
+  added: Map<string, Module<T>>,
-  modified: Map<string, Module>,
+  modified: Map<string, Module<T>>,
   deleted: Set<string>,
 };
 
-export type TransformOutput = $ReadOnlyArray<{|
+export type TransformFn<T> = string => Promise<{|
-  +data: {
-    +code: string,
-    +map: Array<MetroSourceMapSegmentTuple>,
-  },
-  +type: string,
-|}>;
-
-export type TransformFn = string => Promise<{|
   dependencies: $ReadOnlyArray<TransformResultDependency>,
-  output: TransformOutput,
+  output: $ReadOnlyArray<T>,
   +getSource: () => string,
 |}>;
 
-export type Options = {|
+export type Options<T> = {|
   resolve: (from: string, to: string) => string,
-  transform: TransformFn,
+  transform: TransformFn<T>,
   onProgress: ?(numProcessed: number, total: number) => mixed,
 |};
 
@@ -76,11 +67,11 @@ export type Options = {|
  * method should traverse. Normally, these paths should be the modified files
  * since the last traversal.
  */
-async function traverseDependencies(
+async function traverseDependencies<T>(
   paths: $ReadOnlyArray<string>,
-  graph: Graph,
+  graph: Graph<T>,
-  options: Options,
+  options: Options<T>,
-): Promise<Result> {
+): Promise<Result<T>> {
   const delta = {
     added: new Map(),
     modified: new Map(),
@@ -134,10 +125,10 @@ async function traverseDependencies(
   };
 }
 
-async function initialTraverseDependencies(
+async function initialTraverseDependencies<T>(
-  graph: Graph,
+  graph: Graph<T>,
-  options: Options,
+  options: Options<T>,
-): Promise<Result> {
+): Promise<Result<T>> {
   graph.entryPoints.forEach(entryPoint => createModule(entryPoint, graph));
 
   await traverseDependencies(graph.entryPoints, graph, options);
@@ -150,11 +141,11 @@ async function initialTraverseDependencies(
   };
 }
 
-async function traverseDependenciesForSingleFile(
+async function traverseDependenciesForSingleFile<T>(
-  module: Module,
+  module: Module<T>,
-  graph: Graph,
+  graph: Graph<T>,
-  delta: Delta,
+  delta: Delta<T>,
-  options: Options,
+  options: Options<T>,
 ): Promise<void> {
   let numProcessed = 0;
   let total = 1;
@@ -179,11 +170,11 @@ async function traverseDependenciesForSingleFile(
   options.onProgress && options.onProgress(numProcessed, total);
 }
 
-async function processModule(
+async function processModule<T>(
-  module: Module,
+  module: Module<T>,
-  graph: Graph,
+  graph: Graph<T>,
-  delta: Delta,
+  delta: Delta<T>,
-  options: Options,
+  options: Options<T>,
   onDependencyAdd: () => mixed,
   onDependencyAdded: () => mixed,
 ): Promise<void> {
@@ -239,12 +230,12 @@ async function processModule(
   await Promise.all(promises);
 }
 
-async function addDependency(
+async function addDependency<T>(
-  parentModule: Module,
+  parentModule: Module<T>,
   path: string,
-  graph: Graph,
+  graph: Graph<T>,
-  delta: Delta,
+  delta: Delta<T>,
-  options: Options,
+  options: Options<T>,
   onDependencyAdd: () => mixed,
   onDependencyAdded: () => mixed,
 ): Promise<void> {
@@ -276,11 +267,11 @@ async function addDependency(
   onDependencyAdded();
 }
 
-function removeDependency(
+function removeDependency<T>(
-  parentModule: Module,
+  parentModule: Module<T>,
   absolutePath: string,
-  graph: Graph,
+  graph: Graph<T>,
-  delta: Delta,
+  delta: Delta<T>,
 ): void {
   const module = graph.dependencies.get(absolutePath);
 
@@ -309,7 +300,7 @@ function removeDependency(
   graph.dependencies.delete(module.path);
 }
 
-function createModule(filePath: string, graph: Graph): Module {
+function createModule<T>(filePath: string, graph: Graph<T>): Module<T> {
   const module = {
     dependencies: new Map(),
     inverseDependencies: new Set(),
@@ -323,10 +314,10 @@ function createModule(filePath: string, graph: Graph): Module {
   return module;
 }
 
-function resolveDependencies(
+function resolveDependencies<T>(
   parentPath: string,
   dependencies: $ReadOnlyArray<TransformResultDependency>,
-  options: Options,
+  options: Options<T>,
 ): Map<string, Dependency> {
   return new Map(
     dependencies.map(result => {
@@ -346,7 +337,7 @@ function resolveDependencies(
  * Re-traverse the dependency graph in DFS order to reorder the modules and
  * guarantee the same order between runs. This method mutates the passed graph.
  */
-function reorderGraph(graph: Graph) {
+function reorderGraph<T>(graph: Graph<T>) {
   const orderedDependencies = new Map();
 
   graph.entryPoints.forEach(entryPoint => {
@@ -362,10 +353,10 @@ function reorderGraph(graph: Graph) {
   graph.dependencies = orderedDependencies;
 }
 
-function reorderDependencies(
+function reorderDependencies<T>(
-  graph: Graph,
+  graph: Graph<T>,
-  module: Module,
+  module: Module<T>,
-  orderedDependencies: Map<string, Module>,
+  orderedDependencies: Map<string, Module<T>>,
 ): void {
   if (module.path) {
     if (orderedDependencies.has(module.path)) {

packages/metro/src/HmrServer.js

@@ -21,12 +21,11 @@ const {
   Logger: {createActionStartEntry, createActionEndEntry, log},
 } = require('metro-core');
 
-import type {Graph} from './DeltaBundler/DeltaCalculator';
+import type PackagerServer, {JsGraph} from './Server';
-import type PackagerServer from './Server';
 import type {Reporter} from './lib/reporting';
 
 type Client = {|
-  graph: Graph,
+  graph: JsGraph,
   sendFn: (data: string) => mixed,
 |};
 

packages/metro/src/JSTransformer/worker.js

@@ -37,10 +37,17 @@ import type {Ast} from '@babel/core';
 import type {Plugins as BabelPlugins} from 'babel-core';
 import type {LogEntry} from 'metro-core/src/Logger';
 import type {MetroSourceMapSegmentTuple} from 'metro-source-map';
-import type {TransformOutput} from '../DeltaBundler/traverseDependencies';
+
+export type JsOutput = {|
+  data: {
+    +code: string,
+    +map: Array<MetroSourceMapSegmentTuple>,
+  },
+  type: string,
+|};
 
 export type TransformedCode = {|
-  output: TransformOutput,
+  output: $ReadOnlyArray<JsOutput>,
   dependencies: $ReadOnlyArray<TransformResultDependency>,
 |};
 

packages/metro/src/Server.js

@@ -53,13 +53,15 @@ import type {
   PostProcessBundleSourcemap,
 } from './Bundler';
 import type {CacheStore} from 'metro-cache';
-import type {Delta, Graph} from './DeltaBundler';
+import type {Graph} from './DeltaBundler';
+import type {DeltaResult} from './DeltaBundler/DeltaCalculator';
 import type {CustomResolver} from 'metro-resolver';
 import type {MetroSourceMap} from 'metro-source-map';
 import type {Symbolicate} from './Server/symbolicate/symbolicate';
 import type {AssetData} from './Assets';
 import type {
   CustomTransformOptions,
+  JsOutput,
   TransformedCode,
 } from './JSTransformer/worker';
 
@@ -70,8 +72,8 @@ const {
 type ResolveSync = (path: string, opts: ?{baseDir?: string}) => string;
 
 type GraphInfo = {|
-  graph: Graph,
+  graph: Graph<JsOutput>,
-  prepend: $ReadOnlyArray<Module>,
+  prepend: $ReadOnlyArray<Module<JsOutput>>,
   lastModified: Date,
   +sequenceId: string,
 |};
@@ -87,6 +89,8 @@ export type BuildGraphOptions = {|
   +type: 'module' | 'script',
 |};
 
+export type JsGraph = Graph<JsOutput>;
+
 type DeltaOptions = BundleOptions & {
   deltaBundleId: ?string,
 };
@@ -143,7 +147,7 @@ class Server {
   _symbolicateInWorker: Symbolicate;
   _platforms: Set<string>;
   _nextBundleBuildID: number;
-  _deltaBundler: DeltaBundler;
+  _deltaBundler: DeltaBundler<JsOutput>;
   _graphs: Map<string, Promise<GraphInfo>> = new Map();
   _deltaGraphs: Map<string, Promise<GraphInfo>> = new Map();
 
@@ -256,7 +260,7 @@ class Server {
     this._bundler.end();
   }
 
-  getDeltaBundler(): DeltaBundler {
+  getDeltaBundler(): DeltaBundler<JsOutput> {
     return this._deltaBundler;
   }
 
@@ -286,7 +290,7 @@ class Server {
   async buildGraph(
     entryFiles: $ReadOnlyArray<string>,
     options: BuildGraphOptions,
-  ): Promise<Graph> {
+  ): Promise<JsGraph> {
     entryFiles = entryFiles.map(entryFile =>
       getAbsolutePath(entryFile, this._opts.projectRoots),
     );
@@ -445,7 +449,7 @@ class Server {
 
   async _getDeltaInfo(
     options: DeltaOptions,
-  ): Promise<{...GraphInfo, delta: Delta}> {
+  ): Promise<{...GraphInfo, delta: DeltaResult<JsOutput>}> {
     const id = this._optionsHash(options);
     let graphPromise = this._deltaGraphs.get(id);
     let graphInfo;

packages/metro/src/index.js

@@ -31,7 +31,7 @@ const {readFile} = require('fs-extra');
 const {Terminal} = require('metro-core');
 
 import type {ConfigT} from './Config';
-import type {Graph} from './DeltaBundler';
+import type {JsGraph} from './Server';
 import type {Reporter} from './lib/reporting';
 import type {RequestOptions, OutputOptions} from './shared/types.flow.js';
 import type {Options as ServerOptions} from './shared/types.flow';
@@ -381,7 +381,7 @@ exports.buildGraph = async function({
   platform = `web`,
   type = 'module',
   ...rest
-}: BuildGraphOptions): Promise<Graph> {
+}: BuildGraphOptions): Promise<JsGraph> {
   const metroServer = await runMetro({
     ...rest,
     config,

packages/metro/src/lib/getAppendScripts.js

@@ -12,6 +12,7 @@
 
 import type {Graph} from '../DeltaBundler/DeltaCalculator';
 import type {Module} from '../DeltaBundler/traverseDependencies';
+import type {JsOutput} from '../JSTransformer/worker';
 
 type Options<T: number | string> = {
   +createModuleId: string => T,
@@ -23,9 +24,9 @@ type Options<T: number | string> = {
 
 function getAppendScripts<T: number | string>(
   entryPoint: string,
-  graph: Graph,
+  graph: Graph<JsOutput>,
   options: Options<T>,
-): $ReadOnlyArray<Module> {
+): $ReadOnlyArray<Module<JsOutput>> {
   const output = [];
 
   if (options.runModule) {

packages/metro/src/lib/getPrependedScripts.js

@@ -17,7 +17,7 @@ const transformHelpers = require('./transformHelpers');
 import type Bundler from '../Bundler';
 import type {Module} from '../DeltaBundler/traverseDependencies';
 import type DeltaBundler from '../DeltaBundler';
-import type {CustomTransformOptions} from '../JSTransformer/worker';
+import type {CustomTransformOptions, JsOutput} from '../JSTransformer/worker';
 
 type Options = {
   getPolyfills: ({platform: ?string}) => $ReadOnlyArray<string>,
@@ -36,8 +36,8 @@ async function getPrependedScripts(
   options: Options,
   bundleOptions: BundleOptions,
   bundler: Bundler,
-  deltaBundler: DeltaBundler,
+  deltaBundler: DeltaBundler<JsOutput>,
-): Promise<Array<Module>> {
+): Promise<Array<Module<JsOutput>>> {
   // Get all the polyfills from the relevant option params (the
   // `getPolyfills()` method and the `polyfillModuleNames` variable).
   const polyfillModuleNames = options
@@ -80,7 +80,7 @@ async function getPrependedScripts(
   ];
 }
 
-function _getPrelude({dev}: {dev: boolean}): Module {
+function _getPrelude({dev}: {dev: boolean}): Module<JsOutput> {
   const code = getPreludeCode({isDev: dev});
   const name = '__prelude__';
 

packages/metro/src/lib/transformHelpers.js

@@ -13,7 +13,7 @@
 import type Bundler from '../Bundler';
 import type {TransformFn} from '../DeltaBundler/traverseDependencies';
 import type DeltaBundler from '../DeltaBundler';
-import type {TransformOptions} from '../JSTransformer/worker';
+import type {JsOutput, TransformOptions} from '../JSTransformer/worker';
 import type {BuildGraphOptions} from '../Server';
 
 type InlineRequiresRaw = {+blacklist: {[string]: true}} | boolean;
@@ -21,7 +21,7 @@ type InlineRequiresRaw = {+blacklist: {[string]: true}} | boolean;
 async function calcTransformerOptions(
   entryFiles: $ReadOnlyArray<string>,
   bundler: Bundler,
-  deltaBundler: DeltaBundler,
+  deltaBundler: DeltaBundler<JsOutput>,
   options: BuildGraphOptions,
 ): Promise<{...TransformOptions, inlineRequires: InlineRequiresRaw}> {
   const {
@@ -85,9 +85,9 @@ function removeInlineRequiresBlacklistFromOptions(
 async function getTransformFn(
   entryFiles: $ReadOnlyArray<string>,
   bundler: Bundler,
-  deltaBundler: DeltaBundler,
+  deltaBundler: DeltaBundler<JsOutput>,
   options: BuildGraphOptions,
-): Promise<TransformFn> {
+): Promise<TransformFn<JsOutput>> {
   const dependencyGraph = await bundler.getDependencyGraph();
   const {inlineRequires, ...transformerOptions} = await calcTransformerOptions(
     entryFiles,