status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

packager: TransformCache: trivial optimization wins 

Reviewed By: davidaurelio

Differential Revision: D5068811

fbshipit-source-id: 74e4c3218581b2cb081cb7da7639356d0a7d0430
This commit is contained in:
Jean Lauliac 2017-05-16 05:01:05 -07:00 committed by Facebook Github Bot
parent ab81cb02f1
commit c5dfa2dbd5
1 changed files with 36 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
packages/metro-bundler/src/lib/TransformCache.js
View File

@ -138,10 +138,19 @@ class TransformCache {
*/
_readSync(props: ReadTransformProps): TransformCacheResult {
this._collectIfNecessarySync(props.cacheOptions);
const cacheFilePaths = this._getCacheFilePaths(props);
let metadata, transformedCode;
try {
metadata = readMetadataFileSync(cacheFilePaths.metadata);
return this._readFilesSync(props);
} catch (error) {
if (error.code === 'ENOENT') {
return {result: null, outdatedDependencies: EMPTY_ARRAY};
}
throw error;
}
}
_readFilesSync(props: ReadTransformProps): TransformCacheResult {
const cacheFilePaths = this._getCacheFilePaths(props);
const metadata = readMetadataFileSync(cacheFilePaths.metadata);
if (metadata == null) {
return {result: null, outdatedDependencies: EMPTY_ARRAY};
}
@ -149,7 +158,10 @@ class TransformCache {
if (sourceHash !== metadata.cachedSourceHash) {
return {result: null, outdatedDependencies: metadata.dependencies};
}
transformedCode = fs.readFileSync(cacheFilePaths.transformedCode, 'utf8');
const transformedCode = fs.readFileSync(
cacheFilePaths.transformedCode,
'utf8',
);
const codeHash = crypto
.createHash('sha1')
.update(transformedCode)
@ -157,12 +169,6 @@ class TransformCache {
if (metadata.cachedResultHash !== codeHash) {
return {result: null, outdatedDependencies: metadata.dependencies};
}
} catch (error) {
if (error.code === 'ENOENT') {
return {result: null, outdatedDependencies: EMPTY_ARRAY};
}
throw error;
}
return {
result: {
code: transformedCode,
@ -336,15 +342,7 @@ function readMetadataFileSync(
sourceMap: ?MappingsMap,
} {
const metadataStr = fs.readFileSync(metadataFilePath, 'utf8');
let metadata;
try {
metadata = JSON.parse(metadataStr);
} catch (error) {
if (error instanceof SyntaxError) {
return null;
}
throw error;
}
const metadata = tryParseJSON(metadataStr);
if (!Array.isArray(metadata)) {
return null;
}
@ -375,6 +373,17 @@ function readMetadataFileSync(
};
}
function tryParseJSON(str: string): any {
try {
return JSON.parse(str);
} catch (error) {
if (error instanceof SyntaxError) {
return null;
}
throw error;
}
}
function hashSourceCode(props: {
filePath: string,
sourceCode: string,