status-im/metro
2
0
Fork 0
mirror of https://github.com/status-im/metro.git synced 2025-03-02 11:40:55 +00:00
Code Issues Projects Releases Wiki Activity

Adds additional help when a module is missing.

Browse Source 
Summary:Hey.  Long time fan, first time forker.

You know when you're working on a project with someone and they bring in a new dependency?

When you first pull their code and you haven't also installed that dependency, the error that is shown is this:

![image](https://cloud.githubusercontent.com/assets/68273/13145164/d8748b3e-d61c-11e5-9df9-3e47edf3fcfb.png)

This PR simply adds  `or running "npm install"` to the end of that message.

Just adds a little clarity to newcomers.  Hell knows I was lost for a while when I was starting.

![image](https://cloud.githubusercontent.com/assets/68273/13145253/65e8f31a-d61d-11e5-99ac-2d79d8e37123.png)
Closes https://github.com/facebook/react-native/pull/6009

Differential Revision: D2949127

Pulled By: davidaurelio

fb-gh-sync-id: b297d8c1570fec23cb179ddab4847e2438cc463b
shipit-source-id: b297d8c1570fec23cb179ddab4847e2438cc463b
This commit is contained in:
Steve Kellock 2016-02-18 07:35:18 -08:00 committed by facebook-github-bot-6
parent 278b40ff69
commit c107132a36
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
react-packager/src/Resolver/polyfills/require-unbundle.js vendored
View File

@ -80,7 +80,7 @@ function unknownModuleError(id) {
let message = 'Requiring unknown module "' + id + '".';
if (__DEV__) {
message +=
'If you are sure the module is there, try restarting the packager.';
'If you are sure the module is there, try restarting the packager or running "npm install".';
}
return Error(message);
}

2
react-packager/src/Resolver/polyfills/require.js vendored
View File

@ -48,7 +48,7 @@ function requireImpl(id) {
if (!mod) {
var msg = 'Requiring unknown module "' + id + '"';
if (__DEV__) {
msg += '. If you are sure the module is there, try restarting the packager.';
msg += '. If you are sure the module is there, try restarting the packager or running "npm install".';
}
throw new Error(msg);
}