status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

packager: ResolutionRequest: stronger option typing 

Reviewed By: cpojer

Differential Revision: D4906382

fbshipit-source-id: 1696c3e7fe07c84a3a497740dc87a237d9b71d1e
This commit is contained in:
Jean Lauliac 2017-04-18 10:01:21 -07:00 committed by Facebook Github Bot
parent e18d213116
commit aa3be70fb9
2 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/metro-bundler/src/ModuleGraph/node-haste/node-haste.js
View File

@ -112,7 +112,6 @@ exports.createResolveFn = function(options: ResolveOptions): ResolveFn {
entryPath: '', entryPath: '',
extraNodeModules, extraNodeModules,
hasteFS, hasteFS,
hasteMap,
helpers, helpers,
matchFiles: filesByDirNameIndex.match.bind(filesByDirNameIndex), matchFiles: filesByDirNameIndex.match.bind(filesByDirNameIndex),
moduleCache, moduleCache,

26
packages/metro-bundler/src/node-haste/DependencyGraph/ResolutionRequest.js
View File

@ -59,19 +59,19 @@ type ModuleishCache<TModule, TPackage> = {
type MatchFilesByDirAndPattern = (dirName: string, pattern: RegExp) => Array<string>; type MatchFilesByDirAndPattern = (dirName: string, pattern: RegExp) => Array<string>;
type Options<TModule, TPackage> = { type Options<TModule, TPackage> = {|
dirExists: DirExistsFn, +dirExists: DirExistsFn,
entryPath: string, +entryPath: string,
extraNodeModules: ?Object, +extraNodeModules: ?Object,
hasteFS: HasteFS, +hasteFS: HasteFS,
helpers: DependencyGraphHelpers, +helpers: DependencyGraphHelpers,
matchFiles: MatchFilesByDirAndPattern, +matchFiles: MatchFilesByDirAndPattern,
moduleCache: ModuleishCache<TModule, TPackage>, +moduleCache: ModuleishCache<TModule, TPackage>,
moduleMap: ModuleMap, +moduleMap: ModuleMap,
platform: string, +platform: string,
platforms: Set<string>, +platforms: Set<string>,
preferNativePlatform: boolean, +preferNativePlatform: boolean,
}; |};
/** /**
* It may not be a great pattern to leverage exception just for "trying" things * It may not be a great pattern to leverage exception just for "trying" things