status-im
/
metro
mirror of https://github.com/status-im/metro.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Don't hardcode 'localhost:8081' as the _hmrURL in the Bundler 

Summary:martinbigio this fixes your TODO. 🚀 🚀 🚀
Closes https://github.com/facebook/react-native/pull/5827

Differential Revision: D2932188

Pulled By: martinbigio

fb-gh-sync-id: 8c8caf0782f05b51c90c8d09fdb743ddd3e6f97e
shipit-source-id: 8c8caf0782f05b51c90c8d09fdb743ddd3e6f97e
This commit is contained in:
Adam Miskiewicz 2016-02-26 09:14:18 -08:00 committed by Facebook Github Bot 1
parent 02feea9a5a
commit 9de2ed3d48
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
react-packager/src/Bundler/index.js vendored
View File

@ -168,9 +168,9 @@ class Bundler {
}); });
} }
_sourceHMRURL(platform, path) { _sourceHMRURL(platform, host, port, path) {
return this._hmrURL( return this._hmrURL(
'http://localhost:8081', // TODO: (martinb) avoid hardcoding `http://${host}:${port}`,
platform, platform,
'bundle', 'bundle',
path, path,
@ -211,10 +211,10 @@ class Bundler {
); );
} }
hmrBundle(options) { hmrBundle(options, host, port) {
return this._bundle({ return this._bundle({
bundle: new HMRBundle({ bundle: new HMRBundle({
sourceURLFn: this._sourceHMRURL.bind(this, options.platform), sourceURLFn: this._sourceHMRURL.bind(this, options.platform, host, port),
sourceMappingURLFn: this._sourceMappingHMRURL.bind( sourceMappingURLFn: this._sourceMappingHMRURL.bind(
this, this,
options.platform, options.platform,

4
react-packager/src/Server/index.js vendored
View File

@ -240,8 +240,8 @@ class Server {
return this.buildBundle(options); return this.buildBundle(options);
} }
buildBundleForHMR(modules) { buildBundleForHMR(modules, host, port) {
return this._bundler.hmrBundle(modules); return this._bundler.hmrBundle(modules, host, port);
} }
getShallowDependencies(entryFile) { getShallowDependencies(entryFile) {